Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Alan Jenkins <alan.christopher.jenkins@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: "cake@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
Subject: Re: [Cake] cake target corner cases?
Date: Mon, 2 Nov 2015 00:20:51 +0000	[thread overview]
Message-ID: <CANmMgnFZT5dWUd15+6kDN3sQOfuVf=g5q2G-+GuabU4DiT38QA@mail.gmail.com> (raw)
In-Reply-To: <AC22FB4A-355D-4F51-B356-7D83F38182B0@darbyshire-bryant.me.uk>

On 01/11/2015, Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
>
> Can't give full explanation now but the bytes per ns calculation which is
> used as a basis for target on 'slow' links uses mtu*1.5
>
> --
> Cheers,

Right.  And mtu*1.5 matches better than my math, if I look at Sebs
figures again.  Oops :).

I thought SQM works fine with mtu * 1.0.  But cake has been like this
since at least April, and I didn't notice an extra 7ms when I tried
it.  Confusing.

Sebs 12.5% is indeed 1/8th.  (See last line).


	u32 byte_target = mtu + (mtu >> 1);	/* MTU * 1.5 */
...
	byte_target_ns = (byte_target * rate_ns) >> rate_shft;

	b->cparams.target = max(byte_target_ns, ns_target);
	b->cparams.interval = max(rtt_est_ns +
				     b->cparams.target - ns_target,
				     b->cparams.target * 8);

Maybe this keeps the target/interval ratio from going too far over the
recommended 10%.  Though that's not what CoDel says to do.

In the CoDel draft you just don't drop below 1 MTU.  You don't adjust
target for the rate.  There's no suggestion to increase interval
either.  It makes sense that long transmission times add to the
expected rtt (SQM does this too).  I can't see what the justification
is for `target * 8` though.  If there's a good reason maybe it could
use a comment.

Thanks
Alan

  reply	other threads:[~2015-11-02  0:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-01 18:07 Sebastian Moeller
2015-11-01 20:58 ` Alan Jenkins
2015-11-01 21:52   ` Kevin Darbyshire-Bryant
2015-11-02  0:20     ` Alan Jenkins [this message]
2015-11-02 11:17       ` Sebastian Moeller
2015-11-02 16:20         ` Alan Jenkins
2015-11-02 18:49           ` Sebastian Moeller
2015-11-02 20:38             ` Alan Jenkins
2015-11-02 11:23     ` Sebastian Moeller
2015-11-02 11:29   ` Sebastian Moeller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANmMgnFZT5dWUd15+6kDN3sQOfuVf=g5q2G-+GuabU4DiT38QA@mail.gmail.com' \
    --to=alan.christopher.jenkins@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=kevin@darbyshire-bryant.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox