From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id F2D2F3B29E for ; Mon, 9 Dec 2024 08:26:22 -0500 (EST) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5d41848901bso358253a12.0 for ; Mon, 09 Dec 2024 05:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733750782; x=1734355582; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UyOKraohbpCbJjgoD+Q4ojxiEjD3M3oqArgjS6aAPB0=; b=IvPjYIrxNC2naTuJE59y3dgo7S589CgcEMxiiuE1EpqTJbpVM8fiYIjfYE4YUMf7fR mTzry8F4kkR8yarvl4h6GUIr7igNo89qcELM1dfxQfJS1WqTj3YKlUpz2/yx4mS01rXs PzVFDhwuevfrSKRIIO+pJfBnVCeFeKs6JTM7+U3nCvCMHOMr30W3IffvQoEE4vyojcxE Dgs83ANzYANGG8t5bPoXaHslNrvNRcyBia3RfZRb7pBix6grd4y5OeS1ygsXKwVQ0/bE iBfzOnr2/ffF0guiF6smKoEjd1a/HHjQ3Y7MEF6DgEFIaCRV69yc9ucjuwUWpwtvtXRq SG1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733750782; x=1734355582; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UyOKraohbpCbJjgoD+Q4ojxiEjD3M3oqArgjS6aAPB0=; b=PQ97FLKaaI88uV0ibn8IFN+OLE7vWVwcxNBlbBxx7SwpvSDW/8egVMevHfUIxCobcR fT2R98buyDtZYfhFFQlcDFo9J5kKGjwpt9a/jdPUnI0Hb7XtZmWU3AFPL7+/NN1TayF9 kgIZVu91pEQ0wYOT8BYUUA3odnh+rOx+a7dAuh7CNuU3G9np6yUQdSoMxOfGVp0KlTZr N8PeAam4Ppj+p6zrGklLNe5dSxEykdQJb53xSB6bAU1Lom1sGWcw1BAQbTMww/u5qA/Y kxw9wfvy7SWrg1UkuB9uZLMGyuXW2HfHpxMFPjsLEFNmfR+XzkJ3Zo3IomyO/loxknXU ByWQ== X-Forwarded-Encrypted: i=1; AJvYcCUlbCbZ/PvnvQV5V3e/7qK4bhNcJLMwT6GV/PGq/gcvBKUjVe2Kqw8Bie+glgc2I5P3YLET@lists.bufferbloat.net X-Gm-Message-State: AOJu0YzD3Mz61u+0+jExCm5PEGOCnoYXugN6R7WK9xhu3WxWBwsFGl1L UfS2Pn3t+BUAAo7ybqQI8pWTZwS2vtwIyOD0PwYejB2KWIWBQ7W9xyZgm+3EuPwOho6OG88Et2v TD2BHCkJ/obKNT2WhNXopQ+M+KzU9AZorIDQ+ X-Gm-Gg: ASbGncvymy0+w8sZHP4hTihA5qvMLqtcr0hZF05R9n8nhe1Jaw9QJ8luPB4PIaCa5ZL jYTUH7yNfRKpTbWG+m5aItWwYbRCRzA== X-Google-Smtp-Source: AGHT+IGrteuKL+cXgGPqeJvWmTXfuM/VQrXx0WWPWPLPZQgNKio6EXWsneFfhIIwWD5lb1FbwWQAnWJJzUYPZ/q5KFo= X-Received: by 2002:a05:6402:3216:b0:5d3:cd9a:d05e with SMTP id 4fb4d7f45d1cf-5d3cd9adc64mr11993753a12.9.1733750781720; Mon, 09 Dec 2024 05:26:21 -0800 (PST) MIME-Version: 1.0 References: <20241209-cake-drop-reason-v1-1-19205f6d1f19@redhat.com> In-Reply-To: <20241209-cake-drop-reason-v1-1-19205f6d1f19@redhat.com> From: Eric Dumazet Date: Mon, 9 Dec 2024 14:26:10 +0100 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jamal Hadi Salim , Cong Wang , Jiri Pirko , netdev@vger.kernel.org, cake@lists.bufferbloat.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next] net_sched: sch_cake: Add drop reasons X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Dec 2024 13:26:23 -0000 On Mon, Dec 9, 2024 at 1:02=E2=80=AFPM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Add three qdisc-specific drop reasons for sch_cake: > > 1) SKB_DROP_REASON_CAKE_CONGESTED > Whenever a packet is dropped by the CAKE AQM algorithm because > congestion is detected. > > 2) SKB_DROP_REASON_CAKE_FLOOD > Whenever a packet is dropped by the flood protection part of the > CAKE AQM algorithm (BLUE). > > 3) SKB_DROP_REASON_CAKE_OVERLIMIT > Whenever the total queue limit for a CAKE instance is exceeded and a > packet is dropped to make room. > > Also use the existing SKB_DROP_REASON_QUEUE_PURGE in cake_clear_tin(). > > Reasons show up as: > > perf record -a -e skb:kfree_skb sleep 1; perf script > > iperf3 665 [005] 848.656964: skb:kfree_skb: skbaddr=3D0xf= fff98168a333500 rx_sk=3D(nil) protocol=3D34525 location=3D__dev_queue_xmit+= 0x10f0 reason: CAKE_OVERLIMIT > swapper 0 [001] 909.166055: skb:kfree_skb: skbaddr=3D0xf= fff98168280cee0 rx_sk=3D(nil) protocol=3D34525 location=3Dcake_dequeue+0x5e= f reason: CAKE_CONGESTED > > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen Reviewed-by: Eric Dumazet