From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=google.com; arc=pass; dmarc=pass (Used From Domain Record) header.from=google.com policy.dmarc=reject Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by mail.toke.dk (Postfix) with ESMTPS id A36DE11DF38D for ; Tue, 09 Jun 2026 03:08:21 +0200 (CEST) Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-8ce65629acaso57846286d6.3 for ; Mon, 08 Jun 2026 18:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780967300; cv=none; d=google.com; s=arc-20240605; b=WMMpY/KM6Gzfzis5eTw9R15jqBsnI21gCwWUmc5+umhJuolCnDUQrcpjn8PHDoekIa /Lh9SmhSXD7tIuiTOBqyOo6WN5memgIPAm1OK5pGZHfuhqerq8vQY0P1bVJ6z7UenRBi /CdBfTt1FIHMil/ck9dBivGFj0X3GqVlNTq9QY6WXAujAeN9mrBuGJpqsLobJfdTmQOV MzMTLguPAZ0dCFxNLuKXg8iSDi6f+Xgeqhfg+t8tMkDVdGEJcUjTf8ow5/DFLIVNLZG9 oPHmIFGPekWanM/muoBuhHHHQL69z2bp+i47jrVYZvsNiuYT8nD+C7g1ZIqwrDQtkYlU ACeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=cZ0jw3ng+NlvVzkHf0LH9zv7jxtMR7ght4NCOa0aFbI=; fh=08cDb513szMD2zZOYgKWzmhrmP+drUsRfZymwZbXV7I=; b=ea3uqRBsec8AvbWpo+o3RdkFTW16FdQiKC7Yv4dvGDBCxbqh8w+YQdgEhTlBnuOSAR K2VyJyRp6VHyEps925cUFsivOVS006xBp7Parjdx79JCx1RsQ1OqskTLrxo+2t/LS0Fg 24FAEVanjA1iq/RKQoyPB3p13MbflQ3TfVG1hls9dUyVAvmfriEns0+nlrFeYQEGVTwJ IphW8HEzb7jWAP7LS5uqERqAHcQRWsnkxkRIEXVfTxDbznuiHehDJKAxZkAshRwbecdh 5+NfTQmHoxKjl8+q5IdA5UFbNW9QN5+AYyrGT43ZEWCJcN9SQSgmphXzyMmpOeJDOfoi z2wQ==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780967300; x=1781572100; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cZ0jw3ng+NlvVzkHf0LH9zv7jxtMR7ght4NCOa0aFbI=; b=W9HsL8+ojBGPVxXu+SOWQZryc34eybKCOQefoWCCLHHhS0pXZJDawHE4K6Dpy2S3eJ PtMSCC0FYU90F2H/51tElQGbKzIXQ2irEHl6hJ0lhQdXT49gngikmST4mP7oQSA0fIPf nThHTRMobf/oS1M9IxAQvm7ZiQJhU7nU6OMUI8mslvbrKk/zRyQzPCPrF0FK9vOGCCoB Vr8cu5Tw5qCvaEc6HiHYkCJXrlqzcjsPbh7B8G7giEwCPR88ULDzPdaawWTTdn2nURpq pcl2z+e7bj/48/omRnTLE+z4QTAC7F4VE3u/9SPNe1eq5N4ImdR6adZ19VS0mRj4twdC UaXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780967300; x=1781572100; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cZ0jw3ng+NlvVzkHf0LH9zv7jxtMR7ght4NCOa0aFbI=; b=VBptoAMf5Ua6BDrCpwTHoHHeFMfgAUvtpn+tFNqly2r7k/FSm/QyS8wIzogo6m+P1K UYj3Tj1Kj50r4R/JcFY4mxLamrON3izMWiF0J8gsBoRiZrHg01vxcPwEaxP/AQYgRM3K 5qIFAR2rmYCYWtv/uv9VYf42ezWzxNLpTjGIo7X4H/PsoPVm58lEkS0qMWwccYz5vOVw tMqcs397xNPuxHgp4BvwG2RBBXsLqfHxWY/vnVhu1sONehU9LyAN+MFp/ELP15caBOVI /rx2wtwneSLp4GfgTigygL1ByB5J4xXh7/7A37X4zYnlazNBEj+jlnu7PBa/QxQJfM2X 0l1Q== X-Forwarded-Encrypted: i=1; AFNElJ+AAhkcmT8ieTMMAUXazZQ6H5bMfBsWPBOp39oTME4mcOeQoLnK0MpHe17lA8m2jlyqWk1O@lists.bufferbloat.net X-Gm-Message-State: AOJu0YxJyMD2Y6WtfOAmzDjJWh2Tb4F7VyICr6cBZLD+pCJKzu9MslrU yEFLoOua276rcBa6k4qUsH7WolZxzr1o/NalX5Vfb3RaTStsHO8diWNkhPIjl4yfk+xPQTqG6A0 l8xUHWcdwDTo9+KG6ZiC+180MxLVP/GWcQqVq6YsQ X-Gm-Gg: Acq92OGnPuYcnC10MHiaBrPcepX8StGcDdyQjsAZGPrE/8NHgwoj8OYi+SAJIl92K8s s++Dvit2K9R9KW7ebaIWUrsuv4T2KfXvF1Uq35riUFab1X9n4yM0S6lljqD+B2HHwXiLUEBUTKW 7VZxuYsicK4WE1KdO/yhUSphHcXmvEmehBSvPFqJnY5Q3sKwkObAbOH3oSWwtBuyHCSMwMURITG 3KZiPGZiRuFwmUPgwtGkmBvyXvtu6voh0ys62WCB8zFnJODc/peqemm90Vxi5a604iE3Wb5326U tIt6sfE02y2EJzGv9fyK9oH0m36vgasnHbSO4pJQ38ycVQi+KXdWl42/+xJO6psGHMNl01lCgji SRYpskWbFjoaKp2Oqyvte04gyrOJE X-Received: by 2002:ac8:4809:0:b0:517:905d:dc78 with SMTP id d75a77b69052e-51795bbf697mr168742361cf.37.1780967299211; Mon, 08 Jun 2026 18:08:19 -0700 (PDT) MIME-Version: 1.0 References: <20260609000605.1234374.9ba17536ec9e.cake-rate-change-stale-flow-deficit@trailofbits.com> In-Reply-To: <20260609000605.1234374.9ba17536ec9e.cake-rate-change-stale-flow-deficit@trailofbits.com> From: Eric Dumazet Date: Mon, 8 Jun 2026 18:08:06 -0700 X-Gm-Features: AVVi8CcWqj5XkBGeI0RWp9QsvgH183uDTooR3NDMdJKlXMm8EzL2qdTzeZnRykg Message-ID: To: Samuel Moelius Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , "moderated list:CAKE QDISC" , "open list:TC subsystem" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: UJUCL43ZK2JS6H2K3RNCPPQ65XRF2NNT X-Message-ID-Hash: UJUCL43ZK2JS6H2K3RNCPPQ65XRF2NNT X-MailFrom: edumazet@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH] net/sched: cake: clamp active flow deficit on rate changes List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jun 8, 2026 at 5:08=E2=80=AFPM Samuel Moelius wrote: > > Changing CAKE rate parameters updates the quantum used for future > scheduling, but active flows can retain deficit computed under the old > rate. > > That stale deficit lets an already active flow receive service based on > the previous configuration after userspace changes the shaper rate. > > After recomputing rate-derived scheduling parameters, clamp positive > active-flow deficits to the quantum that applies under the new > configuration. > > Assisted-by: Codex:gpt-5.5-cyber-preview > Signed-off-by: Samuel Moelius > --- This is bloat for a not existent issue. pw-bot: cr