From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id C875A21F44D for ; Fri, 16 Oct 2015 06:37:57 -0700 (PDT) Received: by pabrc13 with SMTP id rc13so121408962pab.0 for ; Fri, 16 Oct 2015 06:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=puitBX4xZk+xrVYEqlfGz9iPmFqQUL2Pmd4VFeQeoC4=; b=avDsHPb8s1dK/IcihJq0yRUUsZWZrksUbeTzgdgTMBxwgr8OTP6oEbNroYJbGlbXgE IJiQPt3mNgQB8Tabo62uONHf3/U4Zd2FXfTsZdgR91fQumg/lLt+se9ItwTxa2gMRXQg mlMpWetLIQ4LD8sdlBMrpq8Y4G7il6ahzMLQqpHgfFg7qo9RMR+XOPtWOoh4bOrvFqpn YMLU630fs45RRydA7fweEHd5gbP1uZkzlqXDfWHhiZqwGPSjhXocqB0qC3qZpj1kaiFj 8msvaGtqrMxgYkdvtGqhnFpdzOf98OaX50JhwJHapCa+zWYHa9XvtzbKYtuzXv1LwePp +CgA== MIME-Version: 1.0 X-Received: by 10.66.102.106 with SMTP id fn10mr16720257pab.156.1445002676627; Fri, 16 Oct 2015 06:37:56 -0700 (PDT) Received: by 10.66.23.38 with HTTP; Fri, 16 Oct 2015 06:37:56 -0700 (PDT) In-Reply-To: <5620FB43.1080100@darbyshire-bryant.me.uk> References: <561F9431.6050606@darbyshire-bryant.me.uk> <5620FB43.1080100@darbyshire-bryant.me.uk> Date: Fri, 16 Oct 2015 17:37:56 +0400 Message-ID: From: Loganaden Velvindron To: Kevin Darbyshire-Bryant Content-Type: multipart/alternative; boundary=047d7bd907083d75c4052238e723 Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Fresh from the bakery X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2015 13:38:20 -0000 --047d7bd907083d75c4052238e723 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Oct 16, 2015 at 5:27 PM, Kevin Darbyshire-Bryant < kevin@darbyshire-bryant.me.uk> wrote: > > > On 16/10/15 11:24, Loganaden Velvindron wrote: > > > > > > On Fri, Oct 16, 2015 at 1:39 PM, Loganaden Velvindron > > > wrote: > > > > > > > > Building the latest tc-adv causes issues with gcc. > > > > > > gcc -Wall -Wstrict-prototypes -Wmissing-prototypes > > -Wmissing-declarations -Wold-style-definition -Wformat=3D2 -O2 > > -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=3D\"/usr/lib\" > > -DCONFDIR=3D\"/etc/iproute2\" -D_GNU_SOURCE -DHAVE_SETNS -DHAVE_EL= F > > -DCONFIG_GACT -DCONFIG_GACT_PROB > > -DIPT_LIB_DIR=3D\"/usr/lib/iptables\" -DYY_NO_INPUT -c -o > > q_cake0.o q_cake0.c > > In file included from q_cake.c:48:0: > > q_cake.c: In function > > =E2=80=98cake_print_xstats=E2=80=99:../include/utils.h:177:55: erro= r: expected > > expression before =E2=80=98)=E2=80=99 token # define offsetof(type,= member) ( > > (size_t) & ( (type *) 0 )->member ) > > ^q_cake.c:500:31: note: in expansion of > > macro =E2=80=98offsetof=E2=80=99 > > && RTA_PAYLOAD(xstats) >=3D offsetof(*stnc, capacity_estimate)= ) > > > > GCC version: > > gcc version 5.2.0 (GCC) > > > > > > The commit causing the issue is this one: > > > > > https://github.com/dtaht/tc-adv/commit/9b2dc094b2b1526ec4222efc1b0a1d0281= 2def5a > > > > I'm not sure about the fix. here is it: > > > > https://github.com/dtaht/tc-adv/pull/7 > > > > > > > Hi Logan, > > Thanks for the report. It breaks here too :-( I'm annoyed with myself > for merging the latest, latest, latest commits (around 02:00 my time) > early this morning without at least compile testing them. I think it > was about 05:00 whilst doing an overnight shift (Aussie MotoGP) and the > box I did it on is a little out of date and slow (would require a > toolchain rebuild which is about 4 hours!) Normally I at least compile > test. Oh well, move on... > > I'm sure Jonathan will pick this up shortly - In fact as I type this > after just compile testing & installing your fix I notice that he has :-) > > Logan, thanks very much for your fix, it's appreciated. I will however > close your pull request and merge in the (identical!) fix from upstream > to keep the git histories a little closer. > > Thanks for updating the master tree. I was working on another issue, when I encountered this problem with the latest sync :) > Cheers, > > Kevin > > > > --047d7bd907083d75c4052238e723 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Oct 16, 2015 at 5:27 PM, Kevin Darbyshire-Bryant <= kevin@darbyshire-bryant.me.uk> wrote:


On 16/10/15 11:24, Loganaden Velvindron wrote:
>
>
> On Fri, Oct 16, 2015 at 1:39 PM, Loganaden Velvindron
> <log= anaden@gmail.com <mailto:loga= naden@gmail.com>> wrote:
>
>
>
>=C2=A0 =C2=A0 =C2=A0Building the latest tc-adv causes issues with gcc.<= br> >
>
>=C2=A0 =C2=A0 =C2=A0gcc -Wall -Wstrict-prototypes=C2=A0 -Wmissing-proto= types
>=C2=A0 =C2=A0 =C2=A0-Wmissing-declarations -Wold-style-definition -Wfor= mat=3D2 -O2
>=C2=A0 =C2=A0 =C2=A0-I../include -DRESOLVE_HOSTNAMES -DLIBDIR=3D\"= /usr/lib\"
>=C2=A0 =C2=A0 =C2=A0-DCONFDIR=3D\"/etc/iproute2\" -D_GNU_SOUR= CE=C2=A0 -DHAVE_SETNS -DHAVE_ELF
>=C2=A0 =C2=A0 =C2=A0-DCONFIG_GACT -DCONFIG_GACT_PROB
>=C2=A0 =C2=A0 =C2=A0-DIPT_LIB_DIR=3D\"/usr/lib/iptables\" -DY= Y_NO_INPUT=C2=A0 =C2=A0-c -o
>=C2=A0 =C2=A0 =C2=A0q_cake0.o q_cake0.c
>=C2=A0 =C2=A0 =C2=A0In file included from q_cake.c:48:0:
>=C2=A0 =C2=A0 =C2=A0q_cake.c: In function
>=C2=A0 =C2=A0 =C2=A0=E2=80=98cake_print_xstats=E2=80=99:../include/util= s.h:177:55: error: expected
>=C2=A0 =C2=A0 =C2=A0expression before =E2=80=98)=E2=80=99 token # defin= e offsetof(type, member) (
>=C2=A0 =C2=A0 =C2=A0(size_t) & ( (type *) 0 )->member )
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^q_cake.c:500:31: note: in expansion of >=C2=A0 =C2=A0 =C2=A0macro =E2=80=98offsetof=E2=80=99
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 && RTA_PAYLOAD(xstats) >= =3D offsetof(*stnc, capacity_estimate))
>
>=C2=A0 =C2=A0 =C2=A0GCC version:
>=C2=A0 =C2=A0 =C2=A0gcc version 5.2.0 (GCC)
>
>
> The commit causing the issue is this one:
>
> https://github.c= om/dtaht/tc-adv/commit/9b2dc094b2b1526ec4222efc1b0a1d02812def5a
>
> I'm not sure about the fix. here is it:
>
> https://github.com/dtaht/tc-adv/pull/7
>
>
>
Hi Logan,

Thanks for the report.=C2=A0 It breaks here too :-( I'm annoyed with my= self
for merging the latest, latest, latest commits (around 02:00 my time)
early this morning without at least compile testing them.=C2=A0 I think it<= br> was about 05:00 whilst doing an overnight shift (Aussie MotoGP) and the
box I did it on is a little out of date and slow (would require a
toolchain rebuild which is about 4 hours!)=C2=A0 Normally I at least compil= e
test.=C2=A0 Oh well, move on...

I'm sure Jonathan will pick this up shortly - In fact as I type this after just compile testing & installing your fix I notice that he has := -)

Logan, thanks very much for your fix, it's appreciated.=C2=A0 I will ho= wever
close your pull request and merge in the (identical!) fix from upstream
to keep the git histories a little closer.


Thanks for updating the master tree. I= was working on another issue, when I encountered this problem with the lat= est sync :)
=C2=A0
Cheers,

Kevin




--047d7bd907083d75c4052238e723--