Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Loganaden Velvindron <loganaden@gmail.com>
To: cake@lists.bufferbloat.net
Subject: [Cake] trivial patch for sch_cake.c
Date: Wed, 9 Sep 2015 18:35:30 +0000	[thread overview]
Message-ID: <CAOp4FwRnpF=UjY34fJKwhtCk_OZ=6eGoos9mQPWv8WQuCaT4fQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

Hi guys,

Here's a trivial patch to fix a warning with gcc 5.2, as 1 isn't casted
before being compared with an unsigned integer. Diff below:

diff --git a/sch_cake.c b/sch_cake.c
index 3ed18d7..aab0fe3 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -436,7 +436,7 @@ static int cake_enqueue(struct sk_buff *skb,
struct Qdisc *sch)
 	 * Split GSO aggregates if they're likely to impair flow isolation
 	 * or if we need to know individual packet sizes for framing overhead.
 	 */
-	if(unlikely((len * max(fqcd->flow_count, 1) > q->peel_threshold &&
skb_is_gso(skb))))
+	if(unlikely((len * max(fqcd->flow_count, (u32)1) > q->peel_threshold
&& skb_is_gso(skb))))
 	{
 		struct sk_buff *segs, *nskb;
 		netdev_features_t features = netif_skb_features(skb);

[-- Attachment #2: Type: text/html, Size: 856 bytes --]

             reply	other threads:[~2015-09-09 18:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09 18:35 Loganaden Velvindron [this message]
2015-09-18 12:27 ` Loganaden Velvindron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOp4FwRnpF=UjY34fJKwhtCk_OZ=6eGoos9mQPWv8WQuCaT4fQ@mail.gmail.com' \
    --to=loganaden@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox