From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <loganaden@gmail.com>
Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com
	[IPv6:2607:f8b0:400e:c03::22a])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority G2" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id B241B21FD74
	for <cake@lists.bufferbloat.net>; Wed,  9 Sep 2015 11:35:31 -0700 (PDT)
Received: by pacex6 with SMTP id ex6so17704194pac.0
	for <cake@lists.bufferbloat.net>; Wed, 09 Sep 2015 11:35:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:date:message-id:subject:from:to:content-type;
	bh=qFvqLlla19jMF9660l81525lXiFU5HSgh1/PVApKws4=;
	b=Gc1dRtyqS12sC6kGY9P4jM9HBdFd+uf4H+UQ4ooqSr+HCLbIF0DX+IKzMcLPYTLzEy
	ss4eiMi8uKx242ZkjFDllALNuV9ArFNTFc1jY2W8F9NWvri5tQe+EhnLBKpAIXXcAIr2
	15lR/TuxLxWSXjgT6fklvmI4l6UuElH1RW5MNa6nJFnePZKRyuA4tfZuui8//eXd9Rbc
	/aRwQoAshi4+Nbf3dk+KjMPlIv/5hbOtz29gehHoSLBACBOZwy+1BuIT2OESkcunWxIc
	2udkTSFUkcVghV5FuKzC2TdfxbS0WxJA/FEHyh/vHJNHZygVBad6vjwi9SZR7vW+U3py
	unjw==
MIME-Version: 1.0
X-Received: by 10.68.111.98 with SMTP id ih2mr73275647pbb.165.1441823730874;
	Wed, 09 Sep 2015 11:35:30 -0700 (PDT)
Received: by 10.66.236.134 with HTTP; Wed, 9 Sep 2015 11:35:30 -0700 (PDT)
Date: Wed, 9 Sep 2015 18:35:30 +0000
Message-ID: <CAOp4FwRnpF=UjY34fJKwhtCk_OZ=6eGoos9mQPWv8WQuCaT4fQ@mail.gmail.com>
From: Loganaden Velvindron <loganaden@gmail.com>
To: cake@lists.bufferbloat.net
Content-Type: multipart/alternative; boundary=047d7b676b5e4ec37d051f54bf9b
Subject: [Cake] trivial patch for sch_cake.c
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
	<mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 09 Sep 2015 18:35:53 -0000

--047d7b676b5e4ec37d051f54bf9b
Content-Type: text/plain; charset=UTF-8

Hi guys,

Here's a trivial patch to fix a warning with gcc 5.2, as 1 isn't casted
before being compared with an unsigned integer. Diff below:

diff --git a/sch_cake.c b/sch_cake.c
index 3ed18d7..aab0fe3 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -436,7 +436,7 @@ static int cake_enqueue(struct sk_buff *skb,
struct Qdisc *sch)
 	 * Split GSO aggregates if they're likely to impair flow isolation
 	 * or if we need to know individual packet sizes for framing overhead.
 	 */
-	if(unlikely((len * max(fqcd->flow_count, 1) > q->peel_threshold &&
skb_is_gso(skb))))
+	if(unlikely((len * max(fqcd->flow_count, (u32)1) > q->peel_threshold
&& skb_is_gso(skb))))
 	{
 		struct sk_buff *segs, *nskb;
 		netdev_features_t features = netif_skb_features(skb);

--047d7b676b5e4ec37d051f54bf9b
Content-Type: text/html; charset=UTF-8

<div dir="ltr"><div>Hi guys,<br><br></div>Here&#39;s a trivial patch to fix a warning with gcc 5.2, as 1 isn&#39;t casted before being compared with an unsigned integer. Diff below:<br><br><pre>diff --git a/sch_cake.c b/sch_cake.c
index 3ed18d7..aab0fe3 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -436,7 +436,7 @@ static int cake_enqueue(struct sk_buff *skb, struct Qdisc *sch)
 	 * Split GSO aggregates if they&#39;re likely to impair flow isolation
 	 * or if we need to know individual packet sizes for framing overhead.
 	 */
-	if(unlikely((len * max(fqcd-&gt;flow_count, 1) &gt; q-&gt;peel_threshold &amp;&amp; skb_is_gso(skb))))
+	if(unlikely((len * max(fqcd-&gt;flow_count, (u32)1) &gt; q-&gt;peel_threshold &amp;&amp; skb_is_gso(skb))))
 	{
 		struct sk_buff *segs, *nskb;
 		netdev_features_t features = netif_skb_features(skb);
</pre><br></div>

--047d7b676b5e4ec37d051f54bf9b--