From: Loganaden Velvindron <loganaden@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: Dave Taht <dave.taht@gmail.com>, Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] CAKE related iproute2 & kernel patches - keeping things in sync
Date: Mon, 30 Jul 2018 19:41:57 +0400 [thread overview]
Message-ID: <CAOp4FwSBGb6O5T-PuSVf5MY5v744UhiS1NRYC3ORiWbb_DY9vg@mail.gmail.com> (raw)
In-Reply-To: <E8EEDB29-B4FE-4BAD-A027-1058DE2A7A1E@darbyshire-bryant.me.uk>
On Mon, Jul 30, 2018 at 7:07 PM, Kevin Darbyshire-Bryant
<kevin@darbyshire-bryant.me.uk> wrote:
>
>
>> On 30 Jul 2018, at 00:42, Dave Taht <dave.taht@gmail.com> wrote:
>>
>> On Sun, Jul 29, 2018 at 3:05 AM Kevin Darbyshire-Bryant
>> <kevin@darbyshire-bryant.me.uk> wrote:
>>>
>>> To whom it may concern (Dave) ;-)
>>>
>>> This is a general plea that when patches are submitted to upstream please can we also commit them to our current development repositories.
>>
>> Mea culpa. I was hiding under my desk expecting the 10GigE+ world to
>> unite and march upon me, torches ablaze and, while gearing up for
>> battle there, collecting data on how bql and split-gso interacted at
>> various speeds, I didn't expect davem to just take the darn patch.
>
> They’re gathering firewood….and petrol tankers :-)
> Actually I too was pretty surprised to see it committed.
>
>
>> I have this whole lovely, giant, rant ,and plots that I'm not gonna be
>> motivated to finish now.
>>
>> This does raise a long term point however in that as we go mainline
>> more tweaks and patches *will* arrive
>> via normal linux kernel processes from others. Do you want maintainership there?
>
> Personally, Noooo! :-) This sounds like backports territory. And I’m back to that idea of dropping the kmod package and introducing cake via a kernel patch for openwrt. *shudder*
>
>
>>
>>> 4.19 isn’t even released yet, so most people, including Openwrt, get cake via our 'out of tree’ repositories. This is also a good idea from a point of view of testing. I appreciate the latest changes are of ‘one line’ type variety and so mostly harmless but ideally it should at least be in our own out of tree repo’s first/at the same time.
>>>
>>> I had to submit the latest ‘split-gso by default’ patch, accepted to upstream, manually to our own cake repo for Toke to commit. I note with some distress that there’s an ‘iproute2’ upstream patch pending to enable the userspace side of the same thing that currently is NOT in the ‘tc-adv’ repo.
>>>
>>> Dare I also suggest that a man page update would be appreciated by iproute2-next too.
>>
>> I started reviewing the man page's gobble of troff, started writing a
>> tuning section (and decided that needed a web page), went looking for
>> other missing keywords, and... we haven't heard from logan in a
>> while... my back is covered with black jube jells and dust bunnies
>> from hiding under my desk.
>>
Will find time to update the man page :)
>> and I dunno, has anyone read the man page lately? There's a HUGE
>> opportunity to bikeshed there.
>
> Lord no, not the bikeshed! I was more thinking of including the two new keywords that had been introduced….. not going wild :-)
>
> Kevin
next prev parent reply other threads:[~2018-07-30 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 10:05 Kevin Darbyshire-Bryant
2018-07-29 23:42 ` Dave Taht
2018-07-30 15:07 ` Kevin Darbyshire-Bryant
2018-07-30 15:41 ` Loganaden Velvindron [this message]
2018-07-30 17:23 ` [Cake] man page bikeshed Dave Taht
2018-07-30 17:39 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOp4FwSBGb6O5T-PuSVf5MY5v744UhiS1NRYC3ORiWbb_DY9vg@mail.gmail.com \
--to=loganaden@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=kevin@darbyshire-bryant.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox