From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x232.google.com (mail-pa0-x232.google.com [IPv6:2607:f8b0:400e:c03::232]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 8A4CB21F4FE for ; Fri, 16 Oct 2015 03:24:59 -0700 (PDT) Received: by pacfv9 with SMTP id fv9so19077955pac.3 for ; Fri, 16 Oct 2015 03:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=TJPIeXhSXmgUIzOFDjzPm73+QxlsCDvBA2LAUN+tLt0=; b=bT027vGMoTDBabIq36VKu/jbsXQy6knRSOvYDV9Dd4ePZ40jVmhMA/ZCp3U/ZOG5Zg kQqGW/66vjw+YO3zjq6sEUowabT/kfG7gVSM/Eyd2DtnyR0ir9cHKktCjizOlqJZh6oG xN0kaDUjweDEnx+kkoctjfF+OXeTlLPYdy+DucNJI85PQ5j+CATj2+Tvh/6qLLsCGY4E ZvO/WCV3E619dLBtApds5LFdhoOIAWSQyN6r+kyTQxt3T3jFzWLsN6Iqmp39gr2Oxi2l dpqopTdK8ZC1txAryCddU5eTdlZAdxm8NPaDKltjUzuJiLtGpfCOI226TSTb9MHGIeu9 etFA== MIME-Version: 1.0 X-Received: by 10.66.100.165 with SMTP id ez5mr15384837pab.63.1444991098042; Fri, 16 Oct 2015 03:24:58 -0700 (PDT) Received: by 10.66.23.38 with HTTP; Fri, 16 Oct 2015 03:24:57 -0700 (PDT) In-Reply-To: References: <561F9431.6050606@darbyshire-bryant.me.uk> Date: Fri, 16 Oct 2015 14:24:57 +0400 Message-ID: From: Loganaden Velvindron To: Kevin Darbyshire-Bryant Content-Type: multipart/alternative; boundary=047d7bd901861a45b50522363574 Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Fresh from the bakery X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2015 10:25:21 -0000 --047d7bd901861a45b50522363574 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Oct 16, 2015 at 1:39 PM, Loganaden Velvindron wrote: > >> > Building the latest tc-adv causes issues with gcc. > > > gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declaration= s > -Wold-style-definition -Wformat=3D2 -O2 -I../include -DRESOLVE_HOSTNAMES > -DLIBDIR=3D\"/usr/lib\" -DCONFDIR=3D\"/etc/iproute2\" -D_GNU_SOURCE > -DHAVE_SETNS -DHAVE_ELF -DCONFIG_GACT -DCONFIG_GACT_PROB > -DIPT_LIB_DIR=3D\"/usr/lib/iptables\" -DYY_NO_INPUT -c -o q_cake0.o > q_cake0.c > In file included from q_cake.c:48:0: > q_cake.c: In function =E2=80=98cake_print_xstats=E2=80=99:../include/util= s.h:177:55: > error: expected expression before =E2=80=98)=E2=80=99 token # define offs= etof(type, member) > ( (size_t) & ( (type *) 0 )->member ) > ^q_cake.c:500:31: note: in expansion of macro =E2=80=98of= fsetof=E2=80=99 > && RTA_PAYLOAD(xstats) >=3D offsetof(*stnc, capacity_estimate)) > > GCC version: > gcc version 5.2.0 (GCC) > > The commit causing the issue is this one: https://github.com/dtaht/tc-adv/commit/9b2dc094b2b1526ec4222efc1b0a1d02812d= ef5a I'm not sure about the fix. here is it: https://github.com/dtaht/tc-adv/pull/7 --047d7bd901861a45b50522363574 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Oct 16, 2015 at 1:39 PM, Loganaden Velvindron <loganaden@gma= il.com> wrote:

Building the latest tc-adv ca= uses issues with gcc.

=C2=A0
gcc -W= all -Wstrict-prototypes =C2=A0-Wmissing-prototypes -Wmissing-declarations -= Wold-style-definition -Wformat=3D2 -O2 -I../include -DRESOLVE_HOSTNAMES -DL= IBDIR=3D\"/usr/lib\" -DCONFDIR=3D\"/etc/iproute2\" -D_G= NU_SOURCE =C2=A0-DHAVE_SETNS -DHAVE_ELF -DCONFIG_GACT -DCONFIG_GACT_PROB -D= IPT_LIB_DIR=3D\"/usr/lib/iptables\" -DYY_NO_INPUT =C2=A0 -c -o q_= cake0.o q_cake0.c
In file included from q_cake.c:48:0:
= q_cake.c: In function =E2=80=98cake_print_xstats=E2=80=99:../include/utils.= h:177:55: error: expected expression before =E2=80=98)=E2=80=99 token # def= ine offsetof(type, member) ( (size_t) & ( (type *) 0 )->member ) =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^q_cake.c:500:31: note: in expansion= of macro =E2=80=98offsetof=E2=80=99
=C2=A0 =C2=A0 =C2=A0&&am= p; RTA_PAYLOAD(xstats) >=3D offsetof(*stnc, capacity_estimate))

GCC version:
gcc version 5.2.0 (GCC)=C2=A0=


The commit causing = the issue is this one:

https://github.com/dtah= t/tc-adv/commit/9b2dc094b2b1526ec4222efc1b0a1d02812def5a

I'm not sure= about the fix. here is it:

ht= tps://github.com/dtaht/tc-adv/pull/7



--047d7bd901861a45b50522363574--