[Cake] trivial patch for sch_cake.c

[Cake] trivial patch for sch_cake.c

[Loganaden Velvindron]

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

Hi guys,

Here's a trivial patch to fix a warning with gcc 5.2, as 1 isn't casted
before being compared with an unsigned integer. Diff below:

diff --git a/sch_cake.c b/sch_cake.c
index 3ed18d7..aab0fe3 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -436,7 +436,7 @@ static int cake_enqueue(struct sk_buff *skb,
struct Qdisc *sch)
 	 * Split GSO aggregates if they're likely to impair flow isolation
 	 * or if we need to know individual packet sizes for framing overhead.
 	 */
-	if(unlikely((len * max(fqcd->flow_count, 1) > q->peel_threshold &&
skb_is_gso(skb))))
+	if(unlikely((len * max(fqcd->flow_count, (u32)1) > q->peel_threshold
&& skb_is_gso(skb))))
 	{
 		struct sk_buff *segs, *nskb;
 		netdev_features_t features = netif_skb_features(skb);

[-- Attachment #2: Type: text/html, Size: 856 bytes --]

Re: [Cake] trivial patch for sch_cake.c

[Loganaden Velvindron]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

On Wed, Sep 9, 2015 at 6:35 PM, Loganaden Velvindron <loganaden@gmail.com>
wrote:

> Hi guys,
>
> Here's a trivial patch to fix a warning with gcc 5.2, as 1 isn't casted
> before being compared with an unsigned integer. Diff below:
>
> diff --git a/sch_cake.c b/sch_cake.c
> index 3ed18d7..aab0fe3 100644
> --- a/sch_cake.c
> +++ b/sch_cake.c
> @@ -436,7 +436,7 @@ static int cake_enqueue(struct sk_buff *skb, struct Qdisc *sch)
>  	 * Split GSO aggregates if they're likely to impair flow isolation
>  	 * or if we need to know individual packet sizes for framing overhead.
>  	 */
> -	if(unlikely((len * max(fqcd->flow_count, 1) > q->peel_threshold && skb_is_gso(skb))))
> +	if(unlikely((len * max(fqcd->flow_count, (u32)1) > q->peel_threshold && skb_is_gso(skb))))
>  	{
>  		struct sk_buff *segs, *nskb;
>  		netdev_features_t features = netif_skb_features(skb);
>
>
>
Hi Chromi@,

Thanks for fixing that, but in a different way :)

[-- Attachment #2: Type: text/html, Size: 1403 bytes --]