From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 6D68921FA4F for ; Tue, 8 Sep 2015 13:44:02 -0700 (PDT) Received: by padhk3 with SMTP id hk3so48763116pad.3 for ; Tue, 08 Sep 2015 13:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wUiLq+wVNpg9i9LYhxQ6OHRiZflUZj+T9UC5G9j6uKQ=; b=IOpToz6owA0VMu3UOuQ+M0nfSH1UI6xJ+H8hIMRSL95mBf6jDAQYeZkvmVOHADyrue z3jFwv7uRa4R9LW6gdiYKB2xyTvlAr2n7aIBmnPp8a6OhuXJiVOl2aCfpLupJ2UEZElx YprENeMswWbCEDYLPvhQcRfxX/ewLJcuBQtkSqK/hvnYVLKOAQWzfif1EovArYEPafCG Ea2Dq4Le+MmqXKNYLzyweW4a03UHZ8JLFMCB31lypqPbHU7y9HwjEU5obMs7+YJdUs+H GoI5lYESRtGXmVIS09t49SsRCEgNpNUWBysZgJbDB8Wtmb36unN8PfMCLYsV3H13wD2h w19A== MIME-Version: 1.0 X-Received: by 10.66.222.68 with SMTP id qk4mr51663827pac.96.1441745042500; Tue, 08 Sep 2015 13:44:02 -0700 (PDT) Received: by 10.66.236.134 with HTTP; Tue, 8 Sep 2015 13:44:02 -0700 (PDT) In-Reply-To: References: Date: Tue, 8 Sep 2015 20:44:02 +0000 Message-ID: From: Loganaden Velvindron To: Dave Taht Content-Type: multipart/alternative; boundary=047d7b5dbc3e1d8147051f426dae X-Mailman-Approved-At: Wed, 09 Sep 2015 08:21:04 -0700 Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Tuning fq_codel & CAKE X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2015 20:44:25 -0000 --047d7b5dbc3e1d8147051f426dae Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, Sep 6, 2015 at 11:20 AM, Dave Taht wrote: > we need testers at those rtts. > > On Sun, Sep 6, 2015 at 2:45 AM, Loganaden Velvindron > wrote: > > Hi Dave, > > > > Hope you are doing well. I went throgh the design documents, and I was > > wondering where should we (Mauritians) who experience between 250 and > 330 ms > > on international traffic should start tuning the code for our region. > > > > > > Kind regards, > > //Logan > > C-x-C-c > > > > Hi guys, here is a trivial patch for fixing a small casting warning. 1 should be casted as u32, as flow_count is declared as u32. This avoids a warning on my arch_linux. Patch here: diff --git a/sch_cake.c b/sch_cake.c index 3ed18d7..aab0fe3 100644 --- a/sch_cake.c +++ b/sch_cake.c @@ -436,7 +436,7 @@ static int cake_enqueue(struct sk_buff *skb, struct Qdisc *sch) * Split GSO aggregates if they're likely to impair flow isolation * or if we need to know individual packet sizes for framing overhead. */ - if(unlikely((len * max(fqcd->flow_count, 1) > q->peel_threshold && skb_is_gso(skb)))) + if(unlikely((len * max(fqcd->flow_count, (u32)1) > q->peel_threshold && skb_is_gso(skb)))) { struct sk_buff *segs, *nskb; netdev_features_t features =3D netif_skb_features(skb); > > > -- > Dave T=C3=A4ht > endo is a terrible disease: http://www.gofundme.com/SummerVsEndo > --047d7b5dbc3e1d8147051f426dae Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable




On Sun, Sep 6, 2015 at 11:20 AM, Dave Taht &l= t;dave.taht@gmail.= com> wrote:
we need testers at those rtts.

On Sun, Sep 6, 2015 at 2:45 AM, Loganaden Velvindron
<loganaden@gmail.com> wrot= e:
> Hi Dave,
>
> Hope you are doing well. I went throgh the design documents, and I was=
> wondering where should we (Mauritians) who experience between 250 and = 330 ms
> on international traffic should start tuning the code for our region.<= br> >
>
> Kind regards,
> //Logan
> C-x-C-c
>

Hi guys, here is a trivial patc= h for fixing a small casting warning.

1 should be casted as u3= 2, as flow_count is declared as u32. This avoids a warning on my arch_linux= .

Patch here:

diff --git a/sch_cake.c b/sch_cake.c
index 3ed18d7..aab0fe3 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -436,7 +436,7 @@ static int cake_enqueue(struct sk_buff *skb, struct Qdi=
sc *sch)
 	 * Split GSO aggregates if they're likely to impair flow isolation
 	 * or if we need to know individual packet sizes for framing overhead.
 	 */
-	if(unlikely((len * max(fqcd->flow_count, 1) > q->peel_threshold =
&& skb_is_gso(skb))))
+	if(unlikely((len * max(fqcd->flow_count, (u32)1) > q->peel_thres=
hold && skb_is_gso(skb))))
 	{
 		struct sk_buff *segs, *nskb;
 		netdev_features_t features =3D netif_skb_features(skb);


=C2=A0


--
Dave T=C3=A4ht
endo is a terrible disease: http://www.gofundme.com/SummerVsEndo=

--047d7b5dbc3e1d8147051f426dae--