Re: [Cake] Tuning fq_codel & CAKE

Re: [Cake] Tuning fq_codel & CAKE

[Dave Taht]

we need testers at those rtts.

On Sun, Sep 6, 2015 at 2:45 AM, Loganaden Velvindron
<loganaden@gmail.com> wrote:
> Hi Dave,
>
> Hope you are doing well. I went throgh the design documents, and I was
> wondering where should we (Mauritians) who experience between 250 and 330 ms
> on international traffic should start tuning the code for our region.
>
>
> Kind regards,
> //Logan
> C-x-C-c
>



-- 
Dave Täht
endo is a terrible disease: http://www.gofundme.com/SummerVsEndo

Re: [Cake] Tuning fq_codel & CAKE

[Loganaden Velvindron]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

On Sun, Sep 6, 2015 at 11:20 AM, Dave Taht <dave.taht@gmail.com> wrote:

> we need testers at those rtts.
>
> On Sun, Sep 6, 2015 at 2:45 AM, Loganaden Velvindron
> <loganaden@gmail.com> wrote:
> > Hi Dave,
> >
> > Hope you are doing well. I went throgh the design documents, and I was
> > wondering where should we (Mauritians) who experience between 250 and
> 330 ms
> > on international traffic should start tuning the code for our region.
> >
> >
> > Kind regards,
> > //Logan
> > C-x-C-c
> >
>
> Hi guys, here is a trivial patch for fixing a small casting warning.

1 should be casted as u32, as flow_count is declared as u32. This avoids a
warning on my arch_linux.

Patch here:

diff --git a/sch_cake.c b/sch_cake.c
index 3ed18d7..aab0fe3 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -436,7 +436,7 @@ static int cake_enqueue(struct sk_buff *skb,
struct Qdisc *sch)
 	 * Split GSO aggregates if they're likely to impair flow isolation
 	 * or if we need to know individual packet sizes for framing overhead.
 	 */
-	if(unlikely((len * max(fqcd->flow_count, 1) > q->peel_threshold &&
skb_is_gso(skb))))
+	if(unlikely((len * max(fqcd->flow_count, (u32)1) > q->peel_threshold
&& skb_is_gso(skb))))
 	{
 		struct sk_buff *segs, *nskb;
 		netdev_features_t features = netif_skb_features(skb);




>
>
> --
> Dave Täht
> endo is a terrible disease: http://www.gofundme.com/SummerVsEndo
>

[-- Attachment #2: Type: text/html, Size: 2332 bytes --]