Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Xiang Mei <xmei5@asu.edu>
To: Jakub Kicinski <kuba@kernel.org>
Cc: security@kernel.org, netdev@vger.kernel.org, toke@toke.dk,
	xiyou.wangcong@gmail.com, cake@lists.bufferbloat.net,
	bestswngs@gmail.com
Subject: [Cake] Re: [PATCH net v7 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop
Date: Thu, 27 Nov 2025 17:16:18 -0700	[thread overview]
Message-ID: <CAPpSM+S1-c68WsY3KYQp4R3kC+p+eREdJP0Qas9Q68MiA9Y3AA@mail.gmail.com> (raw)
In-Reply-To: <20251127153644.55ef4796@kernel.org>

Thanks for the reminder. The conflict has been resolved in v8.

On Thu, Nov 27, 2025 at 4:36 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 26 Nov 2025 12:45:12 -0700 Xiang Mei wrote:
> > In cake_drop(), qdisc_tree_reduce_backlog() is used to update the qlen
> > and backlog of the qdisc hierarchy. Its caller, cake_enqueue(), assumes
> > that the parent qdisc will enqueue the current packet. However, this
> > assumption breaks when cake_enqueue() returns NET_XMIT_CN: the parent
> > qdisc stops enqueuing current packet, leaving the tree qlen/backlog
> > accounting inconsistent. This mismatch can lead to a NULL dereference
> > (e.g., when the parent Qdisc is qfq_qdisc).
>
> This series does not apply, please rebase on netdev/net/main.
> --
> pw-bot: cr

      reply	other threads:[~2025-11-28  0:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 19:45 [Cake] " Xiang Mei
2025-11-26 19:45 ` [Cake] [PATCH net v7 2/2] selftests/tc-testing: Test CAKE scheduler when enqueue drops packets Xiang Mei
2025-11-27  9:14   ` [Cake] " Toke Høiland-Jørgensen
2025-11-27 18:22   ` Cong Wang
2025-11-27  9:14 ` [Cake] Re: [PATCH net v7 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop Toke Høiland-Jørgensen
2025-11-27 18:21 ` Cong Wang
2025-11-27 23:36 ` Jakub Kicinski
2025-11-28  0:16   ` Xiang Mei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPpSM+S1-c68WsY3KYQp4R3kC+p+eREdJP0Qas9Q68MiA9Y3AA@mail.gmail.com \
    --to=xmei5@asu.edu \
    --cc=bestswngs@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=toke@toke.dk \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox