From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=asu.edu; dkim=pass header.d=asu.edu; arc=none (Message is not ARC signed); dmarc=none Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by mail.toke.dk (Postfix) with ESMTPS id 47EC79D6518 for ; Fri, 28 Nov 2025 01:16:31 +0100 (CET) Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-8823fa3bd95so20062346d6.1 for ; Thu, 27 Nov 2025 16:16:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu.edu; s=google; t=1764288989; x=1764893789; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/f5AJstH+nkEL/NwBUZtkEuWsmh/aI2o6SSahqAyPSM=; b=PY6nOk7M22W4LqwjndCH0ww3uKl0mVdvx4zwEDB+Ao9HqqWDygfV+qGaZOVz0KDkS/ B8iXnp6ngjqo583Q7POZ3syjt/5+Y3tf06SGhAfe/CaRyXOFy+7K+MWx5dXPvSnkSKcM /LRbrLh8zCXomnD0bLVjNv8NhfzHStHZWBROT5ZJTVFUbGexCZC4WJJSdPTF79lLfQgs PAzYyLDcw1LYL1hy4pIdFi186JhsMZpe4nCNTShRguvNrD1zS2CRlB1m9RqfJHhWvm7u lztZ7GFXZgJNcaOWt+Du7up+ASMGmB8b3GxFOkkjfqT+FuswTci9YWQ/7tbNjPcYJD4C Z9OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764288989; x=1764893789; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/f5AJstH+nkEL/NwBUZtkEuWsmh/aI2o6SSahqAyPSM=; b=Q4fdyykeDlP43eoDVa5J+Srgu5xH5MLZhMBHFkJo6suvKroEhSFGalc2LAM6FhmWDD Xxbgl3lUsJME9fNkNwUaJD9MRv9jqBC8SDFrHm6TQuHsFwmNrG44pvruLWY6XpBd/KGN ckg/UI91h/a7BMWr135U0f9OjqqH8IXIbAFUd54vNBOmdAmyhLhS6CzJrN5FEkaTr43K 9JdakXOQ5OGnh7bFzyRF/12kU9Q53A/SlOBCM0SFnWbRp+TZhNjZO/anCcB1+PKSq2cn 7pNFMAMzy+83OjRC3xIFkibviyrBca/XMfTD7Bl19Lcg5qftVq92frkCinH4aVn85sEP BFQw== X-Forwarded-Encrypted: i=1; AJvYcCXiIDJNG0oJc50Gv0nVE7H7wCrxVBE6TVk+OYcDG1pHgtmjn9S27AaxpgRO+8xS9xVLTcH+@lists.bufferbloat.net X-Gm-Message-State: AOJu0YyRAyBNutVAfZIVhK5DRK+VtEKKy2qChQRG9CdBC53GdQqrEhRu ZOA2tswWIpA4jscPtJImZS3LEqTEFuHDenfd1QHdKFSC2cNELOx2dZgL9EsHAw9V4FxOpWP4j1n 2FlvwJKu7j1V9Q223A1yMcl40SuHgxCH9HnXwdVQm X-Gm-Gg: ASbGncvPWG3isuHabfviM/3Dtl1PQ69KATDHAK9D3K+oHq2vuZzPEHlbBoIbCE6VfxW IJz3SbGWx8cyGCmfJHo7mOsWF/goaAdS/XBJ4PNxdGDKKsmW+3dsFj77a4mLF5iAyKTbspweHnW Y9tS3YL+UQeFh0QuLQADHrT96vEepiKxwWFfBopn0DxpWgmQEQ2UYiAYKgNSD+vLCywZMjwkk1A 2RGs132ji87ociS5hYL9/wJxVekWo/7yVf5Rww9Am/ZGUIfWmajvk12jM8xNS/Vjk+DLeyZMYXi rmo5vdQ= X-Google-Smtp-Source: AGHT+IHqtqFThjT0il3Av8xWTU6PtV96MSG8Goe9XxzXE4td+Exyt3EFwZ1YQr+Qn1b36fkEWbyrs9Jz6MGV1Fprrjw= X-Received: by 2002:a05:620a:1990:b0:8b2:f0be:27f5 with SMTP id af79cd13be357-8b33be05c62mr3793893285a.36.1764288989592; Thu, 27 Nov 2025 16:16:29 -0800 (PST) MIME-Version: 1.0 References: <20251126194513.3984722-1-xmei5@asu.edu> <20251127153644.55ef4796@kernel.org> In-Reply-To: <20251127153644.55ef4796@kernel.org> From: Xiang Mei Date: Thu, 27 Nov 2025 17:16:18 -0700 X-Gm-Features: AWmQ_bnOxFilKmR9vNSK0sO-1VqGCMNowWWrP0Rc25rhrMJR1r8SMo-VGLfuglE Message-ID: To: Jakub Kicinski Cc: security@kernel.org, netdev@vger.kernel.org, toke@toke.dk, xiyou.wangcong@gmail.com, cake@lists.bufferbloat.net, bestswngs@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MailFrom: xmei5@asu.edu X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: CBXBIRQJADLS7IRPIPAESKPFAZJ777YR X-Message-ID-Hash: CBXBIRQJADLS7IRPIPAESKPFAZJ777YR X-Mailman-Approved-At: Fri, 28 Nov 2025 10:33:13 +0100 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v7 1/2] net/sched: sch_cake: Fix incorrect qlen reduction in cake_drop List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the reminder. The conflict has been resolved in v8. On Thu, Nov 27, 2025 at 4:36=E2=80=AFPM Jakub Kicinski wr= ote: > > On Wed, 26 Nov 2025 12:45:12 -0700 Xiang Mei wrote: > > In cake_drop(), qdisc_tree_reduce_backlog() is used to update the qlen > > and backlog of the qdisc hierarchy. Its caller, cake_enqueue(), assumes > > that the parent qdisc will enqueue the current packet. However, this > > assumption breaks when cake_enqueue() returns NET_XMIT_CN: the parent > > qdisc stops enqueuing current packet, leaving the tree qlen/backlog > > accounting inconsistent. This mismatch can lead to a NULL dereference > > (e.g., when the parent Qdisc is qfq_qdisc). > > This series does not apply, please rebase on netdev/net/main. > -- > pw-bot: cr