From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=asu.edu; dkim=pass header.d=asu.edu; arc=none (Message is not ARC signed); dmarc=none Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by mail.toke.dk (Postfix) with ESMTPS id 1B51A9D20DD for ; Wed, 26 Nov 2025 20:48:37 +0100 (CET) Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-8b2dcdde65bso16638385a.0 for ; Wed, 26 Nov 2025 11:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu.edu; s=google; t=1764186516; x=1764791316; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PFotFf9eRXbFpwRIPK8Y1pStWXq1Ooupie4cSLAWHYE=; b=sIfnrWUaIiiKL1rUyC7hdjutLWtF+eUhugIoJuK/tkk0fVpiLWYazk0AtqTHAFyEBN K7H6NbrzANLhWn6XZr+FI5zSvwFElDrYWUgibZzmzzQsEqK4/0OenfKyYH6QrTIPKSyP yKMXzeSkxbmgxRQubfXHp/vleg71qI829G8z1GOOa+jPPmzHnHRKvge3EfXzU6ZtyTsF WeYlfeTivyve1SAGMW7tbpZTvdc1JqYXU6lwUjL7TNfr/QAhvmrpvK+5SvD9jV+4lCfC Rp9uWl2CsQQWunwf+k0+dNRUyoM5fXZxQEXnKpyWYK6jqNNT/GQXb58tDdyHSfg7XBbJ Xx7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764186516; x=1764791316; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PFotFf9eRXbFpwRIPK8Y1pStWXq1Ooupie4cSLAWHYE=; b=b/FhwgSVYfLsbatk1MzM8qYKRrDCgJyP9EAVQSSqRCbDp99yyhslMXvDDnm+9fakXv iKOzYQotQ+gOwQliXpUUweRwsSuOABUsAA3hZVmhWsoRjQlrdiLWrulzLmZjak/q9KlD CGBPS0oOr3gwQ0/Q+0J1f+UxbAOE4cot+U4L6S/cL7w3sYwAEm1jsjezMcn+CJGPGcF4 w/ToxB29QoLBwqAD/jOm2nNr13qnR7AhgvksrI9Kkv13yT6V5Brc6T4E1t/2+jDD4XlR lVYURuawlo6lTVo1HaM5agGEimxb1jqhbBAduR0S317IR6fDWHcurR2tfnk56OpLNcyp vhaQ== X-Forwarded-Encrypted: i=1; AJvYcCVdOYb0jkOZ3U1qcbxV/DZ3i+heYP5wGCMKytQAe2lqlwp6T/rizEQaXqK/43UEC1k7heCq@lists.bufferbloat.net X-Gm-Message-State: AOJu0Yy7dczgbxprvY/01mJHxPycgNkPEQOLvjOy3UDo2rBmNJIcjEIc 28Oz8UWXfbjNx+AWq4MlkBuZu7MX0XxipWhLO9Mt5V8HFNWgYZZamQZCUCrfy6Gal/TUAC1ouF2 c2bafQFpya0CVmZexa0u7Z8Yy9lhlM/yoYiCRvtn7 X-Gm-Gg: ASbGncscL+31jgaqOa5gI4daU+FPZgLxyExWgzwAruL+LsXp/RP/3hYrvhxcuJRlVxY 3zLcB1z9YWgP94lzsDX7n7qPmceY34CaGJlSyfxsZ0Grg+S8OP/hDJ7o+QC2BUSn5P6Ly6RCa2s 2nqrbGzwGz/AR9fqDEfzdx57LxRV67E8eB5TwvuTP45lbRYemwnebQ3PHgnlJ/yeXNHGWlfX3z6 ql2Og+NCCkl8R4AmvrICYC2tI2gyL2X4ffmVDuseonhFITVa/jKTri24gbFLxB1fxRQO342 X-Google-Smtp-Source: AGHT+IENrgViP+CJjX20jMp6vNHT546q8bzoXHJFb0lfZj5ixlrK/z5Tv9Mq9Nyut67ffu4w/nPa/B0AUGPOFzYFx4c= X-Received: by 2002:a05:620a:2a14:b0:8b2:ef6c:802f with SMTP id af79cd13be357-8b4ebdbd606mr951117585a.59.1764186516257; Wed, 26 Nov 2025 11:48:36 -0800 (PST) MIME-Version: 1.0 References: <20251125220213.3155360-1-xmei5@asu.edu> <20251125220213.3155360-2-xmei5@asu.edu> In-Reply-To: From: Xiang Mei Date: Wed, 26 Nov 2025 12:48:25 -0700 X-Gm-Features: AWmQ_bnZLgaO-xI4nwZnXo7XsCIxODjbujQeVlbyfZNDMBHPfOXW9JHL9HQrTRY Message-ID: To: Cong Wang Cc: security@kernel.org, netdev@vger.kernel.org, toke@toke.dk, cake@lists.bufferbloat.net, bestswngs@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MailFrom: xmei5@asu.edu X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: WGGQZHXK7QF7ERUJ5GDV5FE5ASZPMBFL X-Message-ID-Hash: WGGQZHXK7QF7ERUJ5GDV5FE5ASZPMBFL X-Mailman-Approved-At: Thu, 27 Nov 2025 10:31:21 +0100 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v6 2/2] selftests/tc-testing: Check Cake Scheduler when enqueue drops packets List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the tips. I have sent the new patch: I moved the test to qdisc.json and tested it with the patch in 1/2. Appreciate your review. Best, Xiang On Tue, Nov 25, 2025 at 9:08=E2=80=AFPM Cong Wang wrote: > > On Tue, Nov 25, 2025 at 03:02:13PM -0700, Xiang Mei wrote: > > Add tests that trigger packet drops in cake_enqueue(). The tests use > > CAKE under a QFQ parent/class, then replace CAKE with NETEM to exercise > > the previously fixed bug where cake_enqueue() drops a packet in the > > same flow and returns NET_XMIT_CN. > > > > Signed-off-by: Xiang Mei > > --- > > .../tc-testing/tc-tests/qdiscs/cake.json | 28 +++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > Usually tools/testing/selftests/tc-testing/tc-tests/infra/qdiscs.json > is a better place for testing Qdisc combinations. > > Regards, > Cong