From: Jonathan Morton <chromatix99@gmail.com>
To: Jendaipou Palmei <jendaipoupalmei@gmail.com>
Cc: Dave Taht <dave.taht@gmail.com>,
dave@taht.net, cake@lists.bufferbloat.net
Subject: Re: [Cake] COBALT implementation in ns-3 with results under different traffic scenarios
Date: Tue, 27 Nov 2018 16:36:57 +0200 [thread overview]
Message-ID: <CB1C8BED-8AA3-4239-9233-38B09C9BE331@gmail.com> (raw)
In-Reply-To: <CAFLFmiXkV+Cb9M2aRP6FJtWUM0A-kHk_jDXLVwx_sfmiD3mOQQ@mail.gmail.com>
> On 27 Nov, 2018, at 4:10 pm, Jendaipou Palmei <jendaipoupalmei@gmail.com> wrote:
>
> We have made the changes in the code as suggested.
>
> Here is the diff after making the changes:
>
> https://github.com/Daipu/COBALT/commit/033db330287e2072bad94ac441f8aed774678a7d
>
> Additionally, we have also updated the values of 'Pincrement' and 'Pdecrement' (parameters of BLUE) in ns-3 to match the ones used in the Cake implementation in Linux.
>
> Does the diff look correct?
It does look like an improvement. How's the behaviour?
NB: the decimal values used in the constants are not quite precise equivalents of the Linux values, since you have dropped some of the trailing digits. You could use (1./256) and (1./4096) to both make them precise and more human-readable.
- Jonathan Morton
next prev parent reply other threads:[~2018-11-27 14:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 13:57 Jendaipou Palmei
2018-11-22 15:32 ` Dave Taht
2018-11-23 10:52 ` Jendaipou Palmei
2018-11-23 16:05 ` Dave Taht
2018-11-23 16:43 ` Dave Taht
2018-11-23 17:13 ` Jonathan Morton
2018-11-24 2:59 ` Jonathan Morton
2018-11-25 6:22 ` Jendaipou Palmei
2018-11-27 14:10 ` Jendaipou Palmei
2018-11-27 14:36 ` Jonathan Morton [this message]
2018-11-30 11:53 ` Jendaipou Palmei
2018-11-30 11:58 ` Jonathan Morton
2018-12-04 10:31 ` Jendaipou Palmei
2018-12-04 14:39 ` Dave Taht
2018-12-04 15:02 ` Jonathan Morton
2018-12-04 15:20 ` Dave Taht
2018-12-05 12:23 ` Jendaipou Palmei
2018-12-05 14:23 ` Jonathan Morton
2018-12-06 17:36 ` Jonathan Morton
2018-12-09 8:37 ` Jendaipou Palmei
2018-12-09 13:21 ` Jonathan Morton
2018-12-10 12:30 ` Jendaipou Palmei
2018-12-10 15:15 ` Jonathan Morton
2018-12-15 19:06 ` Shefali Gupta
2018-12-15 20:10 ` Dave Taht
2018-12-21 10:37 ` Shefali Gupta
2018-12-21 12:48 ` Jonathan Morton
2019-01-21 11:35 ` Shefali Gupta
2019-01-21 12:57 ` Jonathan Morton
2019-01-23 16:19 ` Shefali Gupta
2019-01-23 16:23 ` Jonathan Morton
2019-01-23 17:27 ` Shefali Gupta
2019-01-25 8:35 ` Shefali Gupta
2019-01-25 9:16 ` Jonathan Morton
2019-01-25 14:48 ` Shefali Gupta
2019-01-25 15:07 ` Jonathan Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB1C8BED-8AA3-4239-9233-38B09C9BE331@gmail.com \
--to=chromatix99@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
--cc=dave@taht.net \
--cc=jendaipoupalmei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox