From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id AED983CB35 for ; Tue, 27 Nov 2018 09:37:01 -0500 (EST) Received: by mail-lf1-x142.google.com with SMTP id u18so16610638lff.10 for ; Tue, 27 Nov 2018 06:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=dX/Mbo/ugSN5QhuA8emNkiLCK2xP9M0i7vanv3yA0Wo=; b=Oi/Zt+qXzhz9O2GTGoRUqV0RrM5mvuxgMZodtozYJgcGZsYtQc7InwRTHTfdEitd4R Tf6/htDYurTIg+REm0Pl+p140ESQ6FJwsdzsO6LuwRN+/6tkIlSpR3MTyKGtn1N5aZdG l0Z4UA7ILXHIbYXXAb3YLxyBTtHOjwt5aec4uHfyP2qSoqMur0kVbUsxBQXdHYfSuTxi wEjxk5ntssM6SFglAyfv3aBZTyt/CEXjREEHSz0nK9wHS/6vvrK92F4RByNCxWoOpyuX WCrPO1fbtjni/W142CzXoSFv4ZATo13bKbk3tAkU1CmSAJcXgF1I+4omCcbLXhnBpjBU p0xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=dX/Mbo/ugSN5QhuA8emNkiLCK2xP9M0i7vanv3yA0Wo=; b=dY4GeF3sCV2REnEzpyTa18R89RplN9dhnmkzRXiKkBsbFWsdkxhXzqYLcV00AI1koz +KfapOm0Au7pK7Z9a+k3mfIW5OuXYjhG5DXArdJdEJWHQ5OwtHz2IEZ6l3R4JgXM4NxY uijVxCYlW9M6t1BvbE52Xa/Kjm4qpHR34te2k3bEwQnAp/PaW0tG6qL0wz/Mp+vULG50 AxFQxnPv+o8WMiyQr0/ze0TDnJCS6VtoDe+QeVFq/k3u1l7HN8QXfuW2WjgTcd2qhTyg IsYk/0f4rRDyA6y1bYiM5ldyrjWYvO8T8GKKiivgXiyU5leNwJZg18n2CVNwGlmQWY81 b6Uw== X-Gm-Message-State: AA+aEWZiwLR3E4KuyIT9bIvCYugAMOGPVDcHj8IKaYEqbxSIAulym0GZ KkG5m+k2rbCXaKyorm1skYk= X-Google-Smtp-Source: AFSGD/UqTOFxDKQuYxIRBx7+FpjPAZaKpIur2/YiSM1qEgvMHid/7W3WxkbXFlT8Hd4lj/OinXw+ug== X-Received: by 2002:a19:ced3:: with SMTP id e202mr12219775lfg.13.1543329420475; Tue, 27 Nov 2018 06:37:00 -0800 (PST) Received: from jonathartonsmbp.lan (83-245-236-220-nat-p.elisa-mobile.fi. [83.245.236.220]) by smtp.gmail.com with ESMTPSA id u26-v6sm586845lji.22.2018.11.27.06.36.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Nov 2018 06:36:59 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Jonathan Morton In-Reply-To: Date: Tue, 27 Nov 2018 16:36:57 +0200 Cc: Dave Taht , dave@taht.net, cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: References: <87va4nzsn4.fsf@taht.net> <6578A0D1-FF6A-474E-A6D5-98185F98CB45@gmail.com> To: Jendaipou Palmei X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] COBALT implementation in ns-3 with results under different traffic scenarios X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 14:37:01 -0000 > On 27 Nov, 2018, at 4:10 pm, Jendaipou Palmei = wrote: >=20 > We have made the changes in the code as suggested. >=20 > Here is the diff after making the changes: >=20 > = https://github.com/Daipu/COBALT/commit/033db330287e2072bad94ac441f8aed7746= 78a7d >=20 > Additionally, we have also updated the values of 'Pincrement' and = 'Pdecrement' (parameters of BLUE) in ns-3 to match the ones used in the = Cake implementation in Linux. >=20 > Does the diff look correct? It does look like an improvement. How's the behaviour? NB: the decimal values used in the constants are not quite precise = equivalents of the Linux values, since you have dropped some of the = trailing digits. You could use (1./256) and (1./4096) to both make them = precise and more human-readable. - Jonathan Morton