Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Pete Heist <pete@heistp.net>
To: gamanakis@gmail.com
Cc: Cake List <cake@lists.bufferbloat.net>,
	Jonathan Morton <chromatix99@gmail.com>,
	toke@toke.dk
Subject: Re: [Cake] dual-src/dsthost unfairness, only with bi-directional traffic
Date: Sat, 26 Jan 2019 08:35:38 +0100	[thread overview]
Message-ID: <CCE434E1-A0E2-43CB-BFA8-C6AF5C725DAC@heistp.net> (raw)
In-Reply-To: <000501d4ad4e$24718220$6d548660$@gmail.com>

I ran my original iperf3 test with and without the patch, through my one-armed router with hfsc+cake on egress each direction at 100Mbit:

Unpatched:

IP1 1-flow TCP up: 11.3
IP2 8-flow TCP up: 90.1
IP1 8-flow TCP down: 89.8
IP2 1-flow TCP down: 11.3
Jain’s fairness index, directional: 0.623 up, 0.631 down
Jain’s fairness index, aggregate: 0.997

Patched:

IP1 1-flow TCP up: 51.0
IP2 8-flow TCP up: 51.0
IP1 8-flow TCP down: 50.7
IP2 1-flow TCP down: 50.6
Jain’s fairness index, directional: 1.0 up, 0.999 down
Jain’s fairness index, aggregate: 0.999

So this confirms George’s result. :)

Obviously if we look at _aggregate_ fairness it’s essentially the same in both cases. I think directional fairness is what users would expect though.

Can anyone think of any potentially pathological cases from considering only bulk flows for fairness, that I can test? Otherwise, I’d like to see this idea taken in...

> On Jan 16, 2019, at 4:47 AM, gamanakis@gmail.com wrote:
> 
> Of course I pasted the results for IP1 and IP2 the wrong way. Sorry!
> These are the correct results, along with the *.flent.gz files.
> 
> IP1: 
> flent -H 192.168.1.2 tcp_8down &
> Data file written to ./tcp_8down-2019-01-15T223703.709305.flent.gz.
> Summary of tcp_8down test run at 2019-01-16 03:37:03.709305:
> 
>                             avg       median          # data pts
> Ping (ms) ICMP   :         0.78         0.72 ms              342
> TCP download avg :         6.03         5.83 Mbits/s         301
> TCP download sum :        48.24        46.65 Mbits/s         301
> TCP download::1  :         6.03         5.83 Mbits/s         298
> TCP download::2  :         6.03         5.83 Mbits/s         297
> TCP download::3  :         6.03         5.83 Mbits/s         297
> TCP download::4  :         6.03         5.83 Mbits/s         298
> TCP download::5  :         6.03         5.83 Mbits/s         298
> TCP download::6  :         6.03         5.83 Mbits/s         298
> TCP download::7  :         6.03         5.83 Mbits/s         297
> TCP download::8  :         6.03         5.83 Mbits/s         298
> 
> 
> flent -H 192.168.1.2 tcp_1up &
> Data file written to ./tcp_1up-2019-01-15T223704.711193.flent.gz.
> Summary of tcp_1up test run at 2019-01-16 03:37:04.711193:
> 
>                           avg       median          # data pts
> Ping (ms) ICMP :         0.79         0.73 ms              342
> TCP upload     :        48.12        46.69 Mbits/s         294
> 
> 
> 
> IP2:
> flent -H 192.168.1.2 tcp_1down &
> Data file written to ./tcp_1down-2019-01-15T223705.693550.flent.gz.
> Summary of tcp_1down test run at 2019-01-16 03:37:05.693550:
> 
>                           avg       median          # data pts
> Ping (ms) ICMP :         0.77         0.69 ms              341
> TCP download   :        48.10        46.65 Mbits/s         300
> 
> 
> flent -H 192.168.1.2 tcp_8up &
> Data file written to ./tcp_8up-2019-01-15T223706.706614.flent.gz.
> Summary of tcp_8up test run at 2019-01-16 03:37:06.706614:
> 
>                           avg       median          # data pts
> Ping (ms) ICMP :         0.74         0.70 ms              341
> TCP upload avg :         6.03         5.83 Mbits/s         301
> TCP upload sum :        48.25        46.63 Mbits/s         301
> TCP upload::1  :         6.04         5.86 Mbits/s         226
> TCP upload::2  :         6.03         5.86 Mbits/s         226
> TCP upload::3  :         6.03         5.86 Mbits/s         226
> TCP upload::4  :         6.03         5.86 Mbits/s         225
> TCP upload::5  :         6.03         5.86 Mbits/s         226
> TCP upload::6  :         6.03         5.86 Mbits/s         226
> TCP upload::7  :         6.03         5.78 Mbits/s         220
> TCP upload::8  :         6.03         5.88 Mbits/s         277
> 
> 
> <tcp_8up-2019-01-15T223706.706614.flent.gz><tcp_8down-2019-01-15T223703.709305.flent.gz><tcp_1up-2019-01-15T223704.711193.flent.gz><tcp_1down-2019-01-15T223705.693550.flent.gz>


  parent reply	other threads:[~2019-01-26  7:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01 23:04 Pete Heist
2019-01-03  3:57 ` Georgios Amanakis
2019-01-03  4:15   ` Georgios Amanakis
2019-01-03  5:18     ` Jonathan Morton
2019-01-03 10:46       ` Pete Heist
2019-01-03 11:03         ` Toke Høiland-Jørgensen
2019-01-03 13:02           ` Pete Heist
2019-01-03 13:20             ` Toke Høiland-Jørgensen
2019-01-03 16:35               ` Pete Heist
2019-01-03 18:24                 ` Georgios Amanakis
2019-01-03 22:06                 ` Pete Heist
2019-01-04  2:08                   ` Georgios Amanakis
2019-01-04  8:09                     ` Pete Heist
2019-01-04  7:37                   ` Pete Heist
2019-01-04 11:34             ` Pete Heist
2019-01-15 19:22               ` George Amanakis
2019-01-15 22:42                 ` Georgios Amanakis
2019-01-16  3:34                   ` George Amanakis
2019-01-16  3:47                     ` gamanakis
2019-01-16  7:58                       ` Pete Heist
2019-01-26  7:35                       ` Pete Heist [this message]
2019-01-28  1:34                         ` Georgios Amanakis
2019-01-18 10:06                     ` Toke Høiland-Jørgensen
2019-01-18 12:07                       ` Georgios Amanakis
2019-01-18 13:33                         ` Toke Høiland-Jørgensen
2019-01-18 13:40                           ` Sebastian Moeller
2019-01-18 14:30                             ` Toke Høiland-Jørgensen
2019-01-18 13:45                           ` Jonathan Morton
2019-01-18 14:32                             ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CCE434E1-A0E2-43CB-BFA8-C6AF5C725DAC@heistp.net \
    --to=pete@heistp.net \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    --cc=gamanakis@gmail.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox