From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3656B3B29E for ; Sat, 26 Jan 2019 02:35:41 -0500 (EST) Received: by mail-wr1-x441.google.com with SMTP id l9so12486945wrt.13 for ; Fri, 25 Jan 2019 23:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=BnBNsQwTmqKplJUMII6XMOmUi7/7QlD58sOptHI3gIg=; b=krseyS4pqGJbwQIOxJ76hAZYT1pneuOuw5p7cRAioRboh5G9XIJLc38oT7ZQxf5OBC 8jgtKRRV0olYp9ArSEuSW6yCpmlIYXUmiLsrpWugrD4Grn/0U+760j3zuqF2AsLMt9XJ cP0tXzF9ocAa4Lp6dvNLWyiItkXCzmUAq1ve2saaCW65UOOp9UPcH3ClUh9hL7D3FLCE KFvM86c9nfAWd/NAFFEWzUWqzGsub3CmMibuA+uNYNZIgR1uG1hfB9+Qod2QzEVXzOTw yclJsHqscTxyB883qhluZzpQN92dmYFx8okal3amOvQ5igUtj815hrknH8Yji2XYtBEf SwKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=BnBNsQwTmqKplJUMII6XMOmUi7/7QlD58sOptHI3gIg=; b=VRpnw5/8/0yVdJUYWtcwB3wd2rgnB8nBNGMj94zo/WidfT8I+UShQS83sTYJRjvSnw k0v4fQhxSf91jZd1no3U/JI8pBDkKO1hJEBWxaPQjUCqq2Oj7A/jwm33zXtf8xI+ckbr Mz4AX8P0W178EMXfBz2pismCq6WMnp2ljkeqV+zygZVk/E8k5ieFG9ZchdU9vlBBG1Un Rw0VA1F4SjWt1uS3Vk0cPrrdiWvZ29jo27QVan0N7Q6c1E9C5HMup2iWwDSYW3eGxF1c O+y7iQtNMWGaGJY1Bnh6CrdUnxUrvt2FZdMSs6sMLF8qBYyY+pD5Yj8Wx90ml0FmCxuq y3Yw== X-Gm-Message-State: AJcUukdopYq5xR0nTuE2NIGV2NccEUJFHcHyt2Nt0jn8ctM+4U5MUfP7 Pe1ypixCv6IppwZLldqGQXYBYg== X-Google-Smtp-Source: ALg8bN7BInmt7aAmWJoM+rpOlKEnVIz/Nzmy/34MNDVzUez0oVQ6OaFCohLZasxYUieXRexRoeAP/w== X-Received: by 2002:adf:8264:: with SMTP id 91mr13672866wrb.312.1548488140217; Fri, 25 Jan 2019 23:35:40 -0800 (PST) Received: from tron.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id p139sm131682076wmd.31.2019.01.25.23.35.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 23:35:39 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Pete Heist In-Reply-To: <000501d4ad4e$24718220$6d548660$@gmail.com> Date: Sat, 26 Jan 2019 08:35:38 +0100 Cc: Cake List , Jonathan Morton , toke@toke.dk Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190116033430.8446-1-gamanakis@gmail.com> <000501d4ad4e$24718220$6d548660$@gmail.com> To: gamanakis@gmail.com X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Cake] dual-src/dsthost unfairness, only with bi-directional traffic X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2019 07:35:41 -0000 I ran my original iperf3 test with and without the patch, through my = one-armed router with hfsc+cake on egress each direction at 100Mbit: Unpatched: IP1 1-flow TCP up: 11.3 IP2 8-flow TCP up: 90.1 IP1 8-flow TCP down: 89.8 IP2 1-flow TCP down: 11.3 Jain=E2=80=99s fairness index, directional: 0.623 up, 0.631 down Jain=E2=80=99s fairness index, aggregate: 0.997 Patched: IP1 1-flow TCP up: 51.0 IP2 8-flow TCP up: 51.0 IP1 8-flow TCP down: 50.7 IP2 1-flow TCP down: 50.6 Jain=E2=80=99s fairness index, directional: 1.0 up, 0.999 down Jain=E2=80=99s fairness index, aggregate: 0.999 So this confirms George=E2=80=99s result. :) Obviously if we look at _aggregate_ fairness it=E2=80=99s essentially = the same in both cases. I think directional fairness is what users would = expect though. Can anyone think of any potentially pathological cases from considering = only bulk flows for fairness, that I can test? Otherwise, I=E2=80=99d = like to see this idea taken in... > On Jan 16, 2019, at 4:47 AM, gamanakis@gmail.com wrote: >=20 > Of course I pasted the results for IP1 and IP2 the wrong way. Sorry! > These are the correct results, along with the *.flent.gz files. >=20 > IP1:=20 > flent -H 192.168.1.2 tcp_8down & > Data file written to ./tcp_8down-2019-01-15T223703.709305.flent.gz. > Summary of tcp_8down test run at 2019-01-16 03:37:03.709305: >=20 > avg median # data pts > Ping (ms) ICMP : 0.78 0.72 ms 342 > TCP download avg : 6.03 5.83 Mbits/s 301 > TCP download sum : 48.24 46.65 Mbits/s 301 > TCP download::1 : 6.03 5.83 Mbits/s 298 > TCP download::2 : 6.03 5.83 Mbits/s 297 > TCP download::3 : 6.03 5.83 Mbits/s 297 > TCP download::4 : 6.03 5.83 Mbits/s 298 > TCP download::5 : 6.03 5.83 Mbits/s 298 > TCP download::6 : 6.03 5.83 Mbits/s 298 > TCP download::7 : 6.03 5.83 Mbits/s 297 > TCP download::8 : 6.03 5.83 Mbits/s 298 >=20 >=20 > flent -H 192.168.1.2 tcp_1up & > Data file written to ./tcp_1up-2019-01-15T223704.711193.flent.gz. > Summary of tcp_1up test run at 2019-01-16 03:37:04.711193: >=20 > avg median # data pts > Ping (ms) ICMP : 0.79 0.73 ms 342 > TCP upload : 48.12 46.69 Mbits/s 294 >=20 >=20 >=20 > IP2: > flent -H 192.168.1.2 tcp_1down & > Data file written to ./tcp_1down-2019-01-15T223705.693550.flent.gz. > Summary of tcp_1down test run at 2019-01-16 03:37:05.693550: >=20 > avg median # data pts > Ping (ms) ICMP : 0.77 0.69 ms 341 > TCP download : 48.10 46.65 Mbits/s 300 >=20 >=20 > flent -H 192.168.1.2 tcp_8up & > Data file written to ./tcp_8up-2019-01-15T223706.706614.flent.gz. > Summary of tcp_8up test run at 2019-01-16 03:37:06.706614: >=20 > avg median # data pts > Ping (ms) ICMP : 0.74 0.70 ms 341 > TCP upload avg : 6.03 5.83 Mbits/s 301 > TCP upload sum : 48.25 46.63 Mbits/s 301 > TCP upload::1 : 6.04 5.86 Mbits/s 226 > TCP upload::2 : 6.03 5.86 Mbits/s 226 > TCP upload::3 : 6.03 5.86 Mbits/s 226 > TCP upload::4 : 6.03 5.86 Mbits/s 225 > TCP upload::5 : 6.03 5.86 Mbits/s 226 > TCP upload::6 : 6.03 5.86 Mbits/s 226 > TCP upload::7 : 6.03 5.78 Mbits/s 220 > TCP upload::8 : 6.03 5.88 Mbits/s 277 >=20 >=20 > =