Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Jonathan Morton <chromatix99@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH] Keep an internal counter for total queue length
Date: Fri, 6 Jul 2018 15:45:34 +0300	[thread overview]
Message-ID: <D0961B2E-DC81-449E-81A3-5269A7DF08F0@gmail.com> (raw)
In-Reply-To: <87a7r4bmlk.fsf@toke.dk>

> On 6 Jul, 2018, at 3:00 pm, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> 
> Toke Høiland-Jørgensen <toke@toke.dk> writes:
> 
>> Since sch->q.qlen can be changed from outside cake, we can't rely on it for
>> break loops etc. So keep an internal counter that mirrors it and use that
>> for all checks.
> 
> Sent this as a patch to avoid stepping on your toes if you are working
> on the code now :)

I'm handling it without using any extra permanent state, just making use of what's already there.  Take a look at latest commit.

 - Jonathan Morton



  reply	other threads:[~2018-07-06 12:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 11:57 Toke Høiland-Jørgensen
2018-07-06 12:00 ` Toke Høiland-Jørgensen
2018-07-06 12:45   ` Jonathan Morton [this message]
2018-07-06 13:21     ` Toke Høiland-Jørgensen
2018-07-06 13:23       ` Jonathan Morton
2018-07-06 13:27         ` Toke Høiland-Jørgensen
2018-07-07  7:07           ` Dave Taht
2018-07-07 11:57             ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0961B2E-DC81-449E-81A3-5269A7DF08F0@gmail.com \
    --to=chromatix99@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox