From: Jonathan Morton <chromatix99@gmail.com>
To: cake@lists.bufferbloat.net
Subject: [Cake] Heaps of cake
Date: Sat, 21 May 2016 01:07:28 +0300 [thread overview]
Message-ID: <D3D26D03-39C9-4B0D-A61A-886FC9E626CB@gmail.com> (raw)
I’ve just pushed my latest set of updates, the main feature of which is the replacement of the linear search in cake_drop() with a heap structure. For efficiency, the heap is constructed the first time a packet drop is required (on overflow) and maintained incrementally thereafter until 64K packets have been delivered without an overflow occurring.
Please do hammer on these codepaths for all you’re worth. It compiles and survives a smoke-test, that’s all I know so far.
I also took the opportunity to remove a variable which was widely read but never written, except for initialisation. The number of queues per tin is thus now a compile-time constant. This should be an efficiency improvement, as well as removing magic numbers from a few places.
- Jonathan Morton
next reply other threads:[~2016-05-20 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 22:07 Jonathan Morton [this message]
2016-05-29 2:32 ` Jonathan Morton
2016-05-29 15:51 ` Kevin Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D3D26D03-39C9-4B0D-A61A-886FC9E626CB@gmail.com \
--to=chromatix99@gmail.com \
--cc=cake@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox