From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 07F603B260 for ; Fri, 20 May 2016 18:07:35 -0400 (EDT) Received: by mail-lf0-x243.google.com with SMTP id m64so2033305lfd.1 for ; Fri, 20 May 2016 15:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-transfer-encoding:subject:message-id:date:to :mime-version; bh=RK+k5KshFkIZJbzXNCaQtjUXwP6JpfsDb1KxR10ZXhA=; b=GAVPOFAmDiAqNYdgTrq8MMrHSimeVokJYlXqC7MNRq2QQhLlg7Lqs8yUrHV991OG5W z8xdMfPYLTKCtQ4ENiO6JQ6EUHUQXIUW/9azBYfCakK0rgIKY+cPg1I8vvqTfESAiBvk 1pegvB0ff8I0VVJLms3IkTfL1DgYxlZSQSaYeBa+/kqaYX1K3GT3Sj5bVjZLIrF343w2 F49PF8e0YtO98zQWmOxRYqDrvfjKrfOGgtQ7g1tpAXfx9TYwU2GIYgbl0PN98swQzi7z rCjequ7q1tBfmXLbyE2RHeSwr9RQZCRNcx0kwScIbLeFKOda0vhUIQCwpV9TNYkYSUoG 1gzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-transfer-encoding:subject :message-id:date:to:mime-version; bh=RK+k5KshFkIZJbzXNCaQtjUXwP6JpfsDb1KxR10ZXhA=; b=YTRBxS6aMCu6YTm7G21Mc3aInuffRQzUGvkvg425L45f+0Gruqq7Dwap6Sj6g4vzTH uj0Bqeluiziw+KcIWHThTlwFuWLzyWqo5pLId7k8brH16/fILroMND/Rw+WliECFRIPY CWpKonoTbE52afI2iZUrrc/NU6aTuYCsfAsf4NgehAUmSFOsJPTAQXiSofCb0ZfdXH+7 Y4MoV3TPT51ZPiNwtDzzSyWSRQTyLdae7XnQWPBo7O9a4RIBQSSLuYwCCsSN343shONj rUqprk2TdWCGJntQW8ZrFIXdySqxgse8XBUXgh67DJ6njpC96LR0wt6T4lWfcgTdCklP nIUg== X-Gm-Message-State: AOPr4FV1nTZA6lcGfFHDtD/7jP9ES0K9/aahfbccBosux4oNCgac5flPlxi2Zf2WFANtMA== X-Received: by 10.25.91.207 with SMTP id p198mr1948972lfb.142.1463782054417; Fri, 20 May 2016 15:07:34 -0700 (PDT) Received: from bass.home.chromatix.fi (188-67-138-144.bb.dnainternet.fi. [188.67.138.144]) by smtp.gmail.com with ESMTPSA id c64sm3783494lfc.44.2016.05.20.15.07.33 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 May 2016 15:07:33 -0700 (PDT) From: Jonathan Morton Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-Id: Date: Sat, 21 May 2016 01:07:28 +0300 To: cake@lists.bufferbloat.net Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) Subject: [Cake] Heaps of cake X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2016 22:07:36 -0000 I=E2=80=99ve just pushed my latest set of updates, the main feature of = which is the replacement of the linear search in cake_drop() with a heap = structure. For efficiency, the heap is constructed the first time a = packet drop is required (on overflow) and maintained incrementally = thereafter until 64K packets have been delivered without an overflow = occurring. Please do hammer on these codepaths for all you=E2=80=99re worth. It = compiles and survives a smoke-test, that=E2=80=99s all I know so far. I also took the opportunity to remove a variable which was widely read = but never written, except for initialisation. The number of queues per = tin is thus now a compile-time constant. This should be an efficiency = improvement, as well as removing magic numbers from a few places. - Jonathan Morton