From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 321033BA8E for ; Mon, 2 Jul 2018 10:51:37 -0400 (EDT) Received: by mail-wm0-x241.google.com with SMTP id n17-v6so9059887wmh.2 for ; Mon, 02 Jul 2018 07:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4cZk9YHe0SYHVyJvE4VPgh0vVgqZ203DR04x4FMOCBE=; b=gV4R5/3AEfo5PzjX3PfUQmTYquvfUQ3lsVx49tRdb71L2PFZKfJ+GIEmhotQEO5eLm Ce4QRVMjL3A/GVHekEpaUVOMSO2vitaaVwvwgy12yG3REO9W98ulm3yAHpXZaR3q1o6k X7QSZ/ySDSBgwhKxl9eZaQge/+a5yNXWi9XpMjy4CiOpynRN9xPXGyn5jy0um0S9rWYk p7khA6Hzzv6rJi6HlhO4FnA40Woq5hnCgn/TKkXIr3NEjfMP/gRW4q8k+dhd94csABeq DdJ6Eq0CHKgDaPKqMcCGKyeum3szbwn+FF8xN5OaSuQ2CXP/1udWtVCnsfZADgWjhMqB ZSFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4cZk9YHe0SYHVyJvE4VPgh0vVgqZ203DR04x4FMOCBE=; b=Iv2NhArnhzEz1rZ7Zhobw14xOTDU9tQz8z1bvkBvhgUSpvlSsOry+iLB0fU/BARp7U E7hMzH9f/FKrWua+y+UFOND40JjtqFl1cDjXr1TI1RD4pFQsCAxPR5+oZgCnTj+bil7E zMBst9C55FYjrMvn3G1XmplyVDnzZKueIWHJCi6yINDrC1kGeCCGjwoSQAMhWIO8tb6z 9Nl5WjeL/t4Ii8XB1Gj3oxX9qwyYsUzVIxASQ0v5ylaW5FhdvNqQJbJInnXRizTtry11 3iRFYAUSeafKXK7Pb7Em2diVMIw3ZzALQ+c0zj8dweSelpIC4hskFcgVwfjOvyPj25N5 JxhA== X-Gm-Message-State: APt69E3aQ2kPc1GVd2wJQvlz6a+O4tlMZ9uk6CQntzxCn+d/1wshuo5H stw2ennf3+W+P42FGsKaNSBw/A== X-Google-Smtp-Source: AAOMgpcehmkzQVIGjNEwmjtYF9ejkt4/9CokzXtZ4tXiBkDcfmv01SsLWXc2uA93e5xjCtlQlks1fQ== X-Received: by 2002:a1c:7e8c:: with SMTP id z134-v6mr8309373wmc.156.1530543096127; Mon, 02 Jul 2018 07:51:36 -0700 (PDT) Received: from tron.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id s184-v6sm8928467wmf.5.2018.07.02.07.51.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jul 2018 07:51:35 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) From: Pete Heist In-Reply-To: <87lgatj13k.fsf@toke.dk> Date: Mon, 2 Jul 2018 16:51:34 +0200 Cc: Kevin Darbyshire-Bryant , Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <6DF9A5E0-EFD5-4519-9889-BC0A7B9BD48E@darbyshire-bryant.me.uk> <1A8BA286-6B31-4581-86C9-6855AC28C245@heistp.net> <673EAD3F-AB09-4B90-88BB-5DCE0BD65534@heistp.net> <6FE8D434-01BE-41A1-BD6B-EFFD67AC8784@heistp.net> <94C9790F-E9BC-4D59-9845-17C305E4B910@darbyshire-bryant.me.uk> <17AF79A0-0213-44E3-95B9-62795A644A47@heistp.net> <87lgatj13k.fsf@toke.dk> To: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: Apple Mail (2.3445.8.2) Subject: Re: [Cake] Cake on openwrt - falling behind X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 14:51:37 -0000 > On Jul 2, 2018, at 2:03 PM, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >=20 > Pete Heist writes: >=20 >> But, um, I find it curious that tb[TCA_PAD] has valid looking values >> in it, and if I just go: >>=20 >> tb[TCA_STATS2] =3D tb[TCA_PAD] >>=20 >> right after parse_rtattr is called, I start getting tin stats printed >> that look valid. There should be zeroes or invalid values at >> tb[TCA_PAD], as that=E2=80=99s just supposed to be padding, right? >=20 > Hmm, that's interesting. Sounds like you are on the right track. What > are the numerical values of TCA_STATS2 and TCA_PAD in the kernel and > iproute2, respectively? I never would=E2=80=99ve guessed they could be different when compiled = at once :) but true, there are at least five different versions of = rtnetlink.h under build_dir based on their md5sums, and I see one = belongs to iproute2-full. In all of those, it looks in the source like = TCA_STATS2=3D7 and TCA_PAD=3D9. So I presume that the value for = tb[TCA_STATS2] is out of place by 64 bits in memory. For interest, = current output, which includes the values of TCA_STATS2 and TCA_PAD plus = all the values in the rtattr struct after parsing: root@OpenWrt:/tmp# tc -s -d qdisc show dev eth0 TCA_STATS2 val=3D00000007 TCA_PAD val=3D00000009 tb[TCA_UNSPEC]=3D00000000 tb[TCA_KIND]=3D77f013fc tb[TCA_OPTIONS]=3D77f01408 tb[TCA_STATS]=3D77f0172c tb[TCA_XSTATS]=3D00000000 tb[TCA_RATE]=3D00000000 tb[TCA_FCNT]=3D00000000 tb[TCA_STATS2]=3D00000000 tb[TCA_STAB]=3D00000000 tb[TCA_PAD]=3D77f01490 tb[TCA_DUMP_INVISIBLE]=3D00000000 tb[TCA_CHAIN]=3D00000000 tb[TCA_HW_OFFLOAD]=3D00000000 tb[TCA_INGRESS_BLOCK]=3D00000000 tb[TCA_EGRESS_BLOCK]=3D00000000 // hack happens here to get valid pointer in tb[TCA_STATS2]: = tb[TCA_STATS2] =3D tb[TCA_PAD] qdisc cake 8019: root refcnt 2 bandwidth unlimited diffserv3 = triple-isolate rtt 100.0ms raw overhead 0=20 tca_stats 2012223276 tca_stats2 2012222608 tca_xstats 0 calling print_tcstats_attr() print_tcstats_attr() got stats2 Sent 7992 bytes 28 pkt (dropped 0, overlimits 0 requeues 0)=20 xstats 2141024476 tca_stats_app 2012222616 backlog 0b 0p requeues 0 got xstats 2012222616 tca_stats 2012223276 tca_stats2 2012222608 = tca_xstats 0 calling print_xstats memory used: 2240b of 15140Kb capacity estimate: 0bit min/max network layer size: 66 / 1154 min/max overhead-adjusted size: 66 / 1154 average network hdr offset: 1 Bulk Best Effort Voice thresh 0bit 0bit 0bit target 5.0ms 5.0ms 5.0ms interval 100.0ms 100.0ms 100.0ms pk_delay 0us 18us 20us av_delay 0us 0us 1us sp_delay 0us 0us 1us backlog 0b 0b 0b pkts 0 8 20 bytes 0 3376 4616 ... > And thank you for looking into this! :) Least I can do! I=E2=80=99m afraid I=E2=80=99m still only at the point = where we know that =E2=80=9Csomething=E2=80=9D is wrong =E2=80=9Csomewhere= =E2=80=9D with either the generation or parsing of this netlink message, = so I=E2=80=99ll keep exploring=E2=80=A6