From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 63D6621F515 for ; Mon, 12 Oct 2015 04:49:18 -0700 (PDT) Received: from u-089-d068.biologie.uni-tuebingen.de ([134.2.89.68]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M8m7Q-1ZtKIM3mpg-00C6qC; Mon, 12 Oct 2015 13:49:11 +0200 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: Date: Mon, 12 Oct 2015 13:49:12 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20FAC204-CAA3-4E36-938A-E857EE81C0A3@gmx.de> To: =?windows-1252?Q?Dave_T=E4ht?= X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:tuq7CO2gY5Xvyu0V4m2D7yYtHzQOTp55YI23QMXy5fNUElyxkMo 4PHKf1gXZ3qWvevvbF5Y++Dt56815+mjGIKWDWGACEQmcYrhixvvWn8Wz24Pe/VNVX9MG5X W+dcuXmZIgufNcG+LA79LQKIStaJvHdWMprEcFwy+PlGXpE55cucMQiUl+f8Ofqwv43T67e 1DCFEdc5qt0nNs7Tr/B9g== X-UI-Out-Filterresults: notjunk:1;V01:K0:KOU87VPlgfk=:ueoMJMOXIzNWwnkv7L/eXC 5ewaGF3CM1gS3Ma4rVsiCTBQOPUVRzfZGtqZx+N/UyaPd3NKf1D/ucgjio/xSqGt3NeLYG7wD KdTlb9UbHf3a3OOz/a+3B0RaJHK9ODT5c63T4+M76+KMioHNvR4TStQknLf0lUxlzxCd4LyZu pS30qZlmvzBOHjPrt9c5+Fns6mZRS9paHGrWwbJMVTTzgmDv55pOpXsSUxsEqzQvKlqdqL1ra y6a1kbuiDU6XCtUSRFsy9gChWMqc/6yTReBqE6CX7hENBBYBf/Sv3BZUaP3SU6n6KskLDfIJq C7X+s9QjE6z/mlF0s+tNHEujN9jsYlaaS9mqb6qOGxUjrYWCEMy4WYrwrZ5yMZx9tSphxIrUD 3gUHYg2JLG461UHIv9MzIDyjfs6tcD61GanCmmbtTLi6zbme4d85gsVJweei+XEHOi2rk92Wy SId+BW9dcBLx5GubLH9O/eBPWik8BDVNlDjAt8JmCjaafgMJD9jtdgPCrge1BXY7YjyW1dxBK eu5cbUB6U+5JtZOBlh8KdrVakgbfLYmgRuAPneoWm5t5mzsoKKJ6VZMfp0JyZ6MgTWOQ7Hv6m uyq8UpSQDBryHhHPFLd6RGqR2SjVz7B8h/QJ2PCX1H099NRWCsRqgLYs4FjalkUK0MzHCARAt fD+gS9ycwBl2a0oNI9EPfdN/l9BO6dn0CaiIvi+jpowubomTobgkltDp2y42akzyVlM7slBBI Hdp2frAo5M1A9keWs1ElC1l1C61P8HcvDrgstSwuyMCdzpYe9YwLMHd8gRnk4BfLDkyCPGMmV 6kAlQ+i Cc: cake@lists.bufferbloat.net, dtaht/sch_cake , dtaht/sch_cake Subject: Re: [Cake] [sch_cake] Merge branch 'exposeinterval' (5541271) X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 11:49:42 -0000 Hi Dave, On Oct 12, 2015, at 13:16 , Dave Taht wrote: > um, no, interval needs to be kept in usec, and converted more like I = did. I have not looked at your code yet. In tc (tc_utils.h or so) = there is get_time() that knows how to deal with the default time = specifiers like sec ms us=85 I believe from the tc side this should be = used to parse the user input, just like Kevin=92s code does. Now this = needs to be passed to sch_cake.c, where I believe Kevin=92s version = expects milliseconds (MS2TIME(q->interval)), which does not do the right = thing if the user specified =93rtf 123usecs=94 on tic=92s cli=85 So just = getting rid of the MS2TIME called should do the trick, no? Best Regards Sebastian =09 >=20 > On Mon, Oct 12, 2015 at 2:36 AM, Dave Taht = wrote: >> On Mon, Oct 12, 2015 at 11:28 AM, Jonathan Morton = wrote: >>>=20 >>>> On 12 Oct, 2015, at 12:24, Dave Taht wrote: >>>>=20 >>>> This is incorrect for the DC use case. We should be able to have = the >>>> target fall below at least 250us. >>>=20 >>> Hey, I=92m trying to work on this myself, but the code keeps = changing under me. >>=20 >> Tough. Deal with it. :) Once the rtt option works right toke and I = can >> finally go test the >> count/2 idea out properly in the testbed, like, today. You otherwise >> have the pen, >> as far as I am concerned. >>=20 >>>=20 >>> - Jonathan Morton >>>=20 >>=20 >>=20 >>=20 >> -- >> Dave T=E4ht >> Do you want faster, better, wifi? https://www.patreon.com/dtaht >=20 >=20 >=20 > --=20 > Dave T=E4ht > Do you want faster, better, wifi? https://www.patreon.com/dtaht