From: Jonathan Morton <chromatix99@gmail.com>
To: cake@lists.bufferbloat.net
Subject: Re: [Cake] Heaps of cake
Date: Sun, 29 May 2016 05:32:22 +0300 [thread overview]
Message-ID: <DDED267A-3FC4-4E00-A141-950F6EFCB5DE@gmail.com> (raw)
In-Reply-To: <D3D26D03-39C9-4B0D-A61A-886FC9E626CB@gmail.com>
> On 21 May, 2016, at 01:07, Jonathan Morton <chromatix99@gmail.com> wrote:
>
> Please do hammer on these codepaths for all you’re worth. It compiles and survives a smoke-test, that’s all I know so far.
Having noted a series of kernel panics in cake_drop(), I eventually traced the fault to dequeue_head(), which AFAIK hadn’t been touched since the first version (as it was lifted from fq_codel). If it’s called on en empty subqueue, it tried to read NULL->next.
The question remains why cake_drop() would select an empty subqueue as the longest one - evidently there’s a missing heap update somewhere. But at least now it won’t crash if that happens.
- Jonathan Morton
next prev parent reply other threads:[~2016-05-29 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 22:07 Jonathan Morton
2016-05-29 2:32 ` Jonathan Morton [this message]
2016-05-29 15:51 ` Kevin Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDED267A-3FC4-4E00-A141-950F6EFCB5DE@gmail.com \
--to=chromatix99@gmail.com \
--cc=cake@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox