Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Sebastian Moeller <moeller0@gmx.de>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] openwrt build with latest cake and other qdiscs
Date: Thu, 14 May 2015 20:15:55 +0200	[thread overview]
Message-ID: <E2A0A75D-2CF4-453D-A597-F225FB2EA10F@gmx.de> (raw)
In-Reply-To: <444770E9-51C0-4935-8E00-5008CDB388E5@gmail.com>

Hi Jonathan,


On May 14, 2015, at 17:32 , Jonathan Morton <chromatix99@gmail.com> wrote:

> 
>> On 14 May, 2015, at 17:57, Sebastian Moeller <moeller0@gmx.de> wrote:
>> 
>> I am probably daft, but looking at the comment in front of skb_gso_network_seglen() (see http://lxr.free-electrons.com/ident?i=skb_gso_network_seglen ) makes me thick there is a way of getting the lengths of the individual segments of a GSO aggregate
> 
> All the segments (except possibly the last) will be MTU sized, I suspect.  The necessary headers would be duplicated, with fresh (sequential) IP IDs, adjusted TCP sequence numbers and recalculated checksums.  The size of the last segment (and maybe the number of segments) would depend on the header size, since a bigger header (due eg. to TCP timestamps) reduces the payload per packet.

	As I said, I am out of my league here ;), I would not be amazed if there was a way to get to the segment lengths without going to the data (as I believe the GSO header has all the information to pick the individual payloads out of the continuous GSO skb, but I lack the skill to find the correct reference)

> 
> I don’t immediately see how to reliably calculate the sizes of the resulting packets.  So I’d rather split them up and be certain about it, in the cases where it matters most, and take the size of the aggregate as sufficiently reliable in other cases.

	I guess your idea of peeling for ATM carrier and for >1ms wire time aggregates sounds like a decent idea…

Best Regards
	Sebastian

> 
> - Jonathan Morton
> 


  reply	other threads:[~2015-05-14 18:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-10 14:02 Alan Jenkins
2015-05-10 17:29 ` Alan Jenkins
2015-05-10 20:37   ` Dave Taht
2015-05-10 20:38     ` Dave Taht
2015-05-11  6:54       ` Sebastian Moeller
2015-05-10 21:46   ` Sebastian Moeller
2015-05-10 22:19     ` Dave Taht
2015-05-11  6:50   ` Sebastian Moeller
2015-05-11  7:01     ` Jonathan Morton
2015-05-13  6:43       ` Jonathan Morton
2015-05-14  9:19         ` Sebastian Moeller
2015-05-14 10:24           ` Jonathan Morton
2015-05-14 10:33             ` Alan Jenkins
2015-05-14 10:42               ` Jonathan Morton
2015-05-14 10:58             ` Sebastian Moeller
2015-05-14 13:12               ` Jonathan Morton
2015-05-14 14:57                 ` Sebastian Moeller
2015-05-14 15:32                   ` Jonathan Morton
2015-05-14 18:15                     ` Sebastian Moeller [this message]
2015-05-14 22:06                       ` Jonathan Morton
2015-05-15  2:27                         ` Dave Taht
2015-05-15 21:49                           ` Jonathan Morton
2015-05-14  9:50   ` Alan Jenkins
2015-05-18  0:49     ` [Cake] More overhead keywords Jonathan Morton
2015-05-18  7:27       ` Sebastian Moeller
2015-05-18  8:13         ` Jonathan Morton
2015-05-18  8:41           ` Sebastian Moeller
2015-05-18 19:41           ` David Lang
2015-05-18 19:57             ` Dave Taht
2015-05-19 10:14               ` Kevin Darbyshire-Bryant
2015-05-23  0:30       ` Dave Taht
2015-05-23  2:27         ` Jonathan Morton
  -- strict thread matches above, loose matches on Subject: below --
2015-05-05  8:50 [Cake] openwrt build with latest cake and other qdiscs Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E2A0A75D-2CF4-453D-A597-F225FB2EA10F@gmx.de \
    --to=moeller0@gmx.de \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox