From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x232.google.com (mail-wr0-x232.google.com [IPv6:2a00:1450:400c:c0c::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2D45B3B29E for ; Wed, 22 Nov 2017 13:43:57 -0500 (EST) Received: by mail-wr0-x232.google.com with SMTP id r2so8985775wra.13 for ; Wed, 22 Nov 2017 10:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Nz+NbscwGtxzk3gYqolKDmVh2zxGc7iXqxGh0FLdfwo=; b=VB7tcIXNvdWipFvFpAq4g9n8QPST9uePsEDt3hV4jKpmfpcVdujTYLQkijhskCpNbT cIBoPGs0D5F/U+DG4DEsb64iFjWw5JEUcaJ9Zdd9CTliDkq+PvnzTSfW5sj7Cb+Vcen5 Ft3wpGtIuQfAmTS1/AGCRfKireNIYC862bDXocEQ+L61948okL4n1+FJxuYHqr8n1zeF PuyLXS2C5c3qQtdQEXom+9VZBeqSUC1Hnf7jaa5Y57n05IVU/R/Szjn9dejg3YjOS+zB 32U1ErjSioHNyQrZElPvAIFj/VgZKS8oa/AYxcbFmm7Zw6+dh3rWG2uWdCmsPPcWD7vf UiSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Nz+NbscwGtxzk3gYqolKDmVh2zxGc7iXqxGh0FLdfwo=; b=e7+sLioKrHFO7NZ2d5u2YS7ziLm6+sqZFo16dX5mvVOzpTK6HV2xWaSEe1C09iOJqv QLkIACi2LM1dzO2xj5FuHkHowNUP6q1AD9wVBpI9/Qiu+VKJ8QThfWq+K/mA162Ff8XZ yBSDN5WlYCXJK3oOpJnuzqeVd1/BNg04VKgg33IsNZut56QWzC7tr7P0NXGT6LJtxR9R J52kkQCbX1OjtEjqWxSZrr2Coc5lptE8n8EKbStDFYaFKxEOG6K82olG2nkij7ZuVedm Zv2RWRCMtUHp6PihULrvzX8Hcg+epNKA54WjZzuyjMRs5uJujv8nYt0G2kLF1T6/eark geHA== X-Gm-Message-State: AJaThX7zqlEfiw13IoEs9+Hn8DfozmJvA8udhjGTDTBpZ30EuT5DO9NB aO4VbZNmH0A7Lm8nmOGPUMQ= X-Google-Smtp-Source: AGs4zMZMu54LzJ7jbtjDeZB5gOWY56HNZ47b7DHPZhIXiE3hGatoI9MSmss7F05HrlZCNsTtk6U0Lg== X-Received: by 10.223.153.247 with SMTP id y110mr19291786wrb.248.1511376235907; Wed, 22 Nov 2017 10:43:55 -0800 (PST) Received: from [10.72.0.130] (h-1169.lbcfree.net. [185.99.119.68]) by smtp.gmail.com with ESMTPSA id d63sm16764369wmh.3.2017.11.22.10.43.54 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Nov 2017 10:43:55 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Pete Heist In-Reply-To: Date: Wed, 22 Nov 2017 19:43:52 +0100 Cc: Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <107CB879-B196-40F1-A7C2-08B963B7A835@gmail.com> To: Dave Taht X-Mailer: Apple Mail (2.3124) Subject: Re: [Cake] small cake_hash optimization? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 18:43:57 -0000 > On Nov 22, 2017, at 7:33 PM, Dave Taht wrote: >=20 > On Wed, Nov 22, 2017 at 4:37 AM, Pete Heist = wrote: >>=20 >> Ok, at least a little crude testing with sar: >>=20 >> = https://docs.google.com/spreadsheets/d/1LKoq5NaswuHm9H1atXoZA1AhNDg6L4UYS3= Pn5lCsb1I/edit#gid=3D0 >>=20 >> ~10% less cake CPU at GigE in this case? >=20 > Divides do hurt, particularly if you can't do them out of order. But > that seems like a lot. Hrm, I tried a second test to make sure fairness still works (it does) = but this time got a slight _negative_ result (rrul_be fair tab). So this = calls into question whether or not my testing method is very good, and = also whether or not the change actually helps much. This time I used "cake unlimited besteffort dual-srchost overhead 64 mpu = 84=E2=80=9D (overheads from Sebastian, just rely on bql). I might try again with 950mbit limiting, and =E2=80=98perf=E2=80=99 = instead. Also I noted that the =E2=80=98lan=E2=80=99 keyword seemed to adversely = affect host fairness, so I stopped using it. I=E2=80=99ll address that = separately when there=E2=80=99s time. >> What=E2=80=99s a better tool for timing >> kernel module functions? >=20 > Use "perf" >=20 > https://en.wikipedia.org/wiki/Perf_(Linux) Ok, will see if I can give it a try.=