From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30040.outbound.protection.outlook.com [40.107.3.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 606223CB40 for ; Wed, 7 Mar 2018 13:35:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=99/yLoC1ZTCOx/NcuJ71M8yiE2H/bnxAhXMvmlOLmxM=; b=pkma3JbusmkKqFxG5rLuMHR4zkk2sdQJ1MhcRYVfirjoAORgwP7AZe/1jNKDi7nDwEuYSgsfrnnfXDeYFNvRjNwAr/ZciJJuO1JfB0dDIisWfyF/NuZkN6JGDwgkt69y2DJKVUQaVbKfzgPlfU54uPKDSfsbxJqspcINQXRfeBk= Received: from AM0PR0702MB3730.eurprd07.prod.outlook.com (52.133.51.23) by AM0PR0702MB3618.eurprd07.prod.outlook.com (52.133.50.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.7; Wed, 7 Mar 2018 18:35:51 +0000 Received: from AM0PR0702MB3730.eurprd07.prod.outlook.com ([fe80::a95a:1cfd:7299:5172]) by AM0PR0702MB3730.eurprd07.prod.outlook.com ([fe80::a95a:1cfd:7299:5172%3]) with mapi id 15.20.0588.001; Wed, 7 Mar 2018 18:35:51 +0000 From: Kevin Darbyshire-Bryant To: =?utf-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= CC: "cake@lists.bufferbloat.net" Thread-Topic: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure Thread-Index: AQHTtf92ZAagU2vDn02WdO/2XvDtbKPElDwAgAAI7YCAAAWrAIAACK4AgAAQ4oCAAFtzAIAAAmUA Date: Wed, 7 Mar 2018 18:35:51 +0000 Message-ID: References: <20180127130542.25817-1-toke@toke.dk> <20180211172618.13297-1-toke@toke.dk> <20180211172618.13297-2-toke@toke.dk> <20180306075616.380a533c@xeon-e3> <87ina9m4up.fsf@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> <87muzkyvj7.fsf@toke.dk> <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> <87h8psyraq.fsf@toke.dk> <6F0B516E-3244-4A93-8762-3EAF3BD71BF2@darbyshire-bryant.me.uk> In-Reply-To: <6F0B516E-3244-4A93-8762-3EAF3BD71BF2@darbyshire-bryant.me.uk> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; x-originating-ip: [2a02:c7f:1232:22b::dc83] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0702MB3618; 7:qXacdV8DaQI1b1iYRs4lwhWeAYZyYGx/xhkl77tG5kCtP+P55PYNnjf4BWU/bNiwyjpFDltAPSSoH8hDi5PC/ryQo6WpepocEKMkl90NvFRrj/WXeUqH7dDGJldmax0KhFYWiq5KD22hcu0Giu3PY86fEoXlTZkEH7m57ja8QgGg5wmSZt3jiKLHxyvlB4nG9RZjJOs6RRSwOs3w0ry3DjgwqPMjJYBdNuZfXfe3ysWuCkMIpe9qNooaxANbQV4/ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2282cdb2-83c9-4fea-2aaa-08d5845a40f8 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(5600026)(4604075)(3008032)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(49563074)(7193020); SRVR:AM0PR0702MB3618; x-ms-traffictypediagnostic: AM0PR0702MB3618: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415395)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231220)(944501244)(52105095)(3002001)(6041288)(2016111802025)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6043046)(6072148)(201708071742011); SRVR:AM0PR0702MB3618; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0702MB3618; x-forefront-prvs: 0604AFA86B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(366004)(39830400003)(39380400002)(199004)(189003)(14454004)(316002)(93886005)(102836004)(6506007)(53546011)(106356001)(5250100002)(53936002)(97736004)(99936001)(186003)(2900100001)(3660700001)(33656002)(68736007)(6512007)(6436002)(6486002)(114624004)(229853002)(46003)(6246003)(2950100002)(7736002)(6916009)(305945005)(6116002)(8676002)(81166006)(81156014)(3280700002)(2906002)(5660300001)(8936002)(105586002)(74482002)(25786009)(82746002)(99286004)(478600001)(86362001)(76176011)(83716003)(36756003)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0702MB3618; H:AM0PR0702MB3730.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4I5oovkwSnTdsJFprqiuZ3vFhLtU5sX4j8PeULDMzn7koL6zlKk1XGhpwWw4t1iwXCux6qh/iRprrjA4DQ2XOZmbvyNoZ9GD9ObPoaa2jsq7c+A3I/eTrbSHTOoWdhdRiJzOSus0p+mV97V2GmDWnzD8BhuzBNMcF0F+3aO42noG3wSCgGBd2hr4q+P9eTfgawufhX1jPQVAtEHnyhk79JJJrSqAA8FHQz/Zuu1gbWV44Y2MEUuwiy1yHBPSBjAK0b+mQ/6t1BkMrQz4OUX97bHtU2Mx8yJ0OIe34cWXcL1aMnYObtGv0eUflRqXeH2lWdS8TDfDaO3zSAHD8fxGeg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/signed; boundary="Apple-Mail=_138BC2B1-E8D1-4EBE-87BD-FE0274D49B07"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 2282cdb2-83c9-4fea-2aaa-08d5845a40f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2018 18:35:51.4409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9151708b-c553-406f-8e56-694f435154a4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0702MB3618 Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 18:35:53 -0000 --Apple-Mail=_138BC2B1-E8D1-4EBE-87BD-FE0274D49B07 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 7 Mar 2018, at 18:27, Kevin Darbyshire-Bryant = wrote: >=20 >=20 >=20 >> On 7 Mar 2018, at 12:59, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >>=20 >>=20 >>> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 = dual-srchost nat rtt 100.0ms ptm overhead 4502152 >>> Sent 42615751 bytes 4491092 pkt (dropped 4491108, overlimits 4491124 = requeues 4491152) >>> backlog 0b 4491256p requeues 4491272 >>> memory used: 78592b of 4Mb >>> capacity estimate: 19900Kbit >>> min/max transport layer size: 4537916 / 4537972 >>> min/max overhead-adjusted size: 4538000 / 4537972 >>> average transport hdr offset: 4538072 >>>=20 >>> I=E2=80=99m pondering if it=E2=80=99s an endian issue? >>=20 >> Are you using the latest kernel code? Those values were added in an >> incompatible manner, so if you don't have userspace and kernel code = in >> sync they'll be garbage, basically=E2=80=A6 >=20 > I=E2=80=99m using latest commit on kernel space sch_cake cobalt branch = and identical user space tc/q_cake.c to tc-adv repo. It=E2=80=99s not = just those new values, overhead, dropped, overlimits, requeues are all = long standing parameters. >=20 > All the values, including the new, worked just before the big json = conversion. Aha, more clue - the json output =E2=80=98tc -j=E2=80=99 looks better = (possibly correct though I=E2=80=99m dubious of the rate value) Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A --Apple-Mail=_138BC2B1-E8D1-4EBE-87BD-FE0274D49B07 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEASyssijGxT6XdZEjs6I4m53iM0oFAlqgMQYACgkQs6I4m53i M0pgVQ//ZB2Llaok6sfaJeEhuoS2XqGN85olK8bnkotlrMMIUrVyL/UHe5uYAp5V GmByuJwjyOxCr0s0sOCnPrbH6yJH5FmW+fbZgJoPufmG/5ATL/OY8z1nlOg0b9wn BlJbV9Kaw7oD/bq0B9Y5Op7ijLQk16erxbjsH52ttiXOtL0h2AqjxFjEeQpu59PE SHKHakVZi0z8bIHlzO6IAKnUPm5JcyDmrPsn49jWveVN/fMFQbnjMpK06OtMK913 LQXvi817y0s8ZKqq63fVXVlLx7ITNzDyn8kZNTfScaQzTux0t6GMPxBSZh0/F+g4 HgmKQSN4pewANGUpCJhxDkEZF93eqekms3VvvyQrsypjoKd31LqzzplnDBZihIc3 8+7vi0v1cXPsqEOXLTn8j5j3s2QGRC947Efw0T4+xjMQPN2Eg/zzbNP88vvF4bkK vkkgTkmMWC/FMbNiti8WaID56XAtpdOkqAYuQ4OnOFCWbVVPKRG2wv3MG6NVL3+R 7iJV5Icj5x1Gtb/qet9FuZgkAb1SHNOpVbAWb2a6ibGYjYEn4VFyfeK1hLD17cr+ jq4Cy+c3s8qudCS1q1Nu3594t29jLo8HIGjLurGwxl6gY8eWzzFerMmUV7tCoJ6P 4AAUxdKZyM1Hs96pZVh/uFukHtogzJ3CO9LWD/j/Uh98A2KAFQQ= =PaDm -----END PGP SIGNATURE----- --Apple-Mail=_138BC2B1-E8D1-4EBE-87BD-FE0274D49B07--