Re: [Cake] Long-RTT broken again

[Sebastian Moeller <moeller0@gmx.de>]

Hi Toke,

On Nov 7, 2015, at 17:24 , Toke Høiland-Jørgensen <toke@toke.dk> wrote:

> Sebastian Moeller <moeller0@gmx.de> writes:
> 
>> 	Oh, shiny ;) I take it the parameter is limiting the queue
>> 	memory as measured by skb->truesize ; just checked, it wants the
>> 	size in KB. I just committed a change to report that in the
>> 	usage help tc will display…
> 
> Changed this to use the existing functionality in tc to parse different
> units of size (kbit, kbyte, etc), and default to bytes if no units
> specified.

	Most excellent, I had only known about get_rate() and thought something like it for sizes would be swell ;) but I did not know it existed already ;) I guess, the best patch is the one, one does not need to write ;)

> Also added the parameter to the man page.

	Oops, I had completely overlooked/ignored that cake has a manage, I guess maybe I can contribute a bit to that.

> 
> And for good measure I did a little bit of bikeshedding renamed the
> parameter to 'memlimit' as well :)

	Not my bike shed, I am fine with both (and given my nagging for exposing the maximal buffer sizing, I would have been happy with “charles” as the name for that option ;) )

Best Regards
	Sebastian

> 
> -Toke