Re: [Cake] Long-RTT broken again

[Sebastian Moeller <moeller0@gmx.de>]

Hi Jonathan,

On Nov 3, 2015, at 09:25 , Jonathan Morton <chromatix99@gmail.com> wrote:

> 
>> On 3 Nov, 2015, at 10:20, Sebastian Moeller <moeller0@gmx.de> wrote:
>> 
>> Also what about the BUG_ON I managed to trigger during my testing?
> 
> That turned out to be a flawed condition, which I’ve already fixed.

	Excellent, thanks a lot. I would not have repeatedly brought this up, if I had known it fixed, Call me weird, but I am not too keen to look at the source to see whether “reported” issues are fixed. I also note it still is a BUG_ON ()actually there are two in sch_cake) and that still has the issue whether cake is important enough to hose a computer on failure… My understanding from luring on LKML is that under-justified BUG_ONs are frowned upon… Why is that an issue? In my case I needed physical access to reboot the machine, which for remote servers gets difficult...

>  It’s necessary for something like that to be there, because there is a fixed, static allocation of tins; exceeding that number would result in a buffer overflow.  The only way to do so is to add a new Diffserv scheme with more than eight tins, which isn’t outside the bounds of possibility in the future, though unlikely in the short term.

	Sure, but BUG_ON is the big gun that will most likely make the machine unusable (at least it wedged my opensuse 13.2 machine hard enough that a reboot was required); which I believe is too drastic for a failed qdisc, but I could be wrong…

Best Regards
	Sebastian

> 
> - Jonathan Morton
>