Re: [Cake] Fixing iproute2 compile

[Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

Hold the phone...

My guess is a difference in definition of offsetof as potentially defined in tc/include/Utils.h

But very hard to tell on my phone!

--
Cheers,

Kevin@Darbyshire-Bryant.me.uk
Sent from my phone, apologies for brevity, spelling & top posting

> On 19 Oct 2015, at 17:01, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> 
> So finally got iproute2 to compile out of the kau.toke.dk repo. The
> patch below was needed to cake. Posting it here rather than just
> committing in the hope of getting someone (Jonathan?) to take a look at
> it and fix it everywhere it's needed :)
> 
> -Toke
> 
> diff --git a/tc/q_cake.c b/tc/q_cake.c
> index 4d64405..1384a46 100644
> --- a/tc/q_cake.c
> +++ b/tc/q_cake.c
> @@ -495,7 +496,7 @@ static int cake_print_xstats(struct qdisc_util *qu, FILE *f,
> 
>    } else if (stnc->version >= 1 && stnc->version < 0xFF
>                && stnc->max_tins == TC_CAKE_MAX_TINS
> -                && RTA_PAYLOAD(xstats) >= offsetof(*stnc, capacity_estimate))
> +                && RTA_PAYLOAD(xstats) >= offsetof(typeof(*stnc), capacity_estimate))
>    {
>        int i;
> 
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3062 bytes --]