From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22e.google.com (mail-lf0-x22e.google.com [IPv6:2a00:1450:4010:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A45DC3B29E for ; Fri, 22 Dec 2017 01:39:04 -0500 (EST) Received: by mail-lf0-x22e.google.com with SMTP id c19so10524765lfg.3 for ; Thu, 21 Dec 2017 22:39:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uDPhsI+zVc0s2AEzJMByfRTE3xKQmoempTiK56VLqIc=; b=sXkxY11rI5bHJSY05B3XqCRhndUKmgE+6TFKoF5NKvDu8OBRwww7tl2dPhBX4kCobz 9tHAl1F3Y/Huv3R5dgFiEpfsBBRvYDB9G9rJ7m3RTb5DTCAgSwROKAsLQ9T7IHsgvvwQ XTFU6EJZcH1w1g8x5Cu6WCOPipPzqkDZ9XEksxJtTfDkrW5/O0KStdCgIVzNAevQNAEX 9wbZ+7Y0gPmIaNmL+FMIo8n/jOMOSHZ6yIfuIi4tHDMWKNqgvWn0umgKFR9FO0Lgv4mq iKc5h6Vg3NwtJnN/dwAXXD1I5OqGcdYwkozxsmjt+m4NTzACxHVhxINjosOuK5CCOzgi FkmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uDPhsI+zVc0s2AEzJMByfRTE3xKQmoempTiK56VLqIc=; b=WokuB5ja8fGjpaVJS7Rn0XHEkBYiPB5IkLgoAzeysxQfu+nZwS+Z8xNRGI7Tfkht5/ 9OfQ0JVzxnAPV9y2KKmRp4LvX+Frh9Qs6Zu/3xnDG4fFmDFiH0+OEWomXsf47UhKWD4n 7kMyTPnShasevm8pu1ise1PSgTXju9UQFjXYOIrkdXWqARgL0A2nQmNpQv5dJXDkktm+ 4NGcAImHVAZRlaNTWTmEDHvc5doMJVliXEHIHK+kXKhPHq7GSGFl98VkK915enTxICV4 8F/yczuKm9KC6R8UV7OwqK1ht2D3/O2D3u7z6DDwlTU2KaNTe2xmsyakc+GH7wW/WyBT yKgQ== X-Gm-Message-State: AKGB3mIKkf/vcXdOL38MIluBmH3tggVw+aJ7dW7O55YN/PbIfV7HHc3R M9NyNu7xHcG7/P30iPumoTU= X-Google-Smtp-Source: ACJfBotBeMHg9BiIkEklLxGHIQYdPomOMy/ZB/ZoQdrZqgAYPe0rhK2+C9hUYX7bAbZuGCiX69uScg== X-Received: by 10.46.88.1 with SMTP id m1mr7733946ljb.72.1513924743558; Thu, 21 Dec 2017 22:39:03 -0800 (PST) Received: from [192.168.239.216] (mobile-access-bceee7-52.dhcp.inet.fi. [188.238.231.52]) by smtp.gmail.com with ESMTPSA id i130sm2147636lfg.44.2017.12.21.22.39.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Dec 2017 22:39:02 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) From: Jonathan Morton In-Reply-To: Date: Fri, 22 Dec 2017 08:38:55 +0200 Cc: Cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: References: <31d49a5d-02a2-3dc8-a455-52d453b83bdf@gmail.com> To: Andy Furniss X-Mailer: Apple Mail (2.3445.5.20) Subject: Re: [Cake] overheads or rate calculation changed? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 06:39:04 -0000 > On 21 Dec, 2017, at 2:54 am, Andy Furniss wrote: >=20 > refactor cake_advance_shaper and ack_filter >=20 > cake_advance_shaper now returns a modified len argument to > reflect cake_overhead. > skb_ack_filter variable replaced with ack Fixed. At one point cake_advance_shaper() was still getting a packet = length with overhead correction already applied, and was then applying = it a second time. - Jonathan Morton