From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: Cake List <cake@lists.bufferbloat.net>
Subject: [Cake] act_connmark-dscp
Date: Mon, 11 Mar 2019 17:46:13 +0000 [thread overview]
Message-ID: <FAC83CDA-BE1C-44F1-9B02-EE07E0B46A32@darbyshire-bryant.me.uk> (raw)
Hi All,
You find me in an incredibly frustrated, upset & depressed state of mind.
Those of you following the recent threads on using firewall conntrack marks may have realised I’ve come to an acceptance that CAKE is not really the ideal/upstream compatible place to do interesting things like copy DSCPs into fwmarks. Instead it makes more sense to do it in a tc action, who knows it may even be acceptable to upstream.
I think it makes sense to do it as a new sub-function of act_connmark, since that is already restoring conntrack fw marks into skbs.
The logic of storing/restoring DSCPs to/from conntrack firewall marks is easy. Where I’m absolutely stuck to the point of tears and depression is the whole ’netlink’ thing and also if I’m brutally honest with myself, my understanding of C.
I have the ‘functional’ logic & code, but the passing of switches to turn it on eludes me. If I understand the existing code, it passes over a parameter structure containing the relevant parameters for connmark. I don’t think I can extend that structure for backwards compatible reasons, so I thought I could pass another parameter structure say ‘DSCP’ and that would then fill a locally stored version of a similar structure….but, well I’m stuck/confused/at wits end/fed up/frustrated/angry with myself.
If anyone feels like helping out https://github.com/ldir-EDB0/linux-stable/tree/connmarkhack - it will also show the true horror of my lack of skill/direction etc, and I don’t want the idea to die just because I can’t code it.
Kevin
reply other threads:[~2019-03-11 17:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FAC83CDA-BE1C-44F1-9B02-EE07E0B46A32@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=cake@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox