From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id A7FC621F93F for ; Tue, 29 Sep 2015 08:10:21 -0700 (PDT) Received: from [134.2.89.70] ([134.2.89.70]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LhjeH-1aTSW32mrh-00mrkU; Tue, 29 Sep 2015 17:10:18 +0200 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: Date: Tue, 29 Sep 2015 17:10:14 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <56092A0F.3060108@darbyshire-bryant.me.uk> <560969FC.3040107@darbyshire-bryant.me.uk> <560A5D19.3000405@darbyshire-bryant.me.uk> To: =?windows-1252?Q?Dave_T=E4ht?= X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:f/Hv4Fcs+vJOm+YXG8faABER9uuGNX0E8C71z7EQgylDspETCUO v/Ftf1a1oQJWXo9ExiiPEqjyQl9xIg2LkoqQa/GryINlST3POOT6yz1UHySbtLRb6zX4C0d wxZJ/S9Dh49I2SF9tMMmTBboW0PGNla9IUcPyOfiohoZs6t+9i2BxXymmJCkHUri+zDsGVE YdQaYQ72a42/7YGhV5QXw== X-UI-Out-Filterresults: notjunk:1;V01:K0:6EctYc2GCh8=:pWaOEzC296pBeINQJYFw5Q 1yqQ0ya9jkVTjkG5QoYe9KxQZvQPm5sGAK7rgRNz7EOe+/yzAr2+z4cP94w2eLsi+i+BYVYkO bTS/0w8LpgGcamhgTjskDga9Cfxn/X2C23aLin+cG8SDNb6XY7pJgTiCfrUXtdWD3bsog63yC hrJjMhWJRGAo/KngAEVM6Le0ZHaD91kyRIXM8YcNXrpVk+axyKujFXIA29kWTKL4RHNisV+RA wwKb5rLZrTX0SYytuubf5hdz8nsyDXbEMkHh8jNYPD9m3DpINzxeuDb8nOW3+wfA2XXiaqUpG y2841NH6NADqL6Q8LHeVkFLCk+Lxte4reSYBKoz3GtqHH6CjvmGVQ4r2w672R531VwRxENZ9G 37m9gsL0naX0ulj9D+ezaq7zF+4iSxsFprknArj/kLEepgHZ30OdsG2XhnEC7//ynAqEenKOI W45kXGz9ZffGy9doLRosJb7fCGjYerb2SI7vcIAmM4Sjv+Rz4IDENt8pWNjbV0+LSUk6px09S pv+nGWcz14uCHNRkuI0RHJnZirIRuCi0ytzN17roWvx4siJ7+EXZkaKaOTpljMDRRL6SjamsB qiV1qIm9N/O4P5fe//rE3LVvDoz5JOJkViM3zaFPhqUcuhfGu2FNhZa5lc1UDxIFc+rol4oT+ WSL7K6zzvD9XbUMqhc9TjpYzIlMCkNOCgaYyZ+n2mVMm/gi76RM9T2Z7E9skxcHfnaRWtFaQf 7nodMb2rpoV+gvkPmEmbI/T2vt6amMvDaIOYSg== Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Update kernel version check in cake X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 15:10:44 -0000 Hi Dave, On Sep 29, 2015, at 13:10 , Dave Taht wrote: > I added support for squashing to both sch_cake and tc-adv repos. Sort > of compile tested > only. (my laptop's kernel is 3.16 and doesn't build, my virtuals in > linode do not come with > kernel sources, snapon crashed two weeks ago, and so on) >=20 Just played a bit with the shiny new squash option. For my = limited testing it seems to work. I do wonder whether the automatic = default to besteffort is the ideal behavior though. For example on = egress it would be nice to be able to use the internal set DSCP markings = but clean them from the outgoing packets as not to leak =93information=94 = to the ISP, similarly but more contrived the same could be agued for = ingress ;)=20 Best Regards > but it was nice to write a few lines of code, knowing that someone > here will fix 'em if > I broke something. >=20 >=20 > On Tue, Sep 29, 2015 at 2:55 AM, Dave Taht = wrote: >> On Tue, Sep 29, 2015 at 2:42 AM, Kevin Darbyshire-Bryant >> wrote: >>>=20 >>>=20 >>> On 29/09/15 00:01, Jonathan Morton wrote: >>>>=20 >>>> I actually had the version check fix locally, but for some reason = it >>>> hadn't been picked up by a push yet. >>>>=20 >>> Yep, I have those moments. Just when I think I've got git sussed it >>> goes and does something completely logical but totally unexpected = :-) >>>>=20 >>>> Squashing would involve writing to the TOS byte, which is already = done >>>> by ECN marking, via a helper function. >>>>=20 >>> Ah, so if I can work out how that's done I'm 50% of the way there. >>> Should keep me amused for a few days. >>>>=20 >>>> I tried removing the cow stuff once before. Everything promptly >>>> stopped working until I put it back. I have no idea why. >>>>=20 >>> Well here's interesting. I got brave and put my suggested change = into >>> action. So far: 1) router not blown up 2) tc -s still shows = traffic in >>> different Classes (Dave, I prefer your term 'Bin' here too - I >>> considered 'Bucket' for a laugh) which suggests the reading of = ip_hdr is >>> still working. 3) This hasn't been thoroughly tested in any way >>> whatsoever but i've tried diffserv4 & besteffort and both don't = appear >>> broken. >>=20 >> I agree with bin. Wouldn't mind it if that made it into the variable >> name instead of class. >>=20 >>> Pull request: https://github.com/dtaht/sch_cake/pull/6 >>=20 >> It would be my hope also that killing the cow would speed it up. >>=20 >> Untested by me, but pulled. >>=20 >>=20 >>> Kevin >>>>=20 >>>> - Jonathan Morton >>>>=20 >>>=20 >>>=20 >>=20 >>=20 >>=20 >> -- >> Dave T=E4ht >> Do you want faster, better, wifi? https://www.patreon.com/dtaht >=20 >=20 >=20 > --=20 > Dave T=E4ht > Do you want faster, better, wifi? https://www.patreon.com/dtaht > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake