From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 874FC3B29E for ; Sun, 1 Jul 2018 09:49:02 -0400 (EDT) Received: by mail-wr0-x244.google.com with SMTP id u7-v6so12969202wrn.12 for ; Sun, 01 Jul 2018 06:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=d4mp42gSS2fVmUkf3n65O+hGJUysoRTrwNJA0s+I2EM=; b=Ol1yNjfW+YqoVfHGrp05oJAAskCU8MU5L1g4ygREvLYL86hesCkaJJndW8TDR/LRCd aqNbo8R7c8DWze83jGW2STZt9SkgIcECM2534bmf329vE/u/nVwnXRHGH7aOu+t9QjdX p9VnYGSyHFDN56YLGmg5upw8DF1ZmLKnkOu9Xzixvdw8EdbyFyuBvgvqgbACoFMV+NIN TQr7+2SY7WMSTR7AiSnp6qTaJ4SGSthAam7bnMgsjKb2hSA1GCEbWZ/Y8sVp26+qM711 reD2hGMQ1i72Wag9qeYMRSiL474XXHnDnzyyK9D71ju3OhkScc2EM7+Y5ceimM+XCXIm LUZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=d4mp42gSS2fVmUkf3n65O+hGJUysoRTrwNJA0s+I2EM=; b=NvmTcjfqw/sIDI7dcEVQWY1AbRLGxkBCMiB/Gnj34zMnruwozirt5B43fF20MjP1xi QT0RxjeGXR+u39Gq2Odc4abWCOBx7aVUYluf28Y5sHsBHggLK6CtTw8slBbtJ7nnZ8re fn8ufVmFvj0d30RVVOcpdLB/jj4y+DIWO6yGizyecNIraJb0hYxrnYxr6V8DnVdo7S7B GJnKDwvYJIqoVIy9wIEcl5tMQX91bThvekaV9Btkpw6CegVU/Dt7x1ALFiB0j4F2V/QP WwvUwDZFLtOidPNRxpbwyW/As+E+v10JVdKHlPf+bREn0bpkJbetmtoDrqgnGe/iZ25o IumQ== X-Gm-Message-State: APt69E3lLeTS9Dy50n9NhC6EBKFx6n4IMFeaZBzb5IeG3JF9NSKDPRLb GhO9AYOyxZ1LyP+dIp1l4yZUFw== X-Google-Smtp-Source: AAOMgpfr5jeH5M7mQbLWrk0CB9TZAA5iV5FXJcrVzGesJlciLYgQ4vpCi5BqU143S/2jUg2kk4Pa0w== X-Received: by 2002:adf:9d1c:: with SMTP id k28-v6mr6495579wre.29.1530452941525; Sun, 01 Jul 2018 06:49:01 -0700 (PDT) Received: from [10.72.0.64] (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id c7-v6sm12353404wre.73.2018.07.01.06.49.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jul 2018 06:49:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) From: Pete Heist In-Reply-To: <6FE8D434-01BE-41A1-BD6B-EFFD67AC8784@heistp.net> Date: Sun, 1 Jul 2018 15:48:59 +0200 Cc: Georgios Amanakis , mbo2@uggenabben.se, Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <6DF9A5E0-EFD5-4519-9889-BC0A7B9BD48E@darbyshire-bryant.me.uk> <1A8BA286-6B31-4581-86C9-6855AC28C245@heistp.net> <673EAD3F-AB09-4B90-88BB-5DCE0BD65534@heistp.net> <6FE8D434-01BE-41A1-BD6B-EFFD67AC8784@heistp.net> To: Kevin Darbyshire-Bryant X-Mailer: Apple Mail (2.3445.8.2) Subject: Re: [Cake] Cake on openwrt - falling behind X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 13:49:02 -0000 Ok, my reboots were because I need to compile with om-watchdog support, = otherwise the OM2P=E2=80=99s hardware watchdog reboots every few = minutes. Thus, my sysupgrades were not _actually_ working (watchdog was = interrupting them), thus the unknown symbols / dependency problems, etc, = so that=E2=80=99s behind me. :/ And yes, I get no tin stats without the patch. With the patch, I get tin = stats as expected. This is probably nothing new. I also compiled on a Raspi 2 (32-bit ARM) running Debian 9.4, and it = works as expected without the patch. This probably just confirms what = George reported, because I think his wrt1900acs also uses 32-bit ARM. So yes, MIPS 32-bit, both le and be are both fails. What next? We could = test more archs, but it might be more productive to attempt to figure it = out in the code when I can at least repro it on MIPS. You mentioned earlier netlink_parse_nested doesn=E2=80=99t seem to = handle 64-bit values but I=E2=80=99m not seeing where that is. I=E2=80=99m= getting my head around how stats work so just writing out loud=E2=80=A6lo= oks like there are qstats from struct Qdisc then the tin stats which are = probably custom for Cake and stored at some address obtained from = qdisc_priv, which is right after the regular Qdisc struct. Interesting. = I=E2=80=99m searching now for how this data ends up in tc=E2=80=99s = hands, which looks like happens in cake_print_xstats with = parse_rtattr_nested, then the printing gets underway, and at some point = if st[TCA_CAKE_STATS_TIN_STATS] is true it gets into the tin printing = business. What=E2=80=99s the condition that fails to make the tin stats = not be printed? Best I know is to add debugging statements to figure it = out, which I might give a try later today. Am I on the right track? > On Jul 1, 2018, at 9:18 AM, Pete Heist wrote: >=20 > Ok, so I=E2=80=99ve got to figure out what=E2=80=99s up with my build = in general, so I=E2=80=99m blowing away my source tree and will build = master without any patches. >=20 > I don=E2=80=99t know if the kernel panics and unknown symbols are = related somehow, but they=E2=80=99re not helping(!) so I=E2=80=99ll try = to get past that. I don=E2=80=99t actually get logs in = /sys/kernel/debug/crashlog, so I can=E2=80=99t even prove it=E2=80=99s a = panic, but it=E2=80=99s rebooting that usually happens just as I do = something net related, like start typing in ssh or do an scp, after some = period of inactivity. If it=E2=80=99s reproducible on an unpatched build = I=E2=80=99ll head over to the OpenWRT universe. >=20 > (the stats alignment is just proportional vs fixed fonts- they look = fine in vim) >=20 >> On Jul 1, 2018, at 4:37 AM, Georgios Amanakis = wrote: >>=20 >> The stats got mangled in by the email, in the terminal they are >> properly aligned. >>=20 >>=20 >> ---------- Forwarded message ---------- >> From: Georgios Amanakis >> Date: Sat, Jun 30, 2018 at 10:35 PM >> Subject: Re: [Cake] Cake on openwrt - falling behind >> To: Pete Heist >>=20 >>=20 >> I just tested this on my wrt1900acs but it is behaving as it should. = I >> used Kevin's RFC patches for iproute2 and kmod-sched-cake. >>=20 >> root@lede:/tmp# tc -s qdisc show dev eth0 >> qdisc cake 8004: root refcnt 9 bandwidth 2500Kbit diffserv3 >> triple-isolate split-gso rtt 100.0ms raw overhead 0 >> Sent 122745 bytes 691 pkt (dropped 0, overlimits 419 requeues 0) >> backlog 0b 0p requeues 0 >> memory used: 6416b of 4Mb >> capacity estimate: 2500Kbit >> min/max network layer size: 42 / 1186 >> min/max overhead-adjusted size: 42 / 1186 >> average network hdr offset: 13 >>=20 >> Bulk Best Effort Voice >> thresh 156248bit 2500Kbit 625Kbit >> target 116.3ms 7.3ms 29.1ms >> interval 232.6ms 102.3ms 124.1ms >> pk_delay 0us 196us 8.6ms >> av_delay 0us 13us 1.3ms >> sp_delay 0us 2us 38us >> backlog 0b 0b 0b >> pkts 0 414 277 >> bytes 0 38367 84378 >> way_inds 0 0 0 >> way_miss 0 20 2 >> way_cols 0 0 0 >> drops 0 0 0 >> marks 0 0 0 >> ack_drop 0 0 0 >> sp_flows 0 1 0 >> bk_flows 0 0 1 >> un_flows 0 0 0 >> max_len 0 206 1186 >> quantum 300 300 300 >>=20 >> root@lede:/tmp# opkg list-installed | grep cake >> kmod-sched-cake - 4.14.50+2018-06-26-0520a6cb-1 >>=20 >> root@lede:/tmp# uname -a >> Linux lede 4.14.50 #0 SMP Wed Jun 27 21:48:32 2018 armv7l GNU/Linux >>=20 >> George >>=20 >> On Sat, Jun 30, 2018 at 7:20 PM, Pete Heist wrote: >>> Ok, same result (unknown symbols and routine crashing) after a make = clean and re-build, but I just force installed the kmod-sched-cake = package with --force-depends and it seems to work. This reproduces it, = right? no stats and the debug output? >>>=20 >>> root@LEDE:~# tc qdisc add dev eth0 root cake >>> root@LEDE:~# tc -s -d qdisc show dev eth0 >>> qdisc cake 8001: root refcnt 2 bandwidth unlimited diffserv3 = triple-isolate rtt 100.0ms raw overhead 0 >>> tca_stats 2005579564 tca_stats2 0 tca_xstats 0 >>> calling print_tcstats_attr() >>> print_tcstats_attr() >>> got stats >>> Sent 9070 bytes 66 pkts (dropped 0, overlimits 0) >>> got xstats 0 tca_stats 2005579564 tca_stats2 0 tca_xstats 0 >>>=20 >>> root@LEDE:~# cat /proc/cpuinfo >>> system type : Atheros AR7240 rev 2 >>> machine : OpenMesh OM2P >>> processor : 0 >>> cpu model : MIPS 24Kc V7.4 >>> BogoMIPS : 265.42 >>> wait instruction : yes >>> microsecond timers : yes >>> tlb_entries : 16 >>> extra interrupt vector : yes >>> hardware watchpoint : yes, count: 4, address/irw mask: [0x0ffc, = 0x0ffc, 0x0ffb, 0x0ffb] >>> isa : mips1 mips2 mips32r1 mips32r2 >>> ASEs implemented : mips16 >>> shadow register sets : 1 >>> kscratch registers : 0 >>> package : 0 >>> core : 0 >>> VCED exceptions : not available >>> VCEI exceptions : not available >>>=20 >> _______________________________________________ >> Cake mailing list >> Cake@lists.bufferbloat.net >> https://lists.bufferbloat.net/listinfo/cake >=20