From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vps.slashdirt.org (vps.slashdirt.org [144.91.108.218]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D45903B29D for ; Sat, 14 Dec 2019 05:01:32 -0500 (EST) Received: from tama.lan (unknown [37.165.135.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by vps.slashdirt.org (Postfix) with ESMTPSA id 4C06260076; Sat, 14 Dec 2019 11:01:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 vps.slashdirt.org 4C06260076 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=slashdirt.org; s=mail; t=1576317691; bh=wBkgiFLJ0zZzkWVbU/l22ACr47bZkTx5VaTceNLejMs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=z0powPIbqwfagxrLgnZ35+gB3pGYCHwWwx25+n9KgcBDr3aTMPl334dF20HUFzQfP 5wOzE7a/xMSdOtF3GJezHSMWVOgrfWb1nv2vnAMT1F2H2wRaZa4BtEc1duCf1yCI12 ka48j2AUKSWuxzNFAKTnU4+3ltvZ3/39PFQP7DSU= Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Thibaut In-Reply-To: <1507FAF0-8A13-48E1-8A36-0D352F4FDD00@gmail.com> Date: Sat, 14 Dec 2019 11:01:30 +0100 Cc: Erik Taraldsen via Cake , ldir@darbyshire-bryant.me.uk Content-Transfer-Encoding: quoted-printable Message-Id: References: <1d359153abfc413b4f61c647437427d6@slashdirt.org> <8FC615C8-4885-4F0A-B2EE-934DC4E806E8@gmail.com> <6E9587F7-C208-4568-8429-AEBA9E694E24@slashdirt.org> <46DDBCAA-EC6C-492F-8448-DF85ABB4E1DB@slashdirt.org> <1507FAF0-8A13-48E1-8A36-0D352F4FDD00@gmail.com> To: Jonathan Morton X-Mailer: Apple Mail (2.3445.104.11) Subject: Re: [Cake] Trouble with CAKE X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Dec 2019 10:01:33 -0000 > On 14 Dec 2019, at 10:50, Jonathan Morton = wrote: >=20 >> On 14 Dec, 2019, at 1:52 am, Thibaut wrote: >>=20 >> Culprit turned out to be easy to identify: it=E2=80=99s the current = master HEAD. >>=20 >> Reverting 183b320 fixed the issue. >=20 > That's extremely odd. That commit should only affect traffic carrying = the LE DSCP, which is not the default. >=20 > Perhaps it was not actually the code change, but triggering a rebuild = of the module? No. I tried with and without multiple times: I built, installed, = manually unloaded the module, made sure it was unloaded, loaded the new = build; just to make sure as I noticed the module doesn=E2=80=99t print = anything in dmesg when it=E2=80=99s loaded (feature request: print the = current build version when loading, that would be most helpful in these = circumstances). There is absolutely no doubt that on my router, with this commit CAKE is = broken, without it isn=E2=80=99t. Here=E2=80=99s tc -s output with the broken version: tc -s qdisc show dev wan qdisc cake 800f: root refcnt 2 bandwidth 1200Kbit diffserv3 dual-srchost = nat nowash ack-filter split-gso rtt 100.0ms atm overhead 48 no-sce=20 Sent 7711782 bytes 5454 pkt (dropped 144, overlimits 15493 requeues 0)=20= backlog 1616b 2p requeues 0 memory used: 140864b of 4Mb capacity estimate: 1200Kbit min/max network layer size: 40 / 1500 min/max overhead-adjusted size: 106 / 1749 average network hdr offset: 14 Bulk Best Effort Voice thresh 75Kbit 1200Kbit 300Kbit target 242.2ms 15.1ms 60.6ms interval 484.5ms 110.1ms 155.6ms pk_delay 0us 60.0ms 26.8ms av_delay 0us 36.7ms 2.0ms sp_delay 0us 17.8ms 1.7ms backlog 0b 1514b 102b pkts 0 5467 133 bytes 0 7913444 17970 way_inds 0 0 0 way_miss 0 44 2 way_cols 0 0 0 sce 0 0 0 marks 0 0 0 drops 0 144 0 ack_drop 0 0 0 sp_flows 0 0 1 bk_flows 0 1 0 un_flows 0 0 0 max_len 0 3028 1118 quantum 300 300 300 qdisc ingress ffff: parent ffff:fff1 ----------------=20 Sent 218759 bytes 3710 pkt (dropped 0, overlimits 0 requeues 0)=20 backlog 0b 0p requeues 0 Here=E2=80=99s the same output with the unbroken version: tc -s qdisc show dev wan qdisc cake 8011: root refcnt 2 bandwidth 1200Kbit diffserv3 dual-srchost = nat nowash ack-filter split-gso rtt 100.0ms atm overhead 48 no-sce=20 Sent 3342962 bytes 2328 pkt (dropped 110, overlimits 6422 requeues 0)=20= backlog 4542b 3p requeues 0 memory used: 83328b of 4Mb capacity estimate: 1200Kbit min/max network layer size: 40 / 1500 min/max overhead-adjusted size: 106 / 1749 average network hdr offset: 14 Bulk Best Effort Voice thresh 75Kbit 1200Kbit 300Kbit target 242.2ms 15.1ms 60.6ms interval 484.5ms 110.1ms 155.6ms pk_delay 0us 56.8ms 9.9ms av_delay 0us 36.7ms 854us sp_delay 0us 9.4ms 680us backlog 0b 4542b 0b pkts 0 2403 38 bytes 0 3509764 4280 way_inds 0 0 0 way_miss 0 17 1 way_cols 0 0 0 sce 0 0 0 marks 0 0 0 drops 0 110 0 ack_drop 0 0 0 sp_flows 0 0 1 bk_flows 0 1 0 un_flows 0 0 0 max_len 0 1514 294 quantum 300 300 300 qdisc ingress ffff: parent ffff:fff1 ----------------=20 Sent 106781 bytes 1896 pkt (dropped 0, overlimits 0 requeues 0)=20 backlog 0b 0p requeues 0 HTH Thibaut=