From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: Ryan Mounce <ryan@mounce.com.au>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] act_conndscp
Date: Wed, 20 Mar 2019 08:25:31 +0000 [thread overview]
Message-ID: <FF583E15-5CC8-4071-9177-F2E513CB2F66@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <CAN+fvRZkEHo4wq26ekaDmkQjygk1v7sPE+WCL73CkEQMYHrgPg@mail.gmail.com>
> On 20 Mar 2019, at 03:31, Ryan Mounce <ryan@mounce.com.au> wrote:
>
> On Wed, 20 Mar 2019 at 07:57, Kevin Darbyshire-Bryant
> <kevin@darbyshire-bryant.me.uk> wrote:
>>
>>
>>
>>> On 19 Mar 2019, at 21:24, Ryan Mounce <ryan@mounce.com.au> wrote:
>>>
>>> Hi Kevin,
>>>
>>> I've finally applied your patches, compiled, and flashed on my router.
>>> Could you share your tc filter action for conndscp to get me started?
>>
>> Ahh! Ooops yes knew I forgot something - here’s my hacked up sqm-scripts/my_layer_cake.qos
>
> Okay... I've just spent far longer than I'd like to admit relearning
> the basics of tc filter in order to minify my scripts, but everything
> is working now. See attached for my usage. I'm back to using the
> Turris Omnia which has more than enough grunt to handle my 100/40
> link, so I haven't put much thought into optimisation.
>
> The only gotcha I ran into with your patch is the explanation
>
>> MODE get (typically ingress) set (typically egress)
>
> This is backwards, but it's confusing anyway. 'get' also sets bits in
> the connmark while 'set' also gets bits from the connmark.
Dammit! And yes it shows how confusing and how easy it is to get confused with the get/set terminology.
>
> I'd suggest changing 'get' to 'save', and 'set' to 'restore'.
> <ryans-cake.txt>
Fortunately the patch was sent as an RFC to netdev and I’m sure they’ll have other things to fix/clarify at the same time.
Thanks for putting your router/s in the testing firing line. So that’s at least two of us doing fun DSCP shenanigans on our routers :-)
Cheers,
Kevin D-B
gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A
next prev parent reply other threads:[~2019-03-20 8:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 20:08 Kevin Darbyshire-Bryant
2019-03-19 21:24 ` Ryan Mounce
2019-03-19 21:27 ` Kevin Darbyshire-Bryant
2019-03-19 21:41 ` Toke Høiland-Jørgensen
2019-03-19 21:51 ` Kevin Darbyshire-Bryant
2019-03-19 21:59 ` Toke Høiland-Jørgensen
2019-03-20 3:31 ` Ryan Mounce
2019-03-20 8:25 ` Kevin Darbyshire-Bryant [this message]
2019-03-20 8:38 ` Sebastian Moeller
2019-03-20 9:01 ` Kevin Darbyshire-Bryant
2019-03-20 9:54 ` Sebastian Moeller
2019-03-20 10:15 ` Kevin Darbyshire-Bryant
2019-03-22 21:24 ` Kevin Darbyshire-Bryant
2019-03-23 18:35 ` Kevin Darbyshire-Bryant
2019-04-01 14:07 ` Kevin Darbyshire-Bryant
2019-04-01 23:52 ` Ryan Mounce
2019-03-20 9:06 ` Kevin Darbyshire-Bryant
2019-03-20 9:24 ` Kevin Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF583E15-5CC8-4071-9177-F2E513CB2F66@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=cake@lists.bufferbloat.net \
--cc=ryan@mounce.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox