From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b=vk6bvrcT; arc=none (Message is not ARC signed); dmarc=none Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by mail.toke.dk (Postfix) with ESMTPS id ACD04177C4D1 for ; Thu, 08 Oct 2026 09:47:28 +0200 (CEST) Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-5356b6a7fe5so27762171cf.1 for ; Thu, 08 Oct 2026 00:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1791445646; x=1792050446; darn=lists.bufferbloat.net; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vwXYbtbP0rsT/5VE/hMx/9ZCnE8bQ7naz2qj5NwTE8Q=; b=vk6bvrcT6BGhrGbRgAKZfPS5Cxob50ruDD4r576D/yCIPp3StCBX0hBWjz8zA0PAfh y6Idf3lF9reeCmYG60GObl0hkLGr7oWxDSrGZhVvxuE7Ni+x8YOoW7zriNGBA/t7BVlz tv39VRTwfg+I02phzfGinyLEn5LRHo2W9glRw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791445646; x=1792050446; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vwXYbtbP0rsT/5VE/hMx/9ZCnE8bQ7naz2qj5NwTE8Q=; b=yVDEorISQm54JIQQcALztqtSCJEdLkCIj9hTgdIYlml6F4iVmGcHPOT+jkF8JdILX0 tUGRDvllC4KIPGrNBV75CDAVKnNIyGhJtIVfEZq1mIF6OZaoJ/astX4DeBiO1jx1XccQ rh9MFbwpJKPDizUTx0ME9f4YbjyySHdJAjeQp0Ghafx8U0KZoHF/ue4dI3PZMRv8T8g9 7hh5mME1zWA/o+dwvzVStQ9bVWqSFD9ACi4IlRwhTN5yfOQnIuOSnKaNskP0Jv0d7xgM R2luuQw1wIx1pzmTS2HS+6ZVqKP3/MRB/l9S3vuJqo8+RLDUadnahIhY+vWYn+Wn5O2w shHQ== X-Forwarded-Encrypted: i=1; AKwUvBzVqMOgvkOS26uW266M5adVN2SQYEA8L6MabTMhTT3VivG7doidNTzA+qTMMIYEW1Ji60gM@lists.bufferbloat.net X-Gm-Message-State: AFuF++n0cXMTMidBDEtABNu82FJ4CuEjSj6G2ohl/XcZ8MBAj04/4FFf 6dNOgXrt7gblJi8ZFbF9eiI+4jgmEilJD4Gr9Il2j3yC5j4ILx15FxGI+T02lX9eHw== X-Gm-Gg: AYBFou1LzVi8vEMHVQcnsgdmDMen5M/shE5mwygA6s6qhszppGsqc7xMUeHU/AguM/d 43CsblE0lBz40O6B5Jv6ACL8fb1vm9ScD3fDmOouDwtaLSBqvvoK12FFqhxqbEXxakG8QCWgdwC ARKaQpQ1+MJSirqilUOZ1wiXfqk/nMfm2iOqu4GOItoMCaiym9dstYB8VfbSNSCbl9Y2iyHZOcO EQhWf5TBCY6gCDDqaN8okLrDt/aQhgEGq6hC1BLzjdQ968s/H1xYuKiyFsT7lmo7hOAyhCP93y5 LKOE0bDxltAbtL5ZOM5JmS8/QrqWFXXSW88yLrdH5Z3bF92yaX3UpOKE8uIpC9uhQ4HvWPr161P Lw6C0yUY59ZmtKp2elkHKAmQ3e/wO+RKCLazUd8X/J6WYkOMMiIp/W/VmQeWnmGzjfGeprRgrsJ 0D8ko8Z/pTsr53niNKihQR2zCqStNonsd00+ikn3H3kHy2CdqZ4SYB81HJosacuzpDXO8hUbUOE 5f9twNl430enfeYAuDXemIuAZDTMKxo3aEGryV3+eRdFIpBJw== X-Received: by 2002:a05:622a:30e:b0:532:9f90:3f71 with SMTP id d75a77b69052e-53574c96022mr80233171cf.0.1791445646290; Thu, 08 Oct 2026 00:47:26 -0700 (PDT) Received: from majuu.waya ([184.147.180.207]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5357213f3dcsm38253961cf.17.2026.10.08.00.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 00:47:25 -0700 (PDT) From: Jamal Hadi Salim To: netdev@vger.kernel.org Cc: Jamal Hadi Salim , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, Victor Nogueira , sashiko-bot@kernel.org Date: Thu, 8 Oct 2026 03:47:08 -0400 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: NS2E4UXM6SN7KSRVBE4MIJOHB57WNR4K X-Message-ID-Hash: NS2E4UXM6SN7KSRVBE4MIJOHB57WNR4K X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] [PATCH net-next 0/4] net/sched: sch_cake: fixes for accounting and reconfiguration List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Four independent fixes in the CAKE qdisc. Three are follow-ups to the autorate reconfiguration work around commit 7cbfb180945c ("net/sched: sch_cake: fix autorate reconfiguration throttling") and the 32-bit admission-counter wraps fixed in gred/bfifo/plug by commit 4c660ee8c809 ("net: sched: fix 32-bit backlog wrap in gred, bfifo and plug enqueue"); the fourth is a dead-code cleanup found while auditing the dump path. Patch 1 serializes a 'tc qdisc change' with the datapath's autorate update under the qdisc lock, so the netlink writer and the autorate writer can no longer lose the configured rate; rate_bps becomes atomic64_t so the 64-bit store is atomic on 32-bit machines too. Patch 2 propagates the backlog reduction of the reconfigure-time tin purge to classful parents, so a CAKE leaf under HTB no longer leaves the purged packets in the parent's qlen/backlog forever. Patch 3 widens buffer_used and buffer_max_used to u64. The u32 accumulator wraps once the resident truesize passes 2^32, bypassing the over-limit drop loop while the configured limit is a u32 attribute. Patch 4 drops an unreachable 'nla_nest_end() < 0' error check: the helper never returns a negative value. All four are hardening for net-next (no Fixes:, no Cc: stable): the counter wrap, the missing parent-backlog propagation and the reconfiguration race all predate any contract we could anchor a regression on. Patches 1-2 were reported by Sashiko (gemini) and patch 3 comes from the gred 32-bit-wrap family; patch 4 is a static cleanup. Jamal Hadi Salim (4): net/sched: sch_cake: serialize reconfiguration with the datapath net/sched: sch_cake: reduce parent backlog when clearing a tin net/sched: sch_cake: widen buffer_used to u64 net/sched: sch_cake: drop dead nla_nest_end() error check net/sched/sch_cake.c | 60 +++++++++++++++++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 22 deletions(-) -- 2.43.0