From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b=BGE2tg6L; arc=none (Message is not ARC signed); dmarc=none Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by mail.toke.dk (Postfix) with ESMTPS id 52C60188C48C for ; Tue, 20 Oct 2026 18:57:40 +0200 (CEST) Received: by mail-qv1-xf2c.google.com with SMTP id 6a1803df08f44-9179bfa9e9cso58225096d6.1 for ; Tue, 20 Oct 2026 09:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1792515459; x=1793120259; darn=lists.bufferbloat.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OLNQJwDVyvERst+Yg4jAyoV+SS5hTnZCgYBGqPPDnM8=; b=BGE2tg6LqmXNJPEhTx4PFAQDhd+ialKHPXnbA7MyBjdP1gcASnP5gal7Ays0XCfqPp 7pEV7YCvltCwGPlmY1hlfZFEZE0aPEGiQdBY8VeeQkEPsp+KKWd3U50rRjmyde32vVio 0VbrY0x6xDb7U61ckiQ28UtQ3R3f1EwucbyMI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792515459; x=1793120259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OLNQJwDVyvERst+Yg4jAyoV+SS5hTnZCgYBGqPPDnM8=; b=bQvrL1t1pFpEyFV1pFrUpWDy3lBpIHPMs2ydd6rGCuyruakDJww117GSH4Dj7EfXlM A5XTrFCCEh1FUYG4Y+s+IKOA5vULaOK3Gm1VGFKJpprFHO7WBvZD0VYKV3tSsShTeanl K4WN2iKKg+jRmjjMRr9W69yumd+yfrcVzRvWVD7kMWNXlmrmNsHococ4Jv478iHu8SMp QSv+Jd5h/Ll1S+MnzOVjHz4gGUevT42SxRcfo+dIpthhGZMw+/8JePeY0yRkWSmuwACb IDvHUj87CqiNVtGXIpLu8m6P0CdC6GdeNp+BdaKAPMTrCPknEI1ic/NtYxgR8m9P810R qdew== X-Forwarded-Encrypted: i=1; AKwUvBzLwk1ynlzrrDFSHtiP2RWJUcKKuHc3If9OYscON9lw1Vt4By+Qp+eqUXhLvSWTkhlxIGTN@lists.bufferbloat.net X-Gm-Message-State: AFq9FYL78e+LTBEv4i38QjHtnBMj1x51/m6DlyGFZiFLUfDPenpNfUlV 6YGQAe8yRWJ8cQKE+EH4yMuetggT7nE8LZIqCDrj5OMYwAPJf4hEtTkpPZcWbdM8ug== X-Gm-Gg: AYBFou2CccPxeph7wvX2+6h+2sajT/Ib5GfZ0ORJmVL7SNBjdb481jS1HXCCl54+WaK DtXhTHsjIi3PGleXowdXfEsF05+kSyBt0wgDS24/Ez32f8XiUlBFrfDzlTkWqI1H3IainAUTdTc h3V599q4qa18NwJuosAvKKeFp7tOlg5yDRCz/xzMs2bSSBk90J0tUTQ3HpTFxV1FqT5UY9habw0 d5yig+okxg0l09rIevS93MwTRX/0tBYzgJ8y1hpcUJOnu6Oc9FVzt4qIxa5vpEZIa78RhFpXrYJ PYSzAqBJPPmmJuoL3HCNcSHS7bX2CQXfifdPCV/pA+GHmbqmz9tVCl5pqmwSP+Mn7ta9fG7/gHr eupX5lbAL/aN5bsAoS+hL+H2YY1t11l3nTESkiMvHryuqjFaMmaTrUZl1k816eF60OypCEh84Yt VWyaM14Wg6xLva3FgmMdIWOm30LaiZrm4QuvfL6gk0ebyp95qlHWU5ROIsn3KymSc+nz2zeQHTB wE8Ql0z3nHAEoS6dS8IHVAfCD6/TkBGnHPE2o+rtNw2 X-Received: by 2002:a05:620a:288a:b0:93e:5ef8:c794 with SMTP id af79cd13be357-93f29d1d050mr1971032285a.38.1792515458660; Tue, 20 Oct 2026 09:57:38 -0700 (PDT) Received: from mbili.waya ([64.203.83.2]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91c10a441acsm3034586d6.6.2026.10.20.09.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 09:57:38 -0700 (PDT) From: Jamal Hadi Salim To: netdev@vger.kernel.org Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Victor Nogueira , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , cake@lists.bufferbloat.net, Sashiko Date: Tue, 20 Oct 2026 12:57:28 -0400 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: VDJ7CWPUQBCSGVNNXENPM2DJT5GX5Z7Q X-Message-ID-Hash: VDJ7CWPUQBCSGVNNXENPM2DJT5GX5Z7Q X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] [PATCH net-next v8 2/4] net/sched: cake: use a dedicated split-GSO list iterator List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: skb_list_walk_safe(segs, segs, nskb) reuses the list head as the walk cursor, so segs no longer names the segment list once the walk finishes. Use a separate seg cursor to keep the head and the walker distinct. No behaviour change. Reviewed-by: Victor Nogueira Signed-off-by: Jamal Hadi Salim --- net/sched/sch_cake.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index 6432d10c992e..0d13c4b0bfe3 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1810,7 +1810,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, WRITE_ONCE(b->max_skblen, len); if (qdisc_pkt_segs(skb) > 1 && q->config->rate_flags & CAKE_FLAG_SPLIT_GSO) { - struct sk_buff *segs, *nskb; + struct sk_buff *segs, *nskb, *seg; netdev_features_t features = netif_skb_features(skb); unsigned int slen = 0, numsegs = 0; @@ -1818,19 +1818,19 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, if (IS_ERR_OR_NULL(segs)) return qdisc_drop(skb, sch, to_free); - skb_list_walk_safe(segs, segs, nskb) { - skb_mark_not_on_list(segs); - qdisc_skb_cb(segs)->pkt_len = segs->len; - qdisc_skb_cb(segs)->pkt_segs = 1; - cobalt_set_enqueue_time(segs, now); - get_cobalt_cb(segs)->adjusted_len = cake_overhead(q, - segs); - flow_queue_add(flow, segs); + skb_list_walk_safe(segs, seg, nskb) { + skb_mark_not_on_list(seg); + qdisc_skb_cb(seg)->pkt_len = seg->len; + qdisc_skb_cb(seg)->pkt_segs = 1; + cobalt_set_enqueue_time(seg, now); + get_cobalt_cb(seg)->adjusted_len = cake_overhead(q, + seg); + flow_queue_add(flow, seg); qdisc_qlen_inc(sch); numsegs++; - slen += segs->len; - q->buffer_used += segs->truesize; + q->buffer_used += seg->truesize; + slen += seg->len; WRITE_ONCE(b->packets, b->packets + 1); } -- 2.43.0