From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b=RHXPTaqW; arc=none (Message is not ARC signed); dmarc=none Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by mail.toke.dk (Postfix) with ESMTPS id A3FC119FD7D3 for ; Tue, 10 Nov 2026 15:41:04 +0100 (CET) Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-91ec2d42231so22189876d6.2 for ; Tue, 10 Nov 2026 06:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1794321663; x=1794926463; darn=lists.bufferbloat.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NKBjJJqfxuTkAi5ii3nEvA/ElY96XwOguRE44CgIv24=; b=RHXPTaqWgqV5UezS0Y6EWXmAqg7cvLMolW0WbWYnUemo5NT6pAAnuOv67ATrssJkKh bI78v1XeaXfQLLodY1Ww3G9INcJjElMwJ15ZfzfmfzURiguIf9ZCAaJNnwx0o3U9qc9O 5F4u9kf0g2b9XyNsRGP2MYHc8e+DmY2GBn+Wc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794321663; x=1794926463; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NKBjJJqfxuTkAi5ii3nEvA/ElY96XwOguRE44CgIv24=; b=jvJ6Zx6lf+7VQLIkvGjUhOXbQ1e+jj+sCbB7oAEv/lK+DlOV7jxuZ+sF32lraEbRI4 Zj+hSbXxPC5WvVcd/PQBCxjyI8tr3UmtQDePW+wWtuop7FeNkzDS1ChOiy65BZqrk7+H cpJxDkqHsc2GPgRanX0xnBrUJIKVmtiGw/UOml9vvNjvLffy7DbbfI7tyUpQC9wD2NcQ HKEYVfhZ23EqQRPI1Jg3ColCMz6XniInCbaELxAwetVJq6/EnhOk4CDo4EW2kGMv/dTc a11/eFAmbELzEg8tv7+q6g7s/YcCozVJzjVRmAYzUd9eJ2QiDuFIns9jF10G45a58pma 1TMw== X-Forwarded-Encrypted: i=1; AL+hErGSqy4I5bumio09Bp8T6d8FYN+7znAj3vU+JJC6pDUKRTeiRtkN+aH912ih5rAJ/08c4ygA@lists.bufferbloat.net X-Gm-Message-State: APuU4Z8pgby9fAZaKM7iE/uUpq9aDQTzldQkIevxoTNzXXqEny4qNTWH 2dZ0iPPURJF07IfdbUjWEn3hWb99D0TTJMmPnMavmBkdArLnCg5+mhCT+QkSq7Y8Qw== X-Gm-Gg: AYBFou0ahcmDmZnMVT+03s5kvKqA6L9tCFdSjGMu+VCEk0XeXpGMVPuhPYp5cLVjdUi KcukEr5RSos8H4GbrPkuw6F9IV+UZZlqQOg+cABxaRImPIzkcwv5iU4IzrxcXcwWJ3qcj4Z42CS SYWNaHE0Miwd/1mReLPGjIDqNCDIGFjvngzuQP7s3t3ZO6z765cdxSuP8q3rAcWaSfRhNZC6a+U TQZ83CjF5pvsu3hDIlEU5X41FwrXDWwU8ZQt7nQPz+/BNiO5IpZkvHilRT4g/BejDWP+vCGH33z jVa4H80Yybx1WoKOXpFFNTTgdegHv5y0voWeA0m+yexcqQWSrtwrTSOIdxgC2UHRANTtk+K3zsU /zD63GXPC3bEdiXcbZVHZWefkjG1HcSE+P4EcqfaIQgTcvHUFqVByyL7AP+2lN3091QCuo0vqoz FzWamk9ejeF+QwFG5iqPpXmbig4pqpS5lbD5/lU1RaxUI9wu56JKYT7zF0F+dioHyKKHbafFItu 8Ph8yEgxUhp7/Di9VPmN3Xp6jm//IiHkBXPXT5KmUkiDQyLDO6fqwtmc+qS3VWHOwsj28UzU+wV vOOVubghnunU9AM1srgKerbjJQ3sXVOWdFXqgXlTww1vJBjYbm3v0tw7Cw0K7QR00DT8TyXQLXg = X-Received: by 2002:a05:620a:7019:b0:93f:6fd6:fbf9 with SMTP id af79cd13be357-9479f31ea1amr450200385a.66.1794321663051; Tue, 10 Nov 2026 06:41:03 -0800 (PST) Received: from mbili.waya ([64.203.83.2]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91f00f6eb88sm1679276d6.39.2026.11.10.06.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 06:41:02 -0800 (PST) From: Jamal Hadi Salim To: netdev@vger.kernel.org Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Victor Nogueira , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , cake@lists.bufferbloat.net, Sashiko Date: Tue, 10 Nov 2026 09:40:53 -0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 57S6TDRLWWLYXICXXX3N5HQUB5EXIXYJ X-Message-ID-Hash: 57S6TDRLWWLYXICXXX3N5HQUB5EXIXYJ X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] [PATCH net-next v9 2/4] net/sched: cake: use a dedicated split-GSO list iterator List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: skb_list_walk_safe(segs, segs, nskb) reuses the list head as the walk cursor, so segs no longer names the segment list once the walk finishes. Use a separate seg cursor to keep the head and the walker distinct. No behaviour change. Reviewed-by: Victor Nogueira Signed-off-by: Jamal Hadi Salim --- net/sched/sch_cake.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index 67cb4cbda1c7..dfc187f48a2f 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1814,7 +1814,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, WRITE_ONCE(b->max_skblen, len); if (qdisc_pkt_segs(skb) > 1 && q->config->rate_flags & CAKE_FLAG_SPLIT_GSO) { - struct sk_buff *segs, *nskb; + struct sk_buff *segs, *nskb, *seg; netdev_features_t features = netif_skb_features(skb); unsigned int slen = 0, numsegs = 0; @@ -1822,19 +1822,19 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, if (IS_ERR_OR_NULL(segs)) return qdisc_drop(skb, sch, to_free); - skb_list_walk_safe(segs, segs, nskb) { - skb_mark_not_on_list(segs); - qdisc_skb_cb(segs)->pkt_len = segs->len; - qdisc_skb_cb(segs)->pkt_segs = 1; - cobalt_set_enqueue_time(segs, now); - get_cobalt_cb(segs)->adjusted_len = cake_overhead(q, - segs); - flow_queue_add(flow, segs); + skb_list_walk_safe(segs, seg, nskb) { + skb_mark_not_on_list(seg); + qdisc_skb_cb(seg)->pkt_len = seg->len; + qdisc_skb_cb(seg)->pkt_segs = 1; + cobalt_set_enqueue_time(seg, now); + get_cobalt_cb(seg)->adjusted_len = cake_overhead(q, + seg); + flow_queue_add(flow, seg); qdisc_qlen_inc(sch); numsegs++; - slen += segs->len; - q->buffer_used += segs->truesize; + q->buffer_used += seg->truesize; + slen += seg->len; WRITE_ONCE(b->packets, b->packets + 1); } -- 2.43.0