* Re: [Cake] [PATCH net-next] net: sched: remove redundant NULL check in change hook function
[not found] <20220827014910.215062-1-shaozhengchao@huawei.com>
@ 2022-08-29 5:36 ` Cong Wang
0 siblings, 0 replies; only message in thread
From: Cong Wang @ 2022-08-29 5:36 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, linux-kernel, toke, jhs, jiri, davem, edumazet, kuba,
pabeni, stephen, cake, weiyongjun1, yuehaibing
On Sat, Aug 27, 2022 at 09:49:10AM +0800, Zhengchao Shao wrote:
> Currently, the change function can be called by two ways. The one way is
> that qdisc_change() will call it. Before calling change function,
> qdisc_change() ensures tca[TCA_OPTIONS] is not empty. The other way is
> that .init() will call it. The opt parameter is also checked before
> calling change function in .init(). Therefore, it's no need to check the
> input parameter opt in change function.
>
Right.. but the one below:
> diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
> index c50a0853dcb9..e23d3dbb7272 100644
> --- a/net/sched/sch_gred.c
> +++ b/net/sched/sch_gred.c
> @@ -413,9 +413,6 @@ static int gred_change_table_def(struct Qdisc *sch, struct nlattr *dps,
> bool red_flags_changed;
> int i;
>
> - if (!dps)
> - return -EINVAL;
> -
I don't think anyone checks tb[TCA_GRED_DPS]. What you intended to patch
is gred_change(), right?
Thanks.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-29 5:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220827014910.215062-1-shaozhengchao@huawei.com>
2022-08-29 5:36 ` [Cake] [PATCH net-next] net: sched: remove redundant NULL check in change hook function Cong Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox