Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: George Amanakis <g_amanakis@yahoo.com>
To: cake@lists.bufferbloat.net
Subject: Latest cobalt updates
Date: Sun, 17 Sep 2017 10:34:26 -0400	[thread overview]
Message-ID: <a3ea0e17-d4ca-1abc-c707-e070a9d0baf9@yahoo.com> (raw)

Dear Jonathan,

I am looking/testing the latest cobalt updates.Most of them make sense. 
I have a question though.
At the end of cake_dequeue() you schedule the watchdog at 
"now+q->tins[i].cparams.target" if "!sch->q.qlen". This seems very 
reasonable. Instead in the beginning of cake_enqueue() you do:

  916                 if (!sch->q.qlen) {
  917                         if (q->time_next_packet < now) {
  918                                 q->time_next_packet = now;
  919                         } else if (q->time_next_packet > now) {
  920                                 sch->qstats.overlimits++;
  921 #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0)
  922 codel_watchdog_schedule_ns(&q->watchdog, q->time_next_packet, true);
  923 #else
  924 qdisc_watchdog_schedule_ns(&q->watchdog, q->time_next_packet);
  925 #endif
  926                         }
  927                 }
  928         }

Is there any reason why you haven't scheduled the watchdog at 
"now+q->tins[i].cparams.target" like in cake_dequeue()?

Thank you,
George

             reply	other threads:[~2017-09-17 14:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17 14:34 George Amanakis [this message]
2017-09-18 19:54 ` George Amanakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3ea0e17-d4ca-1abc-c707-e070a9d0baf9@yahoo.com \
    --to=g_amanakis@yahoo.com \
    --cc=cake@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox