From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nm20-vm3.bullet.mail.ne1.yahoo.com (nm20-vm3.bullet.mail.ne1.yahoo.com [98.138.91.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5C3FB3B29E for ; Sun, 17 Sep 2017 10:34:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1505658868; bh=sAMUxavnJtpMV7jQ6n4HL9F0gmFsKVx2qshXJNHUKKM=; h=To:From:Subject:Date:From:Subject; b=ji3RTPyV0FM2f5EISJ3f2IxqNq7t4f6UKANKYJVtLFn1fNJbfFBkPmWjeIfsXpfv4JfhcCtrJ4JVMYBWwQ5LF4z/KvyaHBFy1pSwMC0CHjW4fSrBIFNTnde6//DARU3GpdlniImhCRun0xD7+NHNheznNmjqriColbYWEJCPIJ94VKi6MZdTloch7KmT9guKTpiZcJ0p8tvSCdDMUOSMzPyQLIUfFHHGz+GmdSt6/NpW8OePZ9jdGSU6LzUd0ehuARF22I4BLvj8A+CwUndVNtJlsFKnztewVpSMh4LrWef/Q7ABCt8lx65AKhJBR1jmyEQejUUi+YdD3uEtHyEYAg== Received: from [98.138.100.112] by nm20.bullet.mail.ne1.yahoo.com with NNFMP; 17 Sep 2017 14:34:28 -0000 Received: from [98.138.84.44] by tm103.bullet.mail.ne1.yahoo.com with NNFMP; 17 Sep 2017 14:34:28 -0000 Received: from [127.0.0.1] by smtp112.mail.ne1.yahoo.com with NNFMP; 17 Sep 2017 14:34:28 -0000 X-Yahoo-Newman-Id: 879945.9959.bm@smtp112.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: QRDKwAYVM1lJ_aGBAEbZtG_3ya7Rrq3_AV_gQRjEnRxCV0u _7XJMlM5b2v4sdGXxITtkFKgQx_of7AR1pSbAFn0GAGvCPPwqTvh44OGr8wt PQV91QsbCctJ.eVb1JKDdKe7tWY2Z8mQM6tpjb5qfDMDKtyiZw..TAFikWw. DKL6y7MMQ9k1klZbgqVOo4pJYPRRBwwgdsmHt5gTz2Ay1Luxfu5kXNlnA6Vy PaUXUppGzTSUIaOCcl8ULOL22GBQcb45qUFK.amqmGqjis8ZvX8q6fIaA8W8 XGUK2Mpj6png9nu_ngPQN1J6XbXjN5zaziS1ts6qmr1ctwv09d8YUE4U.ox5 RlR569ROwLBy2dDqYtmSXjAzjMnY4lJ9AClivXwpEp00L5V5qijIxLa5mKg0 V927IYNlKMiVUSB.3syDiHotZQiF1J0nQBhjSJZN7D6g_0WaTAaSAFk._azY 1kgokEsuBcx69uqNy_wecenNnNW_GBSIEsPPmZDJ1LjxTU90.jEYXVlM- X-Yahoo-SMTP: 6sUo5IiswBDB2TZm6JKJ6DaI.Rsz4O0- To: cake@lists.bufferbloat.net From: George Amanakis Subject: Latest cobalt updates Message-ID: Date: Sun, 17 Sep 2017 10:34:26 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-List-Received-Date: Sun, 17 Sep 2017 14:34:29 -0000 Dear Jonathan, I am looking/testing the latest cobalt updates.Most of them make sense. I have a question though. At the end of cake_dequeue() you schedule the watchdog at "now+q->tins[i].cparams.target" if "!sch->q.qlen". This seems very reasonable. Instead in the beginning of cake_enqueue() you do:  916                 if (!sch->q.qlen) {  917                         if (q->time_next_packet < now) {  918                                 q->time_next_packet = now;  919                         } else if (q->time_next_packet > now) {  920                                 sch->qstats.overlimits++;  921 #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0)  922 codel_watchdog_schedule_ns(&q->watchdog, q->time_next_packet, true);  923 #else  924 qdisc_watchdog_schedule_ns(&q->watchdog, q->time_next_packet);  925 #endif  926                         }  927                 }  928         } Is there any reason why you haven't scheduled the watchdog at "now+q->tins[i].cparams.target" like in cake_dequeue()? Thank you, George