Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Shubhang <sh@gentwo.org>
To: "Jonas Köppeler" <j.koeppeler@tu-berlin.de>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Jamal Hadi Salim" <jhs@mojatatu.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Shubhang Kaushik" <shubhang@os.amperecomputing.com>,
	"Christoph Lameter (Ampere)" <cl@gentwo.org>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	cake@lists.bufferbloat.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [Cake] Re: [PATCH] net/sched: sch_cake: skip redundant cake_mq rate updates
Date: Mon, 26 Oct 2026 16:16:36 -0700 (PDT)	[thread overview]
Message-ID: <a4511177-c3de-9ab5-7ace-74aea1e95db4@gentwo.org> (raw)
In-Reply-To: <3625cee3-3643-4ef8-808d-2fe8267593fd@tu-berlin.de>

Hi Jonas,

>>   -		cake_configure_rates(sch, new_rate, true);
>> +		if (new_rate != READ_ONCE(q->tins[0].tin_rate_bps))
>> +			cake_configure_rates(sch, new_rate, true);
> Thanks! Yes, I think the idea is right. I think we could even omit the
> READ_ONCE.
>
> Best
> Jonas>   		q->last_checked_active = now;
>>   		WRITE_ONCE(q->active_queues, num_active_qs);

Thanks for the review. Yes, the qdisc lock serializes this access,
so READ_ONCE() is not needed. I’ll send a v2 with it removed.

Regards,
Shubhang Kaushik

      reply	other threads:[~2026-10-26 23:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 20:38 [Cake] [PATCH] net/sched: sch_cake: skip redundant cake_mq rate updates Shubhang Kaushik (Ampere)
2026-10-26  8:35 ` [Cake] " Jonas Köppeler
2026-10-26 23:16   ` Shubhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4511177-c3de-9ab5-7ace-74aea1e95db4@gentwo.org \
    --to=sh@gentwo.org \
    --cc=cake@lists.bufferbloat.net \
    --cc=cl@gentwo.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=j.koeppeler@tu-berlin.de \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shubhang@os.amperecomputing.com \
    --cc=toke@redhat.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox