From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-x242.google.com (mail-pl0-x242.google.com [IPv6:2607:f8b0:400e:c01::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E2A1B3CB35 for ; Thu, 19 Jul 2018 10:55:43 -0400 (EDT) Received: by mail-pl0-x242.google.com with SMTP id 94-v6so3771429ple.12 for ; Thu, 19 Jul 2018 07:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dALL7H1iSrTvd1kErQK58qnZJQ58MHzyPj2RqAj6bUM=; b=q7H5jhNkSqLrWpj6GP7lefjEvfOk5McGSFVqGsXbaD5j0iEy8wjCv060Xxnco8eWZs t2DLzHntQueng07+QaR0LK+LuQ1+OQ1UF9xQUzCIOwkIqCQPaIiXBB7JvM2ghHqZtD28 fOVXQcnYu59UE746R67hKqOsuR9hFK9jNtis3kDTReIQ3Qk3QqURf1EQeq45S1SPwlZT ynsWqL2e8TMJmmCJgHBTviwqerCSjZhto8+XackC9xySRjLJ4O65IAd8Cy9LUI0BhOLS 18A9IrEYxTwKt9V1nEYNkaMTxqCx6uTmxgJZiAfgBLMBCa93hokoWyz6fsRtHVVO0vVT npDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dALL7H1iSrTvd1kErQK58qnZJQ58MHzyPj2RqAj6bUM=; b=r1MTD6R6GEOEYmp4ym22QNpA9m0mv3NpJivX/53QTJqF8oLle0h7B2tMjAo5e0B0FM AVD4bmjX+kb3Ai1h8IQH+2atousNB+Ige3Cz4ijqMvan511OYHqKptWQlag9KWzW2sUb 6kTipvG2hoL/hL79BrodPAaEbun2NQfBO11+w/A8q0NgIYrBb5Nih9yBcg/ADXKsS858 w5zmrBFjOIq5MujAecmsqyIgpOrSHXFhi9U3ryn4k/9yP4FcZhdzCXsK5rdgx6ZmXanX xbwhw+D5cPI3BclgNOXgEC5Rw+psY6iqZEJry1/uxJ1+J5jcbOj4mSd4ofKfr+hKLIi+ qXZw== X-Gm-Message-State: AOUpUlFt37CFotnUBe+x0hRXwEN89D9v7gJU13DnthwpFrLssX1AR+DL 6XlR+WOiJectxMwt4Dlz9AI= X-Google-Smtp-Source: AAOMgpcSkd0gN/77Nm1fPaPynkwfai/cF3uRv+NOxwQ76mLzmHO+/ZzMscPcxsQqOQhF7fCQYDy82Q== X-Received: by 2002:a17:902:bb05:: with SMTP id l5-v6mr10489709pls.246.1532012143129; Thu, 19 Jul 2018 07:55:43 -0700 (PDT) Received: from dsa-mb.local ([2601:282:800:fd80:41e6:c9c0:c223:a927]) by smtp.googlemail.com with ESMTPSA id i6-v6sm2728926pgc.7.2018.07.19.07.55.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jul 2018 07:55:41 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , netdev@vger.kernel.org Cc: cake@lists.bufferbloat.net, Dave Taht References: <20180716163926.4826-1-toke@toke.dk> <87bmb34htz.fsf@toke.dk> From: David Ahern Message-ID: Date: Thu, 19 Jul 2018 08:55:40 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87bmb34htz.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 14:55:44 -0000 On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote: > A few comments below; will fix the rest. > >>> + print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth); >>> + print_string(PRINT_FP, NULL, "bandwidth %s ", sprint_rate(bandwidth, b1)); >>> + } else >>> + print_string(PRINT_ANY, "bandwidth", "bandwidth %s ", "unlimited"); >>> + } >>> + if (tb[TCA_CAKE_AUTORATE] && >>> + RTA_PAYLOAD(tb[TCA_CAKE_AUTORATE]) >= sizeof(__u32)) { >>> + autorate = rta_getattr_u32(tb[TCA_CAKE_AUTORATE]); >>> + if(autorate == 1) >>> + print_string(PRINT_ANY, "autorate", "autorate_%s ", "ingress"); This just caught me eye as well ... why the '_' after autorate?