Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
	"Jamal Hadi Salim" <jhs@mojatatu.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Jonas Köppeler" <j.koeppeler@tu-berlin.de>,
	cake@lists.bufferbloat.net, netdev@vger.kernel.org
Subject: [Cake] Re: [PATCH net-next v2 0/4] Multi-queue aware sch_cake
Date: Tue, 2 Dec 2025 21:31:15 -0800	[thread overview]
Message-ID: <aS/LIzlRuJWDGL6m@pop-os.localdomain> (raw)
In-Reply-To: <877bv9b381.fsf@toke.dk>

On Sat, Nov 29, 2025 at 10:25:02AM +0100, Toke Høiland-Jørgensen wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> 
> > On Fri, 28 Nov 2025 23:33:26 +0100 Toke Høiland-Jørgensen wrote:
> >> Jakub Kicinski <kuba@kernel.org> writes:
> >> > On Thu, 27 Nov 2025 20:27:49 +0100 Toke Høiland-Jørgensen wrote:  
> >> >> Yeah; how about I follow up with a selftest after this has been merged
> >> >> into both the kernel and iproute2?  
> >> >
> >> > Why is iproute2 a blocker? Because you're not sure if the "API" won't
> >> > change or because you're worried about NIPA or.. ?  
> >> 
> >> No, just that the patch that adds the new qdisc to iproute2 needs to be
> >> merged before the selftests can use them. Which they won't be until the
> >> kernel patches are merged, so we'll have to follow up with the selftests
> >> once that has happened. IIUC, at least :)
> >
> > You can add a URL to the branch with the pending iproute2 changes
> > when you post the selftests and we'll pull them in NIPA, or post 
> > the patches at the same time (just not in one thread).
> 
> Ah, cool.
> 
> Given the likely impending merge window, how would you feel about
> merging this series as-is and taking the selftests as a follow-up? Would
> be kinda neat to get it in this cycle :)

A followup is definitely okay.

Maybe it is time to think about getting rid of such dependence on
iproute2? I am thinking about replacing those iproute2 commands with
libnl (or other netlink libraries). I know this is a lot of work, but
we have AI today, so perhaps it would just take AI a few days.

Another benefit of this is we would avoid parsing with regex, which has
been a headache even for me.

Anyway, it is a long-term thing.

Regards,
Cong

      reply	other threads:[~2025-12-03  5:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27  9:30 [Cake] [PATCH net-next v2 0/4] Multi-queue aware sch_cake Toke Høiland-Jørgensen
2025-11-27  9:30 ` [Cake] [PATCH net-next v2 1/4] net/sched: sch_cake: Factor out config variables into separate struct Toke Høiland-Jørgensen
2025-11-27  9:30 ` [Cake] [PATCH net-next v2 2/4] net/sched: sch_cake: Add cake_mq qdisc for using cake on mq devices Toke Høiland-Jørgensen
2025-11-29  2:08   ` [Cake] " Willem de Bruijn
2025-11-29  9:21     ` Toke Høiland-Jørgensen
2025-11-29 16:56       ` Willem de Bruijn
2025-11-29 19:33         ` Toke Høiland-Jørgensen
2025-11-30 15:07           ` Willem de Bruijn
2025-11-30 16:19             ` Toke Høiland-Jørgensen
2025-11-30 16:58               ` Willem de Bruijn
2025-11-30 20:34                 ` Toke Høiland-Jørgensen
2025-11-27  9:30 ` [Cake] [PATCH net-next v2 3/4] net/sched: sch_cake: Share config across cake_mq sub-qdiscs Toke Høiland-Jørgensen
2025-11-27  9:30 ` [Cake] [PATCH net-next v2 4/4] net/sched: sch_cake: share shaper state across sub-instances of cake_mq Toke Høiland-Jørgensen
2025-11-27 18:27 ` [Cake] Re: [PATCH net-next v2 0/4] Multi-queue aware sch_cake Cong Wang
2025-11-27 19:27   ` Toke Høiland-Jørgensen
2025-11-28 17:50     ` Jakub Kicinski
2025-11-28 22:33       ` Toke Høiland-Jørgensen
2025-11-29  2:48         ` Jakub Kicinski
2025-11-29  9:25           ` Toke Høiland-Jørgensen
2025-12-03  5:31             ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aS/LIzlRuJWDGL6m@pop-os.localdomain \
    --to=xiyou.wangcong@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=j.koeppeler@tu-berlin.de \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox