From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=O+2Z1jmz; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=redhat.com policy.dmarc=quarantine Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail.toke.dk (Postfix) with ESMTPS id 6F2111930C59 for ; Thu, 29 Oct 2026 12:52:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793274740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hc905M9q4LEkI5HIdNGySZNyIziGO7ISCoqRtqFWyCE=; b=O+2Z1jmzfZ0xkt12auUYvrMjQnYWwdfSDOwwasHofu/jxlkCHpzpID7neSR50KLt0baHc5 gtpS3ns45WMVHHQypu4lemn9TAZcjsEXoIn693LydM+IHZcRJJRLS6U+9YkfTaKIHyHylk SXZvK2txKO/1jCr3MIpgZJdgRrXh/RA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-R-mAxpyGMp6fZTnV0lUkVQ-1; Thu, 29 Oct 2026 07:52:17 -0400 X-MC-Unique: R-mAxpyGMp6fZTnV0lUkVQ-1 X-Mimecast-MFC-AGG-ID: R-mAxpyGMp6fZTnV0lUkVQ_1793274736 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48afcecb035so194743f8f.0 for ; Thu, 29 Oct 2026 04:52:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793274736; x=1793879536; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Hc905M9q4LEkI5HIdNGySZNyIziGO7ISCoqRtqFWyCE=; b=X0kAr24F1M/g7qyZM0QU25wVB0Qc95+ZsEhLXKJOTrJyGUU0V9+OkWzPv49MeIemwv vLnXcfgHEc9uXAw+0Zp6hc0e4h6uIOjCsZcR6/F7xI7QTz8FvSB7qRatZvaBWoExfgWy BozirH++6EDS1ZfTQktX2J8eE0zghUZ0eNaxmIQ7r2tMH6Og7SGL9HnH4tFE1qc45VbD XNTgD3CchA1FQSyUeWEWl8nz10/ZplXNv/7EXnFc8udG5+OT+5Ex0RMQ12awFWO74jfd qaY6U1JhMRghh7sWp/oX3u94yns/M/pUW5wuZANnrddrU2DYAym12ncoBZOS7HFu+BQc 1fiQ== X-Forwarded-Encrypted: i=1; AKwUvBzgsrRM5F6hbz/ogaCByfdt0hcia7Z1h+YOk3JlYSI8pQq8s9dB1fehOoGuAldYUG3PhjGA@lists.bufferbloat.net X-Gm-Message-State: AFq9FYK+nOsor03+/k+IeAQ1O/Iqhf/QLuJxNc0LoRqjOy4V9OE36XLf q+1QAKLFMJsG17dWR95U3Moei3qtEuIHZdF88+SrZ1l05nQIMefSI3WiTNG7ARDNTQ0PlSwT+mU 0tNKhg1qBKo/sLdQRlC2bdV5kWR7sf+Tn4akwqEwpgRy1uTU0PHP6OJooIEdIQfU= X-Gm-Gg: AYBFou3IeaKDsyozgGJbOMzKY5BQ2GwtsyRakNb9Dq0qNylB/JhjlGUKRGBwouoEiJY lhXXM+c+/fKgQuo+MWV3iy2JQcq843YrK2xpMAcYRNgbjv5WacFD/kQsCuJDgbMxrqnxyQkDZxK i/EibDOOAgMi3T/azBfdwcE2IZSdjDCoGqsqJW1yZzT3CKz7u2wkdShaLbf3gvmi82iRZ3ZWk3+ AdzGKWIfCj49ePMLc0ToB3e3x/0iI2W7My6CnvFXVO88p2d6u6nLE1MT5q9AxVQJodzZ0fjnvmm lisF9o7Afup3J7tymoLVcUKQQKM5zKNIH3niVrWjvhHtTXKIHsnM/+2nLZV0kRphBkz4NqlsThr bb024wNVsbSOhfphaGA11gTN4YcsdnBdSaco49qLhI0G6VPD8whlb6aDR2rMpOeNoIEDUqcpCPt k7mW7U/sGX8/dgh14HZzu2uLW1S+Tw6R69lxSyQiLscDoH/Yc= X-Received: by 2002:a5d:540c:0:b0:48a:fad8:52a2 with SMTP id ffacd0b85a97d-48e64ba60d3mr4693976f8f.23.1793274736364; Thu, 29 Oct 2026 04:52:16 -0700 (PDT) X-Received: by 2002:a5d:540c:0:b0:48a:fad8:52a2 with SMTP id ffacd0b85a97d-48e64ba60d3mr4693928f8f.23.1793274735834; Thu, 29 Oct 2026 04:52:15 -0700 (PDT) Received: from [192.168.188.234] (ip174-129-192-82.pool-bba.aruba.it. [82.192.129.174]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ecdfd8dsm32615874f8f.56.2026.10.29.04.52.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2026 04:52:15 -0700 (PDT) Message-ID: Date: Thu, 29 Oct 2026 12:52:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: "Shubhang Kaushik (Ampere)" , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , =?UTF-8?Q?Jonas_K=C3=B6ppeler?= , Shubhang Kaushik , "Christoph Lameter (Ampere)" Cc: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261026-net_sched_sch_cake-v2-1-cb1d4e6ed990@gentwo.org> From: Paolo Abeni In-Reply-To: <20261026-net_sched_sch_cake-v2-1-cb1d4e6ed990@gentwo.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: p3hid03yfgVHlfkQA4EXadCygSDAEFjJTfXIrAVp5Gw_1793274736 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MailFrom: pabeni@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: NEUX7F4X3TEGJK5F23S4EWGFXXPQHATJ X-Message-ID-Hash: NEUX7F4X3TEGJK5F23S4EWGFXXPQHATJ X-Mailman-Approved-At: Thu, 29 Oct 2026 13:28:56 +0100 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH v2] net/sched: sch_cake: skip redundant cake_mq rate updates List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/27/26 05:32, Shubhang Kaushik (Ampere) wrote: > cake_mq periodically counts active child qdiscs in cake_dequeue() and > derives an effective per-child shaper rate. cake_dequeue() currently > reconfigures every tin after each scan, even when that effective rate > is unchanged. > > The dequeue-time call chain is: > > cake_dequeue() > -> cake_configure_rates(..., true) > -> cake_config_*() > -> cake_set_rate() > > With rate_adjust=true, cake_set_rate() only refreshes rate-derived > state. Tin 0 records the unscaled rate argument in every supported > CAKE tin mode, so its installed rate identifies whether this call chain > would change any state. > > Skip the reconfiguration when the effective rate is already installed, > while continuing to update the activity-sampling timestamp and > active-queue statistic. > > Fixes: 1bddd758bac2 ("net/sched: sch_cake: share shaper state across sub-instances of cake_mq") > Signed-off-by: Shubhang Kaushik (Ampere) IMHO this is borderline material for 'net'. Was any regression visible on top of 1bddd758bac2, e.g. in term of CPU usage? /P