Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Georgios Amanakis <gamanakis@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Kevin Darbyshire-Bryant" <kevin@darbyshire-bryant.me.uk>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] tc not showing detailed stats
Date: Sun, 20 May 2018 21:09:22 -0400	[thread overview]
Message-ID: <c117274520b343ce4ffd90b10840f3d170d84a21.camel@gmail.com> (raw)
In-Reply-To: <87tvr2xd1w.fsf@toke.dk>

I am well aware of that :)
On my system though with tc-adv@aa554002 and sch_cake/cobalt@842d7f0
it doesn't produce any detailed stats:

% tc -s qdisc show
qdisc cake 8009: dev ens4 root refcnt 2 bandwidth 18Mbit diffserv3
dual-dsthost ingress split-gso rtt 100.0ms noatm overhead 18 mpu 64 
 Sent 5098 bytes 35 pkt (dropped 0, overlimits 0 requeues 0) 
 backlog 0b 0p requeues 0
 memory used: 4Mb of 2250000b
 min/max network layer size:            2 /      88
 min/max overhead-adjusted size:      248 /     106
 average network hdr offset:         2304

!!!Deficit 4, rta_len=266


I bisected it and it's definitely commit sch_cake/cobalt@842d7f0.
Now if I introduce TCA_CAKE_STATS_PAD at the end of the enum, this
resolves the bug. i.e.:

--- a/pkt_sched.h
+++ b/pkt_sched.h
@@ -883,7 +883,6 @@ enum {
 
 enum {
        __TCA_CAKE_STATS_INVALID,
-       TCA_CAKE_STATS_PAD,
        TCA_CAKE_STATS_CAPACITY_ESTIMATE64,
        TCA_CAKE_STATS_MEMORY_LIMIT,
        TCA_CAKE_STATS_MEMORY_USED,
@@ -893,6 +892,7 @@ enum {
        TCA_CAKE_STATS_MIN_ADJLEN,
        TCA_CAKE_STATS_MAX_ADJLEN,
        TCA_CAKE_STATS_TIN_STATS,
+       TCA_CAKE_STATS_PAD,
        __TCA_CAKE_STATS_MAX
 };



George


  reply	other threads:[~2018-05-21  1:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-20 13:23 Georgios Amanakis
2018-05-20 15:43 ` Kevin Darbyshire-Bryant
2018-05-20 15:59   ` Georgios Amanakis
2018-05-20 16:21     ` Toke Høiland-Jørgensen
2018-05-20 17:08       ` Toke Høiland-Jørgensen
2018-05-20 20:40         ` Georgios Amanakis
2018-05-20 20:55           ` Toke Høiland-Jørgensen
2018-05-21  1:09             ` Georgios Amanakis [this message]
2018-05-21 14:00               ` Toke Høiland-Jørgensen
2018-05-21 15:14                 ` Georgios Amanakis
2018-05-21 15:35                   ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c117274520b343ce4ffd90b10840f3d170d84a21.camel@gmail.com \
    --to=gamanakis@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=kevin@darbyshire-bryant.me.uk \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox