From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x22f.google.com (mail-qt0-x22f.google.com [IPv6:2607:f8b0:400d:c0d::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 661D53B29E for ; Sun, 20 May 2018 21:09:28 -0400 (EDT) Received: by mail-qt0-x22f.google.com with SMTP id m16-v6so17064990qtg.13 for ; Sun, 20 May 2018 18:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=F9Qy+8eJeUe4mAJHMnJH56L/uSFHSSAhqkt4/37rrxg=; b=VSJtX/ODn/X6g4W6/tQ4ndkGlmcnc+rFuBY7H95YdXoGQvpLzJOHm9eVajQB19SDzc L6/+DEiSiT8xoQlpYS5J2E/IeA5xcKNi/gNC783hgDv7uTdMD8aWlUf6PeUREwhlbX1h znwIEbybg5hlKZx3UF9r+bmYBNmnHwaqiLzbHr8vDpS9qIWyp2g5uJHyxtkhxruMfZCR pjwco7GM7E7+5eHerxCzXoc/EDCeBcjcTLe8UWoTchmCxqLQ+aLmHvLL34oZTHzG58rP X+mUTqSgC6ARfAFvJmrdZEqzl3CCY8Vd1c765XGCVO7+3y/gPRjqsaLaCSQ+PtrvqI7R HRTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=F9Qy+8eJeUe4mAJHMnJH56L/uSFHSSAhqkt4/37rrxg=; b=IoTT1h8jxBhwwt6nSnanSTOJpWsT503+ak/4hR1YMtnm7esKOxSgqzB3S4to9QWySc Zt4Ea5+gbRXXDGkrczbjDYVjvQrHYBraHAok5OsKb+XUHavTbOGQNqSJNuiaVjmrxMj1 drENfiDZ1ehJVseOegfLH8Mw67jRyA7x++H28ze6vyxeW3IOuaKo+rgVmVS3abvNFukf TIkpDCiybZJF9OBAPdGg4zRwwc5+9bXsnuy/hOph50z04WlMm55bdTPB9DU4ZXftdo0X HauymVWsG8solsnZW0kIEEz1tfQRkcKMVtsIrgi8Jn2LCiu7AbiT/s3vnJRSS0G1R42l o4YA== X-Gm-Message-State: ALKqPweG6lBPl6mEWx7bTXHTWY/5clFXZnrkINCRobly3sPvgbYm9Qv9 ItAISg4Ju7h6pHpsAVO3hZg= X-Google-Smtp-Source: AB8JxZqMkalRkL2tBqcKCYXd4dDmXUnuMq55bXYE3L82nbR+aXVEm3KV1K45sZnNTtlwhttgtadREg== X-Received: by 2002:ac8:424f:: with SMTP id r15-v6mr15909591qtm.395.1526864967752; Sun, 20 May 2018 18:09:27 -0700 (PDT) Received: from x3200.lan (c-76-111-113-146.hsd1.md.comcast.net. [76.111.113.146]) by smtp.googlemail.com with ESMTPSA id y5-v6sm6655747qkd.33.2018.05.20.18.09.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 May 2018 18:09:26 -0700 (PDT) Message-ID: From: Georgios Amanakis To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Kevin Darbyshire-Bryant Cc: Cake List Date: Sun, 20 May 2018 21:09:22 -0400 In-Reply-To: <87tvr2xd1w.fsf@toke.dk> References: <9d73f1230b36d0c3ff9f35c38fafbece41404c96.camel@gmail.com> <5657EE7F-4A67-4E0C-9ECE-64F5BD67C3FB@darbyshire-bryant.me.uk> <87zi0uxpp6.fsf@toke.dk> <87wovyxnjr.fsf@toke.dk> <987bfc2f508c224c8d2ce672160670bfff691512.camel@gmail.com> <87tvr2xd1w.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Cake] tc not showing detailed stats X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 01:09:28 -0000 I am well aware of that :) On my system though with tc-adv@aa554002 and sch_cake/cobalt@842d7f0 it doesn't produce any detailed stats: % tc -s qdisc show qdisc cake 8009: dev ens4 root refcnt 2 bandwidth 18Mbit diffserv3 dual-dsthost ingress split-gso rtt 100.0ms noatm overhead 18 mpu 64 Sent 5098 bytes 35 pkt (dropped 0, overlimits 0 requeues 0) backlog 0b 0p requeues 0 memory used: 4Mb of 2250000b min/max network layer size: 2 / 88 min/max overhead-adjusted size: 248 / 106 average network hdr offset: 2304 !!!Deficit 4, rta_len=266 I bisected it and it's definitely commit sch_cake/cobalt@842d7f0. Now if I introduce TCA_CAKE_STATS_PAD at the end of the enum, this resolves the bug. i.e.: --- a/pkt_sched.h +++ b/pkt_sched.h @@ -883,7 +883,6 @@ enum { enum { __TCA_CAKE_STATS_INVALID, - TCA_CAKE_STATS_PAD, TCA_CAKE_STATS_CAPACITY_ESTIMATE64, TCA_CAKE_STATS_MEMORY_LIMIT, TCA_CAKE_STATS_MEMORY_USED, @@ -893,6 +892,7 @@ enum { TCA_CAKE_STATS_MIN_ADJLEN, TCA_CAKE_STATS_MAX_ADJLEN, TCA_CAKE_STATS_TIN_STATS, + TCA_CAKE_STATS_PAD, __TCA_CAKE_STATS_MAX }; George