From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x22b.google.com (mail-pg0-x22b.google.com [IPv6:2607:f8b0:400e:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B1FBD3BA8E for ; Wed, 25 Apr 2018 12:57:33 -0400 (EDT) Received: by mail-pg0-x22b.google.com with SMTP id 82so3906187pge.11 for ; Wed, 25 Apr 2018 09:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+goeUh+9vOc0luoAecCupqW0n95nmN/icx5+K2Lsdes=; b=nY8h+5tLtamHz3ooZ2/VMkUGLnF7eRiHUb8d4wrjBTMqjNDrGJokmIf3V5gAlxM9bb o9Va8GTnIEodTqkJbmqoMaJpCuwnonqF9rOJSCdtealhV2uXI+rZ1obCj92Dhtqdc/RF XBW5754OpfHSk++xw/DQy7aflLl4vbhnT8FdWJHbRRednepnvLtCKVIiYJQ8KOBGAWUJ JK+v673zgd7cDhyZ8sGEbkQ7FtjAkHitxTV7pnYVkkosv2st5gDRLw/eB7AGeE6bmHeX 4bkFATROlsI+Evmmo4cr+Doyk4CUnuLCgfzJajY8lG1Q7wFb3evNIl8rxdGeqBngkojr mb/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+goeUh+9vOc0luoAecCupqW0n95nmN/icx5+K2Lsdes=; b=J1b/Lpj/mvJcdza9MfM3vpMNeZ73f1Z/NEqSFXtd3uPouHj+f7Ku6qREXLz3Bk91Rc nBMqVeYVA9PH6tMv1AscNzi3U6JxSyPzWK5U1yaB0E0lGXl5ewyKslPqvK1A+019pl/V tP5daWzHtJPCRzVxrwapBm9idCkYfm0NfLHj/aatHHVkhGHyWWp7oGDm/ptkSdjvTb1P S7rtGam5lKGG+Zc0EuiHeKG72R0wktqlzQoazjXei5BNEvBsPeU7j4l/ps9BhAWp8Uiq rCn2TsT58ltUIKACL/pSgbHFp0NufG7BBq9ZZXFei2cUpbeqx1z/EO1vNh2RIvha7828 zCKQ== X-Gm-Message-State: ALQs6tAPf1Z6hxjcMaLjFrC2gmthF9pj33u+nKMwu8FOUGV/7QO0cvYE bWdj89V9wbGc4mhub39wx0gtlgRv X-Google-Smtp-Source: AB8JxZpkX51NK/uMsVSo1BKpiKW3d5msT7WJzn2N5eG+QOgo5d3kgZ4mM9sljdt2cf0EK6PWqwV/dQ== X-Received: by 2002:a17:902:8343:: with SMTP id z3-v6mr9298754pln.71.1524675452703; Wed, 25 Apr 2018 09:57:32 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id 125sm29736343pff.158.2018.04.25.09.57.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 09:57:31 -0700 (PDT) To: Jonathan Morton , Eric Dumazet Cc: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , netdev@vger.kernel.org, cake@lists.bufferbloat.net References: <20180425134249.21300-1-toke@toke.dk> <878t9b5n0q.fsf@toke.dk> <6bc11ded-028f-6c8f-964e-a569b4e10813@gmail.com> <8736zj6zj2.fsf@toke.dk> <8bae2ee1-efcc-1571-2a30-5b7779de2c88@gmail.com> From: Eric Dumazet Message-ID: Date: Wed, 25 Apr 2018 09:57:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Cake] [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 16:57:33 -0000 On 04/25/2018 09:52 AM, Jonathan Morton wrote: >> We can see here the high cost of forcing software GSO :/ >> >> Really, this should be done only : >> 1) If requested by the admin ( tc .... gso ....) >> >> 2) If packet size is above a threshold. >> The threshold could be set by the admin, and/or based on a fraction of the bandwidth parameter. >> >> I totally understand why you prefer to segment yourself for < 100 Mbit links. >> >> But this makes no sense on 10Gbit+ > > It is absolutely necessary, so far as I can see, to segment GSO superpackets when overhead compensation is selected - as it very often should be, even on pure Ethernet links. Without that, the calculation of link occupancy time will be wrong. (The actual transmission time of an Ethernet frame is rather more than just 14 bytes longer than the underlying IP packet.) Just fix the overhead compensation computation in the code. skb in a qdisc have everything you need. qdisc_pkt_len_init() has initialized qdisc_skb_cb(skb)->pkt_len with the exact bytes on the wire, and you have gso_segs to perform any adjustement you need to do. Do not kill GSO only because you do not want to deal with it. > > Another reason to apply GSO segmentation is to achieve maximal smoothness of flow isolation. This should still be achievable within some tolerance at high link rates, but calculating this tolerance is complicated by the triple-isolate algorithm. > > If there's a way to obtain the individual packet sizes without incurring the full segmentation overhead, it may be worth considering (at high link rates only). I would want to leave it on by default, because some of Cake's demonstrably superior latency performance depends on seeing the real packets, not the aggregates, and the overhead only becomes significant above 100Mbps on weak MIPS CPUs and 1Gbps on vaguely modern x86 stuff. > > - Jonathan Morton > Again, these arguments are moot on 10Gbit+. Lets build the future, do not pretend GSO/TSO is not part of it. Thanks