From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x22b.google.com (mail-pg0-x22b.google.com [IPv6:2607:f8b0:400e:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 46A403BA8E for ; Mon, 21 May 2018 14:09:00 -0400 (EDT) Received: by mail-pg0-x22b.google.com with SMTP id d14-v6so3104108pgv.8 for ; Mon, 21 May 2018 11:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=kSro3KOijDFP1sT5iRHVOYYIOjqpx3TK4Pt7C5Z1+2Y=; b=bL4CBaOok4kZLWoODWv8GsKIrcJvZs9M86WsvYmdoMuk6n67skqzaTklwZfAjevWUv uGAvvi+fxZDK1vdjbPh0NQdiDw7+boD3FEOgJa2CBBPbZanv3mWYdKi6ZdgeGB/4pcUA TnWATieHvFFuUMbrT9Kys5BZf6Xl8GT3FFLG3LXeOueWYTLGf6WF3yi7Fih49rkbd7m/ 7DiPg//5OrpaGyrG3Y7ibgRTxbPbJ8PyldgLHK1snsCLJNBFk73nsMNBmnyQDub4tYwi 6QyVwIxrIA5xhb2DWsKdNTX5QGqHWaOJLqQHOuvFtwFKB9GlEIjwwXr2NZJwmzdiiUTQ 1Wvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kSro3KOijDFP1sT5iRHVOYYIOjqpx3TK4Pt7C5Z1+2Y=; b=gRESmDQjdozCyXo2UIXSC6jf4XkzMivsy5/P5wI1mGs9EMGFzBa3e2GxSKhcWyFURT ZaKpLgIR8Jxv+/qKDQlm8xWFixYwNDi8UWmMMciddFCh9HZzXG0EVnxD76fMFfTPqPmW BZuBTOzAyV9e1vQh7zPeeeR89lC2ETJLWPlYVVPHuE9Xa1EE8ww9tJsGgniCdGImJtfX 5gDgTO68v2K2Vm7OIEF3P+W8SFEfZDdQz4nWvS40xlN3Mdv8MrkDVC1SB0H7e1f3Of8r eHVCtHXtqQ27BJR7F2drVBoT+14JNxjduezwumZCXxFstJ3o2KD008aTd09FVR492XT0 IFZw== X-Gm-Message-State: ALKqPwd2pdx/c8BL5/wVYQHe8y9S6HA6zrV1QYWrkiioyg1oa3RL6Wxw rwLd2teFtPj7NJQUvDCzKuYHciwL X-Google-Smtp-Source: AB8JxZr7oOOsbtWoa1+KLC/H0ondD+/VozIFbXJkzwzo4KYAQUTvrEoqjkLqAuCkYNzG1q9iKKOXoA== X-Received: by 2002:a62:4184:: with SMTP id g4-v6mr21082905pfd.51.1526926139302; Mon, 21 May 2018 11:08:59 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id t28-v6sm29267764pfk.161.2018.05.21.11.08.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 11:08:58 -0700 (PDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Eric Dumazet , netdev@vger.kernel.org, cake@lists.bufferbloat.net References: <152691970035.4083.3349902669266371765.stgit@alrua-kau> <152691985736.4083.3416150561524698541.stgit@alrua-kau> <87r2m4ykrc.fsf@toke.dk> From: Eric Dumazet Message-ID: Date: Mon, 21 May 2018 11:08:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87r2m4ykrc.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Cake] [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 18:09:00 -0000 On 05/21/2018 10:35 AM, Toke Høiland-Jørgensen wrote: > Ah yes, sequence number wrapping. I was thinking I needed to deal with > that, and then got sidetracked and forgot about it. Will fix. > > Other than that, do you agree that this approach to SACK and header > handling can work? Unfortunately this does not handle dsack (RFC 2883, and 3708) properly, I believe.